Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Apr 2022 10:26:55 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Robert Foss <robert.foss@linaro.org>
Cc:     Rob Herring <robh@kernel.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, bliang@analogixsemi.com,
        qwen@analogixsemi.com, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to
 7 (DPI)
Message-ID: <20220414022655.GA606685@anxtwsw-Precision-3640-Tower>
References: <20220328120956.1848795-1-xji@analogixsemi.com>
 <20220328120956.1848795-3-xji@analogixsemi.com>
 <YkswTpDiPYfdIFtE@robh.at.kernel.org>
 <20220409044740.GA595530@anxtwsw-Precision-3640-Tower>
 <CAG3jFyt1Srtn2aTFQ6b8Rxc6F_GCzU2mKxiEiWwgskMwHHjj5Q@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG3jFyt1Srtn2aTFQ6b8Rxc6F_GCzU2mKxiEiWwgskMwHHjj5Q@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wALdjCFwHTr8HoMA1x7woshKgZ7V35VgtTCr2wCF0/68nK09Zvz1lae4B5Ag?=
 =?us-ascii?Q?3C4dVWKNVumcD2dwvgdJt3VQAIEGRLweLy3MjNr9v22ghJzzC1rI9WC7Atv9?=
 =?us-ascii?Q?P+p+g/GvMLedFSHGatlgpiLK3BIWgg0YSyIQqtotCvlSvhYs+hnf+RIj+RoV?=
 =?us-ascii?Q?kZ5wQEbjueuMQ/TaNrHdwb3R00C3LP8xUzA+4zQTEH4FaRnibYW+oSq1OAgs?=
 =?us-ascii?Q?lP4S8CB6z5JcnyDHgr+XnGSkauX39K05D9dUN/L3yF7RgGQ/h6BzpRapCq+d?=
 =?us-ascii?Q?YwZxERT3V6M2ahIXTHgXebx6LxUecpkA4OUHnJvlYukEFxS4ZwdNrtkDX1Cc?=
 =?us-ascii?Q?KmfXO/4dB0LI0xgHCMOE1pnjD5p9fWr70V9/ITBbZvNYc7pnqRCZMw1eH/cD?=
 =?us-ascii?Q?pUg/HG0xqGBW955yuc7tR0iZXSyBO1kZwedpPk94S5BmVc9QHrnZAfLZS291?=
 =?us-ascii?Q?KPBLhGGDDzN5PrbQ23a31K0AQm4XkDxsV8zK+e9SuHewO28hV/0Kh2iJAhhg?=
 =?us-ascii?Q?nsMWOy5lgQc/gD9fyci4XHC1qNvVE/NQJ24Nj3EhD6DardKbzWD9KPkOIYQx?=
 =?us-ascii?Q?S+CzsippDy/I0eNV5sTFUqpoG6Q1SVO6pSVKGRKODSkPgJ4YEx1Bxbb5VgYu?=
 =?us-ascii?Q?JN0t14Fnbe477hnVEZElR4+8uFO2xdgqhnHI929AGtwI0RI196gU+Agdci7f?=
 =?us-ascii?Q?DMYEb2REt/fAXU6UF/Cb//cwNTeNsSz78qnUqGkuYALC5cEZfMaLvQIWpIYy?=
 =?us-ascii?Q?WuRQ7lr6M3/1B19ZukZeb024GvBbWnOr3cVNTbWAt0IpmNDvD8KAx376ZVjJ?=
 =?us-ascii?Q?EBLBoXfPUJvwPjsqLIbJyMK/09ORY5s1rXbowTfRpvfLddmQff03OACxSeOp?=
 =?us-ascii?Q?m9CIyC+NhwHEKRd38zJWPcNRldHCa6qdIsVLfMXUzoCWT2ZciVLuiO7GmUVD?=
 =?us-ascii?Q?K8dr5/C94O8yE/kGxy/Q5DJnVSvDcoBQP0Vur3K+KM2tPgpgMi2OaEFwiyW9?=
 =?us-ascii?Q?NV0R9UH2d+eYzfB7XyLYlmP8pPpXEYB5X1kUcdqW1o/g8DUn64FzHkp36y61?=
 =?us-ascii?Q?Milla5ufXWkV5wL67HuR38C0kd/w+owAZnQ91YgjzixUuwrzu9GpSD3UyL+Z?=
 =?us-ascii?Q?fcQe0ABL0YV10o7R/AlbriTUrcQh8VvxehyaKBP+PN+9V4kTomrpbezzZlo1?=
 =?us-ascii?Q?H+bNAgs/bTvOzv7nXFlD80A/FA3wrbLb19670HT/T+hcoY+S2VIxznpk/9t7?=
 =?us-ascii?Q?JgNyKcgmjOIEF69/PFWo+g3Xps6msODSa2XbuPQC0CfolJMOLqdDhhVWidrK?=
 =?us-ascii?Q?tHceedT4C32GI32j3UcSIviIgnlvQk+GBPL1xhTX1YE7BvjIkSm+cWl6uaCz?=
 =?us-ascii?Q?GHNaErUUvc2TJgN2HjA0q28Pv8U00TMqv7vQlz0N1ncFrBwuG7/zTQOFYmXp?=
 =?us-ascii?Q?rUiP7vieb7dFrGoSQRjYOKLCXi5Pah04nzUMQQ+7ZQEf8VUfeFhgRZ07ml7p?=
 =?us-ascii?Q?4bF915wlAFJbHkH5AwBNTi78USq87w4umhpoATDR67TVaSIUd3CC4xvWJWuZ?=
 =?us-ascii?Q?jf/IG+OmWztngC7eK4QzV8YakDkO4dZyPUSnEt5feoO0HVqYe0j18DqPr1Er?=
 =?us-ascii?Q?NsYEb6JtnJMcoKEzPyNL3We1gHJ6JmdY2ZOT82ZcAy+V7nKRqDdO+V+so1tH?=
 =?us-ascii?Q?rKUBAQLt6VsP1kZIGjXZ7rc3ddStT75mNEu391qL8PYbuFwakY0aOzbVgFeH?=
 =?us-ascii?Q?V6FilNKJSw=3D=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e1e596b-fb7c-41b1-37cf-08da1dbe42a2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 02:27:02.9495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZOTaktAYSz1zYIEztLbck2UQ8HtxsAkuGVI2YXtWM0P5bHrsMoricHZ+BPcOHjBHdntZXz9/kYnN441TxcyArA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6680
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 13, 2022 at 04:28:51PM +0200, Robert Foss wrote:
> On Sat, 9 Apr 2022 at 06:47, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote:
> > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote:
> > > > Change bus-type define for DPI.
> > > >
> > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define")
> > > >
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > >  .../devicetree/bindings/display/bridge/analogix,anx7625.yaml  | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > index 0d38d6fe3983..4590186c4a0b 100644
> > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > @@ -106,7 +106,7 @@ properties:
> > > >                remote-endpoint: true
> > > >
> > > >                bus-type:
> > > > -                enum: [1, 5]
> > > > +                enum: [7]
> > >
> > > Changing is an ABI break, but didn't we revert adding this?
> > Hi Rob, sorry, what do you mean about ABI break? Do I need remove this
> > patch in this serial? Or do I need revert patch
> > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F462331%2F&amp;data=04%7C01%7Cxji%40analogixsemi.com%7C10f5b0213f434592936008da1d59f566%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637854569490105386%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=vK0Vmb9S425kHZc1WurfnNhnoXDMbUGkkdY1PVnfS9g%3D&amp;reserved=0, I don't know how to do
> > it.
> >
> 
> I contributed to the confusion about this, let's see if we can clear it up.
> 
> An issue was found related to which enum values were used to represent
> what late in the last release cycle. As a result a revert[1] patch for
> everything touching bus-type in anx7625 was merged.
> 
> This patch, does not apply to drm-misc-next due to the revert, and if
> Xin Ji rebases his work on the drm-misc-next there should be no
> ABI-change as this patch when fixed up will introduce bus-type to the
> nax7625 ABI.
> 
> Xin: Does this make sense to you?
Hi Robert Foss, yes, my work is based on drm-misc-next, all I can do,
just make a fix up patch(this patch) to change the bus-type define.

Thanks,
Xin
> 
> [1] https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fdrm%2Fdrm-misc%2Fcommit%2F%3Fid%3D979452fbc43028675b5a5da156f91928b739dea8&amp;data=04%7C01%7Cxji%40analogixsemi.com%7C10f5b0213f434592936008da1d59f566%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637854569490105386%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=onmKAoEEP1XDbl%2FaeAIfVYJ4cSbiTfTBYCd%2BHCA9fzw%3D&amp;reserved=0