Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Apr 2022 17:31:57 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH 02/18] objtool: Support data symbol printing
Message-ID: <Ylg+bewBpaqqYgeB@hirez.programming.kicks-ass.net>
References: <cover.1649891421.git.jpoimboe@redhat.com>
 <097057f88605aa67b0e3ec573fcf394ae7ac4d6f.1649891421.git.jpoimboe@redhat.com>
 <YlfHy011VP2oPFjV@hirez.programming.kicks-ass.net>
 <20220414152148.cwdefx744kymqcut@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220414152148.cwdefx744kymqcut@treble>
Precedence: bulk

On Thu, Apr 14, 2022 at 08:21:48AM -0700, Josh Poimboeuf wrote:
> On Thu, Apr 14, 2022 at 09:05:47AM +0200, Peter Zijlstra wrote:
> > On Wed, Apr 13, 2022 at 04:19:37PM -0700, Josh Poimboeuf wrote:
> > 
> > > @@ -34,8 +37,8 @@ static inline char *offstr(struct section *sec, unsigned long offset)
> > >  
> > >  	str = malloc(strlen(name) + 20);
> > >  
> > > -	if (func)
> > > -		sprintf(str, "%s()+0x%lx", name, name_off);
> > > +	if (sym)
> > > +		sprintf(str, "%s%s+0x%lx", name, is_text ? "()" : "", name_off);
> > >  	else
> > >  		sprintf(str, "%s+0x%lx", name, name_off);
> > 
> > So I like the patch, except that "()" thing is something where we differ
> > from the kernel's %ps format and I've cursed it a number of times
> > because I then have to manually edit (iow remove) things when pasting it
> > in various scripts etc..
> 
> Oh, hm, that's true.  I can remove them if you prefer.

Yeah, I think taking it out is best, easier if we're consistent with %ps
for everybody.

> > That said, it totally makes sense to differentiate between a text and
> > data symbol this way :/
> 
> Yes, but if we're keeping the "Add sec+offset to warnings" patch then
> that distinction is already (kind of) being made by showing the data
> section name.  And the data symbol warnings should be rare.

Yes, I'd not seen that yet, what's that for? The Changelog alludes to
something, but I don't think it actually does get used later.