Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp365109pxb; Fri, 15 Apr 2022 01:07:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaMaaV+JMnJDle/X30sasb7jD7HbK0nb24cfQg+s4oTxyYBn+eB0q2Uc7pVMsYVBQkbmHa X-Received: by 2002:a05:6402:350b:b0:421:97d3:3bc7 with SMTP id b11-20020a056402350b00b0042197d33bc7mr4820819edd.333.1650010059014; Fri, 15 Apr 2022 01:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650010059; cv=none; d=google.com; s=arc-20160816; b=zCHLG2oTFG7giVM82dA0c9KVrBDGtReYuqlJRPTXXJ1niNeb/ubBwUSthI1Iq30BP/ 2aC3vLSY45VVwZesTIsQJFzUMEca4mSXlI9FfWnRNpFy+G+pvadRs8Bn/1X0udZJTwYY FIo6wp3zgPplxPFZyaVaK/mlvwNPsnXskM/ELRiqdJFIiaJZRsdmr/mJ06yqQPRQM/uu ZJa+4tXybErQYFkaIUxG/CMNv7jsApGttIKTU9u3pi5yHLkT6uqTawXgKQdQoPxgHLi+ ChJ8aA+LzjoWx2gN0gDyWpu15k1klskil/e8zLkMgZaUdq68pwD5rdsrpSJQENGqqP19 gdVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GdQfGxCXfdHiLKx0XYK3usSDpPXKEHJrcncLZSvBuPI=; b=q14Sp/aPj7WoqF5YhM8fC1sX9mLuQj6VMzQ/N1IwolmqmVwxwygN2XVGYPtDOs/6VZ 58Mov8yB55zJ/RlXyzNZsb2AxGfn3Exq75RB5l+LG+pjmXLvV1pSTF1H3qtVRqp/VQYY uvu+32sx8eldcEE41ODft+WLdBuF6m9ObSq4FO+epJXTRP59GratzA1KP6O1vaiNUpFA NSFYuqTbeEpdqu7Rb4bL00Ls7KYxlGYTPrPc8R8LbsNfiAzBcZWpGu8kk+dA8OL8V1ap Nesd8DU6AUjaQVlTs6d4gp0D0E8KxuGkN5ZfrfYztxYpg1UnN/iKmhzFJqQFmb3jOhnO M2EQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=LEDdZP6w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f6-20020a1709064dc600b006e89cb29660si508903ejw.994.2022.04.15.01.07.13; Fri, 15 Apr 2022 01:07:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=LEDdZP6w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241924AbiDNJrZ (ORCPT + 99 others); Thu, 14 Apr 2022 05:47:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241935AbiDNJqZ (ORCPT ); Thu, 14 Apr 2022 05:46:25 -0400 X-Greylist: delayed 62 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 14 Apr 2022 02:43:59 PDT Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net [185.136.65.226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7FB2710D6 for ; Thu, 14 Apr 2022 02:43:59 -0700 (PDT) Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 20220414094249f91b9998ce4e847252 for ; Thu, 14 Apr 2022 11:42:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=daniel.starke@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=GdQfGxCXfdHiLKx0XYK3usSDpPXKEHJrcncLZSvBuPI=; b=LEDdZP6wOe+DL8jJmBd7pfREXFUJfv8JgDryDxgCX2ro8nk/qVQSzVB5nS5F0eXtd8cbIj oujm/wynUYBkZ4Gk2xiFEVE9oNqce77yQMdKssOVGiiNWLon4rXocf5iAFuVHLqq4sYmjyeC PSTElhPdNbZeSZZ0n7x0eW2SMkGMc=; From: "D. Starke" To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-kernel@vger.kernel.org, Daniel Starke Subject: [PATCH 14/20] tty: n_gsm: fix missing tty wakeup in convergence layer type 2 Date: Thu, 14 Apr 2022 02:42:19 -0700 Message-Id: <20220414094225.4527-14-daniel.starke@siemens.com> In-Reply-To: <20220414094225.4527-1-daniel.starke@siemens.com> References: <20220414094225.4527-1-daniel.starke@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-314044:519-21489:flowmailer X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Starke gsm_control_modem() informs the virtual tty that more data can be written after receiving a control signal octet via modem status command (MSC). However, gsm_dlci_data() fails to do the same after receiving a control signal octet from the convergence layer type 2 header. Add tty_wakeup() in gsm_dlci_data() for convergence layer type 2 to fix this. Fixes: e1eaea46bb40 ("tty: n_gsm line discipline") Cc: stable@vger.kernel.org Signed-off-by: Daniel Starke --- drivers/tty/n_gsm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 23418ee93156..f3fb66be8513 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -1615,6 +1615,7 @@ static void gsm_dlci_data(struct gsm_dlci *dlci, const u8 *data, int clen) tty = tty_port_tty_get(port); if (tty) { gsm_process_modem(tty, dlci, modem, slen); + tty_wakeup(tty); tty_kref_put(tty); } fallthrough; -- 2.25.1