Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp530507pxb; Fri, 15 Apr 2022 05:32:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMVXRTsiQ3n85OoxmxT4nFzNeGdbJ/puEoBEa/mLZkSGHeITT9KSvLdUwWQcMOCaWvRCys X-Received: by 2002:a17:903:18d:b0:158:785c:5146 with SMTP id z13-20020a170903018d00b00158785c5146mr20756144plg.74.1650025926497; Fri, 15 Apr 2022 05:32:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650025926; cv=none; d=google.com; s=arc-20160816; b=KRkzD1XAIXJD3rc90B84IGD0rVkEOnZu8m3AL2ecJOc7Qh3JxHY1TClaMLDPyB68ct Vbd56YvXCOgNX3zdn8bNRavljbzxzSMPYMH8GSuC13MxMBt6RxF+qQapQa4ePQVzEYZN ybbUSF7sp2zxT5JcVwujLRsmCoNOqePVmKTxwUNsZa4V7FsoRErtb+LJtqv2SP+k/af2 Py3MJOGSABAlfWHo1LjrDmCxAEHhoFG/sgyTdWNirb4zETeW4LPElMIFBYqHxejdDS1k Cu5WBgByXsN6VmCASx/9HgeyKp7QoIkBEEF/rpXENsUzjmiu+qg9Q7cDSEf0bzTPqZkb bs8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=p4J2D9Y15bbl4a0Y5YpwKfGg6ieiA8wDXYDXSztcbAg=; b=BbieQA4ys4h649cACaqE94Xq3fwTiW9n2ymV3rMT8n16o/rdZcRC4ECV/Piz8ZlTYd /GFWPqysavp019Fe39vWsQpzAwJBf4zaA9qR61SKVFLQN2btI9YMepbXA77/wcNPTUBQ pjM1mb6CfSFHE0siBfQ7ywkKQoKGrVQVXqzFQV80R8hXFpyo3Nt7onROfqXYcqU4hToG chKnVlCfBnaQOA2JifeUnZlB8ekzmAWDv/iqE9DJYrIJZv2dlH5ansK8BFDbHflQ0dr2 f5jqlNowLCw0oKxZu2lEN03uKgy3byKJZoobi8uo5W97NZK4nUC69gJ/Tv5tUcPQLBi4 oeSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q15-20020a056a00088f00b005060d434c54si1426120pfj.354.2022.04.15.05.31.54; Fri, 15 Apr 2022 05:32:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235463AbiDNV6R (ORCPT + 99 others); Thu, 14 Apr 2022 17:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbiDNV6Q (ORCPT ); Thu, 14 Apr 2022 17:58:16 -0400 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E958C7DC for ; Thu, 14 Apr 2022 14:55:50 -0700 (PDT) Received: by mail-pl1-f172.google.com with SMTP id v12so5805678plv.4 for ; Thu, 14 Apr 2022 14:55:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=p4J2D9Y15bbl4a0Y5YpwKfGg6ieiA8wDXYDXSztcbAg=; b=gYsFAM0898ddQVRNitWqokN+izJi3j4/S+FQwTfGpsRZdddJ3vsUb9vXofMm7xlaw9 DIGZK38e932I2p9fOcIX9zxrAxunG9KV6C4zw4A5SASpY1kZa8xHYbh6hFkGfGghk8oa aMNsMDpYhVKxgvmbu9fnQ4CXwbyuFFzFHlwnTF0cyYdMb7RUOMtDG8DfDX3nWlzeOmSO CA6r6zGBtzydQXzweba//kb7IzPot4/iav6fback1x0TFzyeM3KWIPP3fiDLKQMsH7+s MlRkXSPzOIb9xX1Vt9Kx6gxg/FCqfV7afIaDbqOEdorT/3byrGdoplnnF8cCVoVUjlqH X8vw== X-Gm-Message-State: AOAM530odbon2mYDYM1MQTEVBx8RBdp6PQ0KW7cO/oqsJXXP/ivewFc5 ylMpXxin2CyVodcxC9dK4rB7Vw== X-Received: by 2002:a17:902:b7c4:b0:158:c493:e0fd with SMTP id v4-20020a170902b7c400b00158c493e0fdmr2748522plz.20.1649973350236; Thu, 14 Apr 2022 14:55:50 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id s24-20020a17090a441800b001ca9b5724a6sm2711383pjg.36.2022.04.14.14.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 14:55:49 -0700 (PDT) From: Kevin Hilman To: Krzysztof Kozlowski , Johnson Wang , cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org, kyungmin.park@samsung.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings In-Reply-To: <39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org> References: <20220408052150.22536-1-johnson.wang@mediatek.com> <20220408052150.22536-2-johnson.wang@mediatek.com> <855d7daa-45d1-d6d8-32bd-51778cf58392@linaro.org> <39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org> Date: Thu, 14 Apr 2022 14:55:49 -0700 Message-ID: <7h8rs7fhy2.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Krzysztof Kozlowski writes: > On 11/04/2022 14:10, Johnson Wang wrote: >>> Also please put it in the "interconnect" directory. >>> >> >> I don't really know about "interconnect". >> However, it looks like a Linux framework about data transfer and "NoC". >> >> While this cci driver is more like a power managment which is >> responsible for adjusting voltages and frequencies. >> In my opinion, "devfreq" should be more suitable. >> >> Please correct me if my understanding is wrong. > > devfreq is a Linux mechanism, not a real device/hardware. We try to put > the bindings in directories/subsystems matching the hardware, therefore > devfreq is not appropriate. > > Whether interconnect - or other subsystem - is appropriate, I am not > sure. To me this looks exactly like bus bandwidth management and you > even use "interconnect" in several places. So interconnect matches. I agree with Krzysztof that "interconnect" is the right place. I'm pretty sure CCI stands for "cache coherent interconnect". At least that's what it means for the Arm IP. The Mediatek IP being described here certainly seems like the same thing. It's just that the only aspects being described (so far) are the DVFS parts. Even so, I still think it belongs in "interconnect" Kevin