Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp558449pxb; Fri, 15 Apr 2022 06:12:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyC3xAlZPrZz4OuwDsQwgNEpBLHN0hR09OUGBdZbLTzHFd006qhEUiJmojIHzs+b4RRefwv X-Received: by 2002:a17:906:4fd4:b0:6e8:9f47:af4a with SMTP id i20-20020a1709064fd400b006e89f47af4amr6167384ejw.680.1650028323504; Fri, 15 Apr 2022 06:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650028323; cv=none; d=google.com; s=arc-20160816; b=pgZCik2a+eVfLCDu9YT2uslgSKbF3WAFKrgLBNuuoIv+oFfI8IxAEcfbW0eNQdhSAf x/2D9f2peRMcLJUYhmlPk6NLpFm62x/Dc+AA2PLULzXiwUTU1D+jGkfRGfRHZlb8FCOy +0kuVgy3ZMulW82B/gIdJD2G7r/4dZK3v80+XY/dil7rIlAbW38ZVZxVjDgsKJwzHC7d nNaWugHAb2OYkLR/A8LvlG65+YUuWJ8yoJ+l1aHPXAC3N5KDIpM4Ne4/NhegIjW09T3z illgVV1RcEAj5b8elFYLYGtLStsvyRU7LZCFFYwqFOh8/+Dg9f3Tk1ItpTQOzhfywkXb 2v3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/HRtMQ3dw3W4AEXwOIIlBJhmt/aYSbzI1lzRClxR+6I=; b=iCTxQQK0JqlQMbkHa2GFS8GVOowZLRe3fjFMOhuv9eoF3EkfJV1QFRdL5wdYsfwDIi uX2N7xy3jpl+9uNCy2DM8Q3amGHm4YjNBKT/07NHLI6iOndw9OAXZV1ivstSLEziSCJO IIIzsTV6cPwMQaF3y052gHyoq3oIO2/fomXGy8A9zdSqAXUTqf49OzFutAUNtVeSigEq 0iyh0qGKKSr4y+L5m7BwFN+B2geB1IBDkN1EvgR4i9HBFCK1WnvVyV/naVW8vkkJyP9m Dpb4uxUe1erodmHnNcN0BuXEY9mOypUE67COlMltdIfkwuCMnKBLdi/OsSI4KWmAGqO9 fVyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=N7OuvHI8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn23-20020a05640222f700b0041d9137ed60si966593edb.225.2022.04.15.06.11.32; Fri, 15 Apr 2022 06:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=N7OuvHI8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241078AbiDNIp7 (ORCPT + 99 others); Thu, 14 Apr 2022 04:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241076AbiDNIpz (ORCPT ); Thu, 14 Apr 2022 04:45:55 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C1FB657A8 for ; Thu, 14 Apr 2022 01:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/HRtMQ3dw3W4AEXwOIIlBJhmt/aYSbzI1lzRClxR+6I=; b=N7OuvHI8LIFE07QlIOsfuEK5Rm tNkvlnKNJc+i5MnPdreiFqUjAnosGMEJPmg9IFW6vVeQd5sQaLFi/NXTTF4EJpUgW2ykQyiSiqFOO qXaVknO24GTUnEGiqWWWwyNYFoc/2HNPlBU5LDu1oeJvFa7C4VPULmR5i2CMknqqXJd1RuKgL0pgT zV15DAXrZuYWlVqkA1vsIK26AkcGn3Km/DEa3/3FWW6cRJ77uqD/m9/Cb0JFJHICff/UavWs/oJtR PXsCGcPO60JVUB1vu8NfpIMBzMny4u2Q1XuDLAtthiAgMqDghO+qI6AttpLwSsbwxUkAIiIxMFiz5 6kwJ0sUw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nev4X-00EyER-QO; Thu, 14 Apr 2022 08:43:25 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6C3AB30080F; Thu, 14 Apr 2022 10:43:25 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 55F1E2B3A873C; Thu, 14 Apr 2022 10:43:25 +0200 (CEST) Date: Thu, 14 Apr 2022 10:43:25 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Miroslav Benes Subject: Re: [PATCH 09/18] objtool: Add stack validation cmdline option Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 04:19:44PM -0700, Josh Poimboeuf wrote: > + if (opts.stackval || opts.orc || opts.uaccess) { > + ret = validate_functions(file); > + if (ret < 0) > + goto out; > + warnings += ret; > > + ret = validate_unwind_hints(file, NULL); > if (ret < 0) > goto out; > warnings += ret; > + > + if (!warnings) { > + ret = validate_reachable_instructions(file); > + if (ret < 0) > + goto out; > + warnings += ret; > + } > } Doesn't SLS also depend on validate_functions() ?