Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Apr 2022 10:43:21 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jani Nikula <jani.nikula@linux.intel.com>
Cc:     "Wang, Zhi A" <zhi.a.wang@intel.com>,
        Christoph Hellwig <hch@lst.de>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>
Subject: Re: refactor the i915 GVT support and move to the modern mdev API v3
Message-ID: <20220414134321.GD2120790@nvidia.com>
References: <20220411141403.86980-1-hch@lst.de>
 <82c13d8e-1cb4-2873-86e9-16fd38e15b27@intel.com>
 <20220413154642.GA28095@lst.de>
 <871qy1geko.fsf@intel.com>
 <5af7726e-920e-603a-bad3-8adb09d2ba89@intel.com>
 <20220413232053.GA2120790@nvidia.com>
 <1c3aaab9-3bd4-95d4-9f9f-4be9e10e6516@intel.com>
 <20220414133427.GB2120790@nvidia.com>
 <87ilrbeqbo.fsf@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ilrbeqbo.fsf@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZBbkgbVaCs4iyNHi9UlR5XRVi4QdUjNfVb0DF05w5365kLEo6YEypxvfMMLH?=
 =?us-ascii?Q?dw1FNCTHdUfdQfkkb+zHbbzddrCg9GqdccjOoeb4N36buanXinzKuDpzFkds?=
 =?us-ascii?Q?c9aspx/srsH3Z0EN/dQpaUx9xxGDNU2B8N5zLcdp+chcph0V9CAK2V8ld+Ta?=
 =?us-ascii?Q?wuqgEtUG9BILCNVDImcj7e1SbyFa3q7IFTmntCFB/oCn1psFnU3LLOg2MvGH?=
 =?us-ascii?Q?/hQTiUyurb5pomzDdMsUjES4cbJJx3ZUjnU/I5nPOlNOoa0Dq/2HnQhac6Gi?=
 =?us-ascii?Q?rKhyUpL28nvfeenk/EtQnmVdgEoZvfGS7iEXZcbl2vepdkF94CpGH3lA1LWR?=
 =?us-ascii?Q?v7J9r3OKTMUu3M4AD+B0a8ofemi/WOlIJ/3UsEi+ndbtdn+g3aX0nBllGqaY?=
 =?us-ascii?Q?hc96T8GCG00LR3RXhVxt+XQCH5ybvK6m1GX10ejJGmdXBzFSwzQXnjr3tAtD?=
 =?us-ascii?Q?eXA6pJrop4t4mjAD9hoEzZbb3D+J+YPbbUwjAvv7nldGCL05/yreJkUpEJNw?=
 =?us-ascii?Q?Ap0RhyGD8a122HcWTfbAFnkpDKTJuocBGPdS3kphYubPpr06vIjaL6QgMZcU?=
 =?us-ascii?Q?dPllPr3wyj0i5fMN601XHTx3zp1tiaiWvOiA1m2dMBPUQdVyROx37sj786uI?=
 =?us-ascii?Q?Ub7+GLCM1ZFTEuddSs+ErAWLKXe3qHrTxdXhudqbuedfVWaYFj/clNEDRNJU?=
 =?us-ascii?Q?P81zlWrE+5UA0BrXTmrFknfQ5ynGrPkEOuOu8J9uckDbZ8kWaiXQmMwEbNiF?=
 =?us-ascii?Q?wP2pIbM32m7wC+OQx5W0M0/K4xTIosNwc9lGzB777XCSa5YMosP/svk7HRSA?=
 =?us-ascii?Q?W1Qrakh2fIYdAtltbLUwyFGbKuCuO12/yczIgzxPnTjj0L00LuvwkWtPBKLl?=
 =?us-ascii?Q?uq6d2wy39Xr8jCfCqERLONyWXS49on6kWXnvXHOMZ7m9cgrJRolGH6HNN8i+?=
 =?us-ascii?Q?3NbD2zmG20ni/SLvrAPuSU+509uaTxBewWA8mP2uoYvF8BukEM6rur5Ft7qT?=
 =?us-ascii?Q?+o4W67X5HN66beKUl0zsz+g2g8OMYTh5OyktUN0svT3l9pONw80iY81na052?=
 =?us-ascii?Q?5/dNaHHeZ0JnTnl7YZbRw6t6K/Wh5o3fef0dpenFVj83+rlMxuTrdfiYW2+8?=
 =?us-ascii?Q?TZUdQDnvqj0HBHuajepP7WpkET41kfpghPL+EJRsLNJkuHB9ktTo8cgP/4zE?=
 =?us-ascii?Q?hpYaXetuZiMr5zf843PtUU2OV4VAQGoCaDBBXdW3i8Xkh7y2d2O4GSs3Y9Z6?=
 =?us-ascii?Q?ZYMCnSbeS3dTYwTFgA+FfrQ7yjHqF8VH/BFOCNhrgxFTIZ1NTJsJ3ViY5QuY?=
 =?us-ascii?Q?7odpZWWZRiX17RLfEy6vr27PvCXDHW78/3F2+gGYd26tcyj6mkWsi5IPGhuw?=
 =?us-ascii?Q?Ivpazo7M3/XWrBu8x4RPRN2U6/oV1dTnu9N9XH+YLv2K89mGmdpmQnMQKwLs?=
 =?us-ascii?Q?WnTO8jkIO1WM4VzGuPOKKfc2st85FEvEXV+EC4U80AEF/RSpkxOew0vGw3+k?=
 =?us-ascii?Q?0J7asNeR8/6d2ei/4u57je+9Z34qOgPiGBqFNpUR6gb9MWTfoCL43ynrFa1c?=
 =?us-ascii?Q?75QirQD+tKXn1WIIqWzlw0cCUykg6p5MHMCPmbFidGS14Xf/rvxsvS8jQfDz?=
 =?us-ascii?Q?550l881sEDR10KBOJRSB1klO1MspJ6XG7UIMojQrv6yg0cWeEOUeTsGLGjYy?=
 =?us-ascii?Q?0eja4382zwlhHUQj3m1v3YKNg53dsHkrpCc2UikmuvWlR9aDOPw3A5Kk4XjT?=
 =?us-ascii?Q?QNm3bKr0Bg=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfd9d733-49e9-465f-a9f9-08da1e1cbe30
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 13:43:22.6530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I0zEvvzm6w6OiDKoQ1ftMgAYYpKjLgkrCK+ziD8HwZSgMttYlxK4VoYiFoUQaVYP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3050
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 14, 2022 at 04:40:11PM +0300, Jani Nikula wrote:

> >> >> git clone https://github.com/intel/gvt-linux -b for-christoph
> >> > 
> >> > There are alot of extra commits on there - is it possible to base this
> >> > straight on rc1 not on some kind of existing DRM tree?
> >> > 
> >> > Why did you choose drm/i915/fbc: Call intel_fbc_activate() directly
> >> > from frontbuffer flush  as a base?
> >> > 
> >> > Jason
> >> > 
> >> 
> >> Hi Jason:
> >> 
> >> I updated the branch. You can check if those are what you are expecting. :)
> >
> > This is better, except for the first commit:
> >
> >  [DON'T PULL] drm/i915/dmc: split out dmc registers to a separate file
> >  THIS PATCH WILL GO THROUGH DRM-INTEL-NEXT TO UPSTREAM
> >
> >  Clean up the massive i915_reg.h a bit with this isolated set of
> >  registers.
> >
> >  v2: Remove stale comment (Lucas)
> >
> > Clean the commit message and send that as a proper PR to
> > drm-intel-next, then everything else is OK.
> 
> It's already in drm-intel-next, I guess the problem is basing the branch
> on something that doesn't have it. I'd probably just base everything
> cleanly on -rc1, and whoever does the merge between the two will need to
> account for the missing include in the result. It's just adding one line
> in the right place.

That makes sense to me, especially if you can do the merge fixup
internally in DRM.

So drop the '[DONT PULL]' commit and send a PR to the next DRM tree -
when that is confirmed send the same PR to vfio,

Thanks,
Jason