Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9225e49d-816d-a7c2-c1a3-b204488417f9@amd.com>
Date:   Thu, 14 Apr 2022 10:31:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: linux-next: build failure after merge of the amdgpu tree
Content-Language: en-US
To:     Alex Deucher <alexdeucher@gmail.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        "Zhang, Dingchen (David)" <Dingchen.Zhang@amd.com>,
        "Kotarac, Pavle" <Pavle.Kotarac@amd.com>,
        "Chung, ChiaHsuan (Tom)" <ChiaHsuan.Chung@amd.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>
References: <BN9PR12MB5145ECB75120FF9AC1AA4CFB8DEC9@BN9PR12MB5145.namprd12.prod.outlook.com>
 <CADnq5_OjPwzYtW99a-L6OrHz-oH0MqSNi+Me4T-x1vY8zEXLcQ@mail.gmail.com>
 <BN9PR12MB5145D81F9978B656E9BB67C78DEF9@BN9PR12MB5145.namprd12.prod.outlook.com>
 <a1203367-834f-a4d0-3478-9e16787a3b8b@amd.com>
 <CADnq5_MTQSZs7R+DTQWRyGqqQcff6mCb43s_7jtE8w00k+YxQg@mail.gmail.com>
From:   Rodrigo Siqueira Jordao <rjordrigo@amd.com>
In-Reply-To: <CADnq5_MTQSZs7R+DTQWRyGqqQcff6mCb43s_7jtE8w00k+YxQg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cElnZkNwZlExOTAwVlRKbCtUanBlYlR1ZXJZMnVyNXFwY05iSlJnWmhXNDhi?=
 =?utf-8?B?NGFhdzJ3OHJ4eWNYWEFQd2N2eVdqR3BubTJub0VUbWRIRjcwMzlNclR6TTVp?=
 =?utf-8?B?VitFMWpLeEo4ZEsrTU1DUEcwY1h5NWxxYW02RHl5bUZ0aGtsamx4VGoxaTVw?=
 =?utf-8?B?Vm9xWk1PZU9qY255R1A5emF4OW94OERvSXN1bklpdjdJV1R0UG9LUjZuNTV5?=
 =?utf-8?B?aXpPSnIxVjl0L25yME50dUcxMWppeFpyK2grQjROSFROcFRMcjdXY1BGRWxh?=
 =?utf-8?B?T2kxcGRrQ0hNZUQ0d01GNndiSllOdnlBb25qWHNZUHI2b2lIRmg2QWkxUTUz?=
 =?utf-8?B?YS9UY0gxd2tnZmM3RHZ2K1VhaGNTTU9ETDNCVzVyY3lYU3kzdVRJZDk4SU4w?=
 =?utf-8?B?UXhOMlJUMmluWmZRQmdJQmQ5NDdRaXNrM2hyTGFzb240YmtoWXdzNTN4eHhP?=
 =?utf-8?B?Z0UxUnRpRjhLeitocUFFN1lkVUlJcHQyVjdJRzByT04zNXRIM3BSd1h1a2Ja?=
 =?utf-8?B?NzJwT2J4R0dXS3VKOWxPOWVLa05vaTlHMDNGWTZxRkhPZmg4Vm51U01tcWdC?=
 =?utf-8?B?bmlkY2VWTmVxRnJJc0diQ2NzTkhCNEg3SUdxVThjT1NIRkZtYzdvMmQ5RkEv?=
 =?utf-8?B?eGl4SzhRUVYvUWc5N1FwbDlHUWZXRkpRNStRcVl1d2krSGlWb3BKZ1UvMkx6?=
 =?utf-8?B?bmxXa29hdStlZ2VUWTZqSWFFVkJNNGdsT05pSUlpbGlyamZneWRXYkdiNmJC?=
 =?utf-8?B?ZlVXOEFpTXRxRTJRanZmU2FkRGJITmJTUEVpb2dSNFg5M0ZNMWVWcU9nMlpt?=
 =?utf-8?B?ZGwxTm9iTWM3YnFTcnlTNnZrVk5VL0RxclZYaU1oc2JOem9VS0xyekozN1hL?=
 =?utf-8?B?dkk0bDdxcDhMS2hKY1k4U0R1NTJoTC90WURZd09hVTBHQnJ0c1BSdGM1b0du?=
 =?utf-8?B?WjNaUFN5SGlTZUpKNm1hS29MaHMrL3plYU1KYy9BZVI0MTFpNDF4TUMycW0v?=
 =?utf-8?B?SGNReThsYjRudVNxS28yRzAybS9HNk5uOWFpREVXMDlXNFlPVzN4UUtwOXQ5?=
 =?utf-8?B?Q3hxdzJkekZtL294aEhBbW5nN1RCR1FOT2ZRVDB0OUFQa3FsaGgrZG1OcW14?=
 =?utf-8?B?RUVSd1ppbDNaQS9YaWg3YitUK2J2Q3NpeGxpWGpyUGRJb0tBMWFic1crVEVu?=
 =?utf-8?B?Qy9PMTJzSmwrQnVZUWV1cVloczRBZ0JSdTgxMnE0WmFLU3JVbkdKWHN4eHNI?=
 =?utf-8?B?a1ZYNTA3WkFqenNVMklWQUVVY2Y4cU5FTE9zYVVNdVhVem0wQ1Nhdk1oUWY2?=
 =?utf-8?B?N1lXNmowdmdSV1VZeC9lQUtEQU5hR2ZaWVlSQkFaT0RjMXJPY2R6TnZLYXBz?=
 =?utf-8?B?MzU5elNxNlRaT1NTRFVHelRGN1lMS2hZc2tYb0ZQSkRvM0Z0N0cyV3V0MDhO?=
 =?utf-8?B?L0MrOHdFSi9sMWJhTGpmOVNBUy90WElJd2NXR3l2VWpRS0lKWnNuQkxESEFt?=
 =?utf-8?B?Tjc5SStpaVpKaktUc2xLcThjVXdtRERXbXJUUTFzY3haSFBFNmpwdC9CanBv?=
 =?utf-8?B?V2VFYzNrZlJicUM5U1Z6aWZ5ZDRFdFV5ZHJWL2E0S3NldHFKYVFGODBGUjVu?=
 =?utf-8?B?TVAxRmFWa216Z21TOUNEWEZMMlU2UWI4Zzh4cmN6NkZycGM1OGxIY3M2LzZU?=
 =?utf-8?B?TDJObGRSb1lOQXVpN2Q1dEtUUm1lbEFtTGFwWjJ0eEFtblZlOTFnNUpvRU9K?=
 =?utf-8?B?OHRTRVhWZjB3Vlg5ODdncnBYNk82TWsycVRsVzZIQ1Q0MEtrL1NKRm0xLzV2?=
 =?utf-8?B?MWVJUU1UeUlLZG9BZUtEVUxhb3VPRFpmSEJXTlp3dDBUMXRCV3dqc2hNN2Z2?=
 =?utf-8?B?Y3krZWV0b1kyd0pOcks0UmJTdDZBMWpwUDROMXFtMGFOd1d5bGFMbVl0aW5P?=
 =?utf-8?B?bjJGU1JEbEZYVTZVK2dZUXE1ajNMMnQwR25XcjVHQjhTK0x4RndlMVdaRDhL?=
 =?utf-8?B?ZngzR1BVQWlIc2hEN1hpS0x6aEVIVXR2RGFlQ3JvL2hDaFhwTzJ0eldlbnR5?=
 =?utf-8?B?TE1jOTRNWmlzUjZTblBYTmgyejRXTG0wd0s3L2Ura1VMK0U0aDJKNXB2dGFn?=
 =?utf-8?B?Znl0V0lKU05vakZCK2JJNWVCNjhCMFVXdm45YTZUa2NCTElCd2sxamNTQVFr?=
 =?utf-8?B?aFZKNjROcFdQZ2Z3STgvMmduNWVnS2tqQzgyRGtxS3RBaEIvcHc3SVN1YXJJ?=
 =?utf-8?B?Nm0wb083UFBLV0ZsdUoxdG5GaVBUa3dXQW9EOU5VOVd0RWpScWY3alVMaGIr?=
 =?utf-8?B?UHErQVhES1ZkMDdiSDBjaEJRYUZGbHNEZjZqUVZYK1dzTVlwUkRvdz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b690a7b5-676d-4bf0-6ed6-08da1e23794c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 14:31:33.5962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aJCR0ryAchzSqt8/L9zXwiXHymL+KYWvc717KSYSZgXOJ7/VnKipmbvb6OkzOi5ce/UOmLi/ZfCv+VbUUx0DhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5284
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-04-14 10:27, Alex Deucher wrote:
> On Thu, Apr 14, 2022 at 10:23 AM Rodrigo Siqueira Jordao
> <rjordrigo@amd.com> wrote:
>>
>> Hi Alex,
>>
>> Do we need to apply David's patch [1] to drm-misc-next? If so, I can
>> merge it there. Also, I noticed that drm-misc-next changed the dp header
>> path; in that way, I had to change the original patch a little bit.
>>
>> 1. https://patchwork.freedesktop.org/patch/480331/?series=102035&rev=1>>>
> 
> Ideally it would have gone through drm-misc, but since we are the only
> ones using it at this point, I think it's ok to take through my tree.
> I'll make a note about the path change when I send the PR.

Ok, Next time I'll try to push this type of patch directly to drm-misc-next.

Thanks
Siqueira

> Alex
> 
>> Best Regards,
>> Siqueira
>>
>> On 2022-04-14 10:08, Zhang, Dingchen (David) wrote:
>>> [AMD Official Use Only]
>>>
>>>
>>> Thanks for clarifying, Alex.
>>> ------------------------------------------------------------------------
>>> *From:* Alex Deucher <alexdeucher@gmail.com>
>>> *Sent:* Wednesday, April 13, 2022 10:18 AM
>>> *To:* Zhang, Dingchen (David) <Dingchen.Zhang@amd.com>
>>> *Cc:* Stephen Rothwell <sfr@canb.auug.org.au>; Kotarac, Pavle
>>> <Pavle.Kotarac@amd.com>; Chung, ChiaHsuan (Tom)
>>> <ChiaHsuan.Chung@amd.com>; Linux Kernel Mailing List
>>> <linux-kernel@vger.kernel.org>; Linux Next Mailing List
>>> <linux-next@vger.kernel.org>
>>> *Subject:* Re: linux-next: build failure after merge of the amdgpu tree
>>> The patch should be there now.
>>>
>>> Alex
>>>
>>> On Wed, Apr 13, 2022 at 10:09 AM Zhang, Dingchen (David)
>>> <Dingchen.Zhang@amd.com> wrote:
>>>>
>>>> [AMD Official Use Only]
>>>>
>>>>
>>>> hi Stephen,
>>>>
>>>> Could you please check if below patch (which has been upstreamed) is in your Linux code base?
>>>>
>>>> ~~~~
>>>> eb2bb029bacf David Zhang         12 days ago    drm: add PSR2 support and capability definition as per eDP 1.5
>>>> ~~~~~
>>>>
>>>> Thanks
>>>> David
>>>> ________________________________ From: Stephen Rothwell
>>>> Sent: Tuesday, April 12, 2022 10:32 PM
>>>> To: Alex Deucher
>>>> Cc: Zhang, Dingchen (David); Kotarac, Pavle; Chung, ChiaHsuan (Tom); Linux Kernel Mailing List; Linux Next Mailing List
>>>> Subject: linux-next: build failure after merge of the amdgpu tree
>>>>
>>>> Hi all,
>>>>
>>>> After merging the amdgpu tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c: In function 'is_psr_su_specific_panel':
>>>> drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:798:61: error: 'DP_PSR2_WITH_Y_COORD_ET_SUPPORTED' undeclared (first use in this function); did you mean 'DP_PSR2_WITH_Y_COORD_IS_SUPPORTED'?
>>>>    798 |                 if (link->dpcd_caps.psr_info.psr_version >= DP_PSR2_WITH_Y_COORD_ET_SUPPORTED)
>>>>        |                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>        |                                                             DP_PSR2_WITH_Y_COORD_IS_SUPPORTED
>>>> drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:798:61: note: each undeclared identifier is reported only once for each function it appears in
>>>>
>>>> Caused by commit
>>>>
>>>>    901029aa0017 ("drm/amd/display: implement shared PSR-SU sink validation helper")
>>>>
>>>> Please start including an x86_64 allmodconfig build in your local testing.
>>>>
>>>> I have used the amdgpu tree from next-20220412 for today.
>>>>
>>>> --
>>>> Cheers,
>>>> Stephen Rothwell
>>