Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg'
To:     Haowen Bai <baihaowen@meizu.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>
CC:     <linux-renesas-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1649837953-10984-1-git-send-email-baihaowen@meizu.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <2ed01eb3-ff46-425c-75dc-81729a5c30a8@omp.ru>
Date:   Thu, 14 Apr 2022 12:29:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <1649837953-10984-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello!

On 4/13/22 11:19 AM, Haowen Bai wrote:

> Fix this issue by freeing the cpg when exiting the function in the
> error/normal path.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: free both cpg&clks.
> 
>  drivers/clk/renesas/clk-r8a73a4.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

   2 patches with the same name won't do -- you always need to include the chip name
part of the file name in the subject (in this case r8a73a4).

MBR, Sergey