Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Apr 2022 08:49:54 -0700
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH 14/18] objtool: Add toolchain hacks cmdline option
Message-ID: <20220414154954.tjv5peczw3tadd27@treble>
References: <cover.1649891421.git.jpoimboe@redhat.com>
 <e04ec8f01fcb537675d6bd94ef65103a0a749318.1649891421.git.jpoimboe@redhat.com>
 <YlfWynPt6MGR5BZP@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YlfWynPt6MGR5BZP@hirez.programming.kicks-ass.net>
Precedence: bulk

On Thu, Apr 14, 2022 at 10:09:46AM +0200, Peter Zijlstra wrote:
> On Wed, Apr 13, 2022 at 04:19:49PM -0700, Josh Poimboeuf wrote:
> > Objtool secretly does a few awful hacks to overcome toolchain
> > limitations.  Make those hacks explicit (and optional for other arches)
> > by associating them with a new '--hacks' cmdline option and
> > corresponding CONFIG_HAVE_TOOLCHAIN_HACKS.
> 
> Should we either clarify the specific hacks done, or split this in two
> options?
> 
>   --hack-jump_label
>   --hack-noinstr

Yeah, maybe we should split them out somehow.

-- 
Josh