Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Apr 2022 09:23:00 +0200
From:   =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Herve Codina <herve.codina@bootlin.com>,
        =?UTF-8?B?TWlxdcOobA==?= Raynal <miquel.raynal@bootlin.com>,
        Milan Stevanovic <milan.stevanovic@se.com>,
        Jimmy Lalande <jimmy.lalande@se.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 02/12] net: dsa: add Renesas RZ/N1 switch tag
 driver
Message-ID: <20220415092300.009ef819@fixe.home>
In-Reply-To: <YlhKkriHziPsWBCV@shell.armlinux.org.uk>
References: <20220414122250.158113-1-clement.leger@bootlin.com>
        <20220414122250.158113-3-clement.leger@bootlin.com>
        <20220414142242.vsvv3vxexc7i3ukm@skbuf>
        <20220414163546.3f6c5157@fixe.home>
        <20220414151146.a2fncklswo6utiyd@skbuf>
        <20220414181815.5037651e@fixe.home>
        <YlhKkriHziPsWBCV@shell.armlinux.org.uk>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Le Thu, 14 Apr 2022 17:23:46 +0100,
"Russell King (Oracle)" <linux@armlinux.org.uk> a =C3=A9crit :

> On Thu, Apr 14, 2022 at 06:18:15PM +0200, Cl=C3=A9ment L=C3=A9ger wrote:
> > Le Thu, 14 Apr 2022 18:11:46 +0300,
> > Vladimir Oltean <olteanv@gmail.com> a =C3=A9crit :
> >  =20
> > > On Thu, Apr 14, 2022 at 04:35:46PM +0200, Cl=C3=A9ment L=C3=A9ger wro=
te: =20
> > > > > Please keep variable declarations sorted in decreasing order of l=
ine
> > > > > length (applies throughout the patch series, I won't repeat this =
comment).   =20
> > > >=20
> > > > Acked, both PCS and DSA driver are ok with that rule. Missed that o=
ne
> > > > though.   =20
> > >=20
> > > Are you sure? Because a5psw_port_stp_state_set() says otherwise. =20
> >=20
> > Weeeeell, ok let's say I missed these two. Would be useful to have such
> > checks in checkpatch.pl. =20
>=20
> Note that it's a local networking coding-style issue, rather than being
> kernel-wide.
>=20

Hi Russell, Yes I was aware of that but if I remember correctly, there
are some netowrking checks like multi line comments without an empty
first line in checkpatch. Anyway, I'll make sure to check that mroe
carefully next time.

--=20
Cl=C3=A9ment L=C3=A9ger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com