Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Haowen Bai <baihaowen@meizu.com>
Cc:     Haowen Bai <baihaowen@meizu.com>, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp()
Date:   Fri, 15 Apr 2022 08:10:35 +0200
Message-ID: <4370787.8F6SAcFxjW@leap>
In-Reply-To: <16182197.geO5KgaWL5@leap>
References: <20220415053116.GN3293@kadam> <1650001836-25956-1-git-send-email-baihaowen@meizu.com> <16182197.geO5KgaWL5@leap>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="ISO-8859-1"
Precedence: bulk

On venerd=EC 15 aprile 2022 08:06:17 CEST Fabio M. De Francesco wrote:
> On venerd=EC 15 aprile 2022 07:50:36 CEST Haowen Bai wrote:
> > The rtllib_rx_assoc_resp() function has a signedness bug because it's
> > a declared as a u16 but it return -ENOMEM.  When you look at it more
> > closely it returns a mix of error codes including 0xcafe, -ENOMEM, and
> > a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG.  This is a mess.
> >=20
> > Clean it up to just return standard kernel error codes.  We can print
> > out the a->status before returning a regular error code.  The printks
> > in the caller need to be adjusted as well.
>=20
> This commit message suggested by Dan Carpenter is much better. The=20
previous=20
> one made me think that you were doing several different logical changes.
>=20
> >
> > [snip]
> > =20
> >  static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct=20
> sk_buff *skb)
> >  {
> > -	u16 errcode;
> > +	int errcode;
> >  	u8 *challenge;
> >  	int chlen =3D 0;
> >  	bool bSupportNmode =3D true, bHalfSupportNmode =3D false;
> > @@ -2292,8 +2292,8 @@ static void rtllib_rx_auth_resp(struct=20
> rtllib_device *ieee, struct sk_buff *skb)
> >  	if (errcode) {
> >  		ieee->softmac_stats.rx_auth_rs_err++;
> >  		netdev_info(ieee->dev,
> > -			    "Authentication response status code=20
> 0x%x",
> > -			    errcode);
> > +			    "Authentication response status code %d",
> > +			    le16_to_cpu(errcode));
>=20
> This is something that I'm still missing. Why do we need that call to=20
> le16_to_cpu on "errcode"?
>=20
> "errcode" is returned by auth_parse()? I see that this function already=20
> changes the endianness of the returned value.

Sorry, I missed that you also changed auth_code().

=46abio

>=20
> Thanks,
>=20
> Fabio
>=20
>=20
> >  		rtllib_associate_abort(ieee);
> >  		return;
> >  	}
> > --=20
> > 2.7.4
> >=20
> >=20
> >=20
>=20
>=20
>=20
>=20
>=20