Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <87985be4-8cb0-2292-d799-5a91fb32acda@redhat.com>
Date:   Fri, 15 Apr 2022 11:00:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id
Content-Language: en-US
To:     Eli Cohen <elic@nvidia.com>, mst@redhat.com
Cc:     virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, si-wei.liu@oracle.com
References: <20220411122942.225717-1-elic@nvidia.com>
 <20220411122942.225717-3-elic@nvidia.com>
From:   Jason Wang <jasowang@redhat.com>
In-Reply-To: <20220411122942.225717-3-elic@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/4/11 20:29, Eli Cohen 写道:
> Add structure to define the payload of control VQ messages carrying the
> configured vlan ID. It will be used in subsequent patches of this
> series.
>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
> ---
>   include/uapi/linux/virtio_net.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index 3f55a4215f11..b94a405fa8d2 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -270,6 +270,9 @@ struct virtio_net_ctrl_mac {
>   #define VIRTIO_NET_CTRL_VLAN       2
>    #define VIRTIO_NET_CTRL_VLAN_ADD             0
>    #define VIRTIO_NET_CTRL_VLAN_DEL             1
> +struct virtio_net_ctrl_vlan {
> +	__virtio16 id;
> +};


It looks to me there's no need to bother uAPI and we can simply use 
__virtio16 in patch 3?

Thanks


>   
>   /*
>    * Control link announce acknowledgement