Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 15 Apr 2022 09:45:47 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Krzysztof Kozlowski <krzk@kernel.org>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: [krzk-github:n/qcom-ufs-opp-v2 14/16] drivers/opp/core.c:1215
 dev_pm_opp_set_rate() error: uninitialized symbol 'ret'.
Message-ID: <202204150900.qnJMf3Gu-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4aUHavOzFX7lMpvEPotixyrLvvLssiQMFpGb9/V8qjlWWOJGQXxa+Ou3H3t4?=
 =?us-ascii?Q?mdEeAEpchIHbjn2UQYLTqRMrXJB8CnAOmXf/zMBXT5U9ugqB+nrGQsvN8YWQ?=
 =?us-ascii?Q?nih2zxO9d2yTzcQ/M/U/1dzHmBH1hr8ycDeUD/RTRTRC+uGgtxa8UIA/eLa+?=
 =?us-ascii?Q?wSE7gzzWqz4ovp1yXe8PLQKSP/JHtcVCMA8ljLqIAnzlmJzhx2k/5aMNZf/R?=
 =?us-ascii?Q?XIJHmM96umoDmA86ikixyYxaG3GLZQmkiBWRX/7PTSK9BWp5MGpRLFV2pKWx?=
 =?us-ascii?Q?bunZLjWQeIe99+ME/obeHVIj1oMjdUX7MC4NJFCM+tYI0Zxe0/Mdsq5zwBWB?=
 =?us-ascii?Q?i8eXtbUW0yesJhW/RR60JJjOMxQCvai3XRME5fJYTW3NzBAIZUtgSh/4oaij?=
 =?us-ascii?Q?wsjZhS72opooBIVzijQSuCcMnHxd551BWI5JmIQ3RZ9Uek7E7v9IRWSopWsk?=
 =?us-ascii?Q?J+BIZ3/q5fgSTUhYps+LGGGBib4BaE3XkZx2rtBXHQXzMLYSPz3Il6ElMOC7?=
 =?us-ascii?Q?MjJmyVsOdaJN6f+K7kBqUCXRqQN7Swka9AyLcyfy6HBCbLw9MEsYAacRxp4X?=
 =?us-ascii?Q?Ca3tvso9AOTKNbgi9Lqk/FTDoi/CDrgnKkZ7Fl9EYnBUTeVfEFtGlpScd74W?=
 =?us-ascii?Q?tL+3Ucazj6HUZxSjfABjWF+7CvgfLjQgZ7kC00i9JVlWHjwgr4EC1diFP00A?=
 =?us-ascii?Q?qRvVqYn9veIbcns5OjoxJFD9PabsjbqSyd7XHTwQWM7B8udTO5reaGuCEJZT?=
 =?us-ascii?Q?spfdGE+ZetO6D125lhuyH9sl2A0pJv1Z8DtslBobmFqKw0iR9ADYmclPtHMP?=
 =?us-ascii?Q?PTBi0FOdmtpaEMt6vDk0dIIWXklH+8iII8Y6+bSiSj20xM9Plsu/IWhXEb1t?=
 =?us-ascii?Q?jkgsEaS0zhMOwCt45OnYt8KFm/EFKfUjbAAuEv5pa0pLd9QyF72PB+3TyFPV?=
 =?us-ascii?Q?L5f2vZ+3Hr+sBwRIF0W+R+G/Aib7q3d89NjsWnieCDQiGAOjTrYBcxF0HegS?=
 =?us-ascii?Q?qw3PPjvJcVyhAfxEdH/L/po7BIHux3LL5Q42xDLTeutG+qBG/i7D5qMezq2Z?=
 =?us-ascii?Q?77sHcWjWe5NrVrqASfprJ9zGz8g2H4xOuZhmrPRFdoxm0HGb4G8/nPkzKonL?=
 =?us-ascii?Q?8Oo6PtbPOaS4LDzPHAlSY2MYW56PDVIIrNP/nBLGq8POsPSWfe0D0jMoO4Wq?=
 =?us-ascii?Q?x2cDwZmQrJAWUmyrZU7Fu8HHk4UgDnzO/6v8czVXW6S3TxXTzQa95FkwkKdw?=
 =?us-ascii?Q?rbGSEIS0StasSwnD2kZkJNHX1m0cbm4VRhDyo74Cd1gN+MgW+ehAKhRL1Xmc?=
 =?us-ascii?Q?YtQd9UVxl9Lyvz/3cPOdhWllYwhTT/5WgNEmVqCtEAVt/Azm7WuWnKD4qyIF?=
 =?us-ascii?Q?ZWB3ei6h4Xg+ekMwDHyov2WISP4BSkjmSv1BnMqMZfOYJm39S0TuIanP1Uga?=
 =?us-ascii?Q?pxX2WocL85q66Nc3bDdnn/KmdQ4/H8r3nVFeyXVp981yDkRXJECLbSaX4r3U?=
 =?us-ascii?Q?8tVLpcd/5EbOKTGqMc6g5KN+GPqhYZwgdR7uvKPgl21rTCYERHrVx+IgLE0x?=
 =?us-ascii?Q?/Rsh7fUBmnQTaDcOFhxktAU4wIBXSD97Gd4KNuNoqPUfFz2j/jdhPpQb/9bF?=
 =?us-ascii?Q?LUf3aUU4Vg8nrM7ILatLvJSmilcYSY830r9CUNlzPEtI410EfDGsU7NmfJBy?=
 =?us-ascii?Q?GprE/89KKm4yQrIU+TkeH2XcGthnCJeVlnBv0Axf7GAzgk3084KhhAUPju2L?=
 =?us-ascii?Q?SVtnbYcaBaTzVCrRBaQky3yQOIq2olk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a2596fa-b859-4b12-6da7-08da1eaba0e3
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 06:46:11.5409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: otg2hZB+bBdeQfUiAFvU0nuz2FPoOjPT4NUZJXJcxs1825EWEg/C04D4leE3Zz6Am9eHtz7yqSe7GOQ6yNt3ZVmKOSG7xyLjSSuZFNxTSl0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2500
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-15_01:2022-04-14,2022-04-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 phishscore=0 mlxscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204150039
X-Proofpoint-ORIG-GUID: LEBVxpN6c7qH7m-rN5vdP7QGbnpZsWmm
X-Proofpoint-GUID: LEBVxpN6c7qH7m-rN5vdP7QGbnpZsWmm
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://github.com/krzk/linux n/qcom-ufs-opp-v2
head:   bf7d30c9329c87f06dff42b303a9bcfd2e1f54eb
commit: be46c855d54f763bfb95424e5204fe7496e2ee5f [14/16] PM: opp: allow control of multiple clocks
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220415/202204150900.qnJMf3Gu-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/opp/core.c:1215 dev_pm_opp_set_rate() error: uninitialized symbol 'ret'.

Old smatch warnings:
drivers/opp/core.c:1197 dev_pm_opp_set_rate() warn: passing a valid pointer to 'PTR_ERR'
drivers/opp/core.c:2813 _opp_set_availability() warn: passing a valid pointer to 'PTR_ERR'
drivers/opp/core.c:2884 dev_pm_opp_adjust_voltage() warn: passing a valid pointer to 'PTR_ERR'

vim +/ret +1215 drivers/opp/core.c

386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1155  int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1156  {
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1157  	struct opp_table *opp_table;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1158  	unsigned long freq = 0, temp_freq;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1159  	struct dev_pm_opp *opp = NULL;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1160  	int ret;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1161  
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1162  	opp_table = _find_opp_table(dev);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1163  	if (IS_ERR(opp_table)) {
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1164  		dev_err(dev, "%s: device's opp table doesn't exist\n", __func__);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1165  		return PTR_ERR(opp_table);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1166  	}
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1167  
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1168  	if (target_freq) {
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1169  		/*
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1170  		 * For IO devices which require an OPP on some platforms/SoCs
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1171  		 * while just needing to scale the clock on some others
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1172  		 * we look for empty OPP tables with just a clock handle and
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1173  		 * scale only the clk. This makes dev_pm_opp_set_rate()
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1174  		 * equivalent to a clk_set_rate()
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1175  		 */
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1176  		if (!_get_opp_count(opp_table)) {
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1177  			if (opp_table->clks)
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1178  				ret = _generic_set_opp_clk_only(dev,
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1179  								opp_table->clks[0],
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1180  								target_freq);

"ret" not initialized on else path.

386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1181  			goto put_opp_table;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1182  		}
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1183  
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1184  		if (opp_table->clks)
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1185  			freq = clk_round_rate(opp_table->clks[0], target_freq);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1186  		if ((long)freq <= 0)
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1187  			freq = target_freq;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1188  
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1189  		/*
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1190  		 * The clock driver may support finer resolution of the
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1191  		 * frequencies than the OPP table, don't update the frequency we
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1192  		 * pass to clk_set_rate() here.
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1193  		 */
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1194  		temp_freq = freq;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1195  		opp = _find_freq_ceil(opp_table, &temp_freq);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1196  		if (IS_ERR(opp)) {
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1197  			ret = PTR_ERR(opp);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1198  			dev_err(dev, "%s: failed to find OPP for freq %lu (%d)\n",
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1199  				__func__, freq, ret);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1200  			goto put_opp_table;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1201  		}
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1202  		/*
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1203  		 * opp->rates are used for scaling clocks, so be sure accurate
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1204  		 * 'freq' is used, instead what was defined via e.g. Devicetree.
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1205  		 */
be46c855d54f76 drivers/opp/core.c            Krzysztof Kozlowski 2022-04-05  1206  		opp->rates[0] = freq;
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1207  	}
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1208  
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1209  	ret = _set_opp(dev, opp_table, opp, freq);
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1210  
386ba854d9f316 drivers/opp/core.c            Viresh Kumar        2021-01-21  1211  	if (target_freq)
8a31d9d94297b1 drivers/base/power/opp/core.c Viresh Kumar        2017-01-23  1212  		dev_pm_opp_put(opp);
052c6f19141dd1 drivers/base/power/opp/core.c Viresh Kumar        2017-01-23  1213  put_opp_table:
5b650b388844f2 drivers/base/power/opp/core.c Viresh Kumar        2017-01-23  1214  	dev_pm_opp_put_opp_table(opp_table);
052c6f19141dd1 drivers/base/power/opp/core.c Viresh Kumar        2017-01-23 @1215  	return ret;
6a0712f6f199e7 drivers/base/power/opp/core.c Viresh Kumar        2016-02-09  1216  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp