Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Ross Philipson <ross.philipson@oracle.com>
To:     linux-kernel@vger.kernel.org, x86@kernel.org
Cc:     ross.philipson@oracle.com, dpsmith@apertussolutions.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        luto@amacapital.net, dave.hansen@linux.intel.com,
        kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com
Subject: [PATCH 0/2] x86: Check return values for early memory/IO remap calls
Date:   Fri, 15 Apr 2022 11:09:59 -0400
Message-Id: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lJJ3/cFyHGxo7XPZO1FhAtPftWPRQ7qUPZMe816K/YRJ4Y8cYLjkkLVTRT9r?=
 =?us-ascii?Q?lB3GA00d+H0j0tY1FWB8tpUFp4F9YnTO45D9n+9I1L1s0q6JToek4b2cr7KX?=
 =?us-ascii?Q?XjepHNefVc8ZHd/lf7/L2qzr3GCNZJfmjBdRGseNTH2U+a7K0EgRFVx/quZB?=
 =?us-ascii?Q?lxjLqn8pfHpp1hha/vAvqfPI823LrEMbezXwylojJYpfgIe0+CesRkdwZOeE?=
 =?us-ascii?Q?2r/8e8dXes82tvh1A74iaxwA4cnkXB3Ni1uQfRQLk4QqD1KgvbWcqnJjfmt1?=
 =?us-ascii?Q?xtIIBag5fTRidLItPF6KqdhOdREc5CTMyU+bhLMGtR8cpKpP99LB8x2jBKfV?=
 =?us-ascii?Q?olRC6UtgkcvYnsHG8zLZxx3c/+0RqGLe8VjT4ELUJ5ZbJYozToS4JJpCIbgY?=
 =?us-ascii?Q?MRxNTjqY0p8gPuLz9q8+3zeJw/6jvDj33kasLrNCE/yHchfI/G8ESH2XslWV?=
 =?us-ascii?Q?X7p4N7nRX27Ug6QO6OkiOa8bRvKxNjFKiImjslPzJW47D2uNXGiZQuJiS/X6?=
 =?us-ascii?Q?9UFAX2EAcUZnqnTAlxceYMfUh0ur9efv/xJSkxSyuhJcpPYYc5yjyW+B7FlY?=
 =?us-ascii?Q?T6a3ioBtGgsbSkioiAmUMNiNwdgWWrtn32Ow35nz8JhlhMccMbpqhnc7s9GB?=
 =?us-ascii?Q?sNLm7vJg+Lj5mRI5VkMityIzgoLe1HzIT7UywJwlSUukj6W34CxvE9v1ySEv?=
 =?us-ascii?Q?5KK3pf7ktrE9WxaMGFT/wgsbl1oEL6sVd+evxy7k7GoiAfqlMh6LGYczGIEl?=
 =?us-ascii?Q?echjBTgrQmV+28fLDh2iqgSt8f1Zv7aM07ZJ8Y4sfc0n9qt7Zi+L5yAY/Ziq?=
 =?us-ascii?Q?N+fHQ3c+TChPEs1Zy/qZVFkqPfiesbS42iovcy7KU/x54UGM1gBKDeKF7pSv?=
 =?us-ascii?Q?EPsZUe3xjDh11phiTWnDQUHa8ZK/pbj+CFrzyzLCPbAT37o9kP1lykuWe2rg?=
 =?us-ascii?Q?kyoCkVe44ZUG9hkLZq6h3XPXpaUJtrWVmiW0rQKjilBZcUqPUNhm+slz4bpm?=
 =?us-ascii?Q?nhESG7i6NQwDR7WgwfhqOm981Icl2Yb5JvU1/4HQ7jZNxGHERlW2MoaGud7x?=
 =?us-ascii?Q?0l0OvZpluL42nKIigMvhY3K7Rgu1tS3/fZnwbxc2msnfLmGhbTn4KxU496AQ?=
 =?us-ascii?Q?MHNilCxZqkQzglZo6DJ8UOYX7c5SdWRyzaJAaUnlCRVckIFHdJRTogRrFaq1?=
 =?us-ascii?Q?UgKNnVE1YO3S0QAbD18FDIxKOLvJLd28+9gorcE7s6L7++AfZv2WquQrgKhg?=
 =?us-ascii?Q?l4i/qFODpJUYpAZc63WCcZlyAJH/e9j5miwvLlWQaOjk3o6NMgOdkENWnOCe?=
 =?us-ascii?Q?Su4aRVfZgytsLk1Ns8zaXGoIED6sIrmfUu0I8Lrs2t6wY682j5WdqOA7+AmL?=
 =?us-ascii?Q?mRaU6PSChOCOoTCwEM7yTMdNgShSOZC5QcbvA+4IiTVVk8sbAnockSaMlnJ2?=
 =?us-ascii?Q?esFfVPN6NT8KteVJwRmplxGYAV0Z9U0DtDamrMWaisN8nkILOMrz5x/m54rb?=
 =?us-ascii?Q?4csdWyqiekMyxkYRVlDBW+H7eGKEq5aca6rdgQhY6fNnX685qJ5nEaqJPRzz?=
 =?us-ascii?Q?flcZUy7eA2f13tdCJQit6O2HXhFARqzcLoXVJgmzm1vKOLc3a1gzd06pxSEi?=
 =?us-ascii?Q?lakRFJmA1f7OIjClLBsppxGA+WSVwByOfx8o1EHP72oqqlkqvRmuF2umRAzt?=
 =?us-ascii?Q?rfJ1g8e93/FIZmifPep+C6zXxpIfrS5lpjo1qWWZXZXP1LWHU7ogDm+1Glv8?=
 =?us-ascii?Q?taczJGM+nu3117+aGeCTgLiFeEtBPhQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 817d4da2-5736-4e23-77f4-08da1ef2e762
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 15:16:24.1130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OlRNzCxFpCaYihymZb948G1C1Eypaflei6f47bQgC0o9A+zuoVjaPJD+dR2IctR0M+uh8MrMjD8pr4MRJ+YVC37HS7kJ9czAUZqsPCFt+Kw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5854
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-15_01:2022-04-14,2022-04-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=384 malwarescore=0
 mlxscore=0 phishscore=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204150090
X-Proofpoint-ORIG-GUID: JpPVLijBzvnCn-40zzPtSgzyelrECd4G
X-Proofpoint-GUID: JpPVLijBzvnCn-40zzPtSgzyelrECd4G
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

While sending an earlier patch set it was discovered that there are a
number of places in early x86 code were the functions early_memremap()
and early_ioremap() are called but the returned pointer is not checked
for NULL. Since NULL can be returned for a couple of reasons, the return
value should be checked for NULL.

This set fixes the places where the checks were missing. It was not always
clear what the best failure mode should be when NULL is detected. In modules
where other places tended to pr_warn or panic e.g., the same was done for
the checks. In other places it was based on how significantly fatal the
failure would end up being. The review process may point out places where
this should be changed.

Ross Philipson (2):
  x86: Check return values from early_memremap calls
  x86: Check return values from early_ioremap calls

 arch/x86/kernel/apic/x2apic_uv_x.c |  2 ++
 arch/x86/kernel/devicetree.c       | 10 ++++++++++
 arch/x86/kernel/e820.c             |  5 +++++
 arch/x86/kernel/early_printk.c     |  2 ++
 arch/x86/kernel/jailhouse.c        |  6 ++++++
 arch/x86/kernel/mpparse.c          | 23 +++++++++++++++++++++++
 arch/x86/kernel/setup.c            |  5 +++++
 arch/x86/kernel/vsmp_64.c          |  3 +++
 arch/x86/xen/enlighten_hvm.c       |  2 ++
 arch/x86/xen/mmu_pv.c              |  8 ++++++++
 arch/x86/xen/setup.c               |  2 ++
 11 files changed, 68 insertions(+)

-- 
1.8.3.1