Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp979934pxb; Fri, 15 Apr 2022 17:16:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2PPX7J3a3Sit6XLLn3Y1ANvj1TMIT0RxNAjtSugJweF8ZEeQTLZ0n6EWxcnkAjnV//2wn X-Received: by 2002:aa7:8893:0:b0:4fb:10e1:8976 with SMTP id z19-20020aa78893000000b004fb10e18976mr1487483pfe.36.1650068187262; Fri, 15 Apr 2022 17:16:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650068187; cv=none; d=google.com; s=arc-20160816; b=Ar+7zwj8IY5/zi0ICxhwzOcPe8NkX9KV93WTwBsWsQXP40WCNnxbMrlhFU586yzFl2 W45fvbvZQauxfQHGdO/JKIoOf8Zmjtc0LSKt/J6k8nuXsbdLd2EgmYzocBr27d7yG3RL GjdPmVopoLT7csr2ZZX5LqTT7VpCm3v+S5TfuThFGsUav5hXFD5JfNE4M9Hc9DzssXaX T17/uv/VAniCuQZ7teoHu66UiHuW9rV7p2pCuf9W0qWsxL8MyEFQQ12BcH+vUs4N+8mX fADmZ4g/AwteBBgrRf4PuGGmsY2oR9u4g/VigW+y1/P7wKFmuM2uldXzZIrHG/29lLzB XIxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yY1XpQLOJF8SRfLRiRImiId98yLUwf4ACq4UfHXrlTM=; b=HexyJJmT2uRpEPPECZFhgbttXJXN9RDcBSb8S3NhNdEtDEkNiH1bXCxuMqpYoDRgvm 7s3li9eJZGJfW5e5xAX50avcAO+O8EzlpX4y+86560CTGvpEtGjFNlaLjLpdBJoxz5V4 igQg4tonRmAezBGcYKimpgUSlDvSTM+Gq5+FhEg0DBL3QgvRSR+Ywz2c1zTbrfSYyVAG YrmMcaQiPdY/ssjunxdjSVZhyjG4q8+GgifvJ20lO7Q6lGvXd7CLBAQ5X4Oxp0+2CxUO BszeHL3d2Zt2J6Ub/f7iLLVr5IAArHYa/2m4CKiqswvHCQiWQou4N4PP2JbWbgsBTY6B gpPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ep+eRWJy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id il4-20020a17090b164400b001cd3f26f45csi2983225pjb.166.2022.04.15.17.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 17:16:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ep+eRWJy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 300E0CA6FB; Fri, 15 Apr 2022 17:16:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355858AbiDOQlW (ORCPT + 99 others); Fri, 15 Apr 2022 12:41:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235021AbiDOQlV (ORCPT ); Fri, 15 Apr 2022 12:41:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 13F0DC6B41 for ; Fri, 15 Apr 2022 09:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650040732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yY1XpQLOJF8SRfLRiRImiId98yLUwf4ACq4UfHXrlTM=; b=Ep+eRWJyXssOITUA3LT57x5CP/a77KNcLAJHgr0Q6fwjN1geFQAw9Em4rJ/ZSGSro/zEyX ODtkLjqPkhsSTnOCkdZ/jaeBQ9UAGfpHQ29xDDSzJ6TzlxkMyBwM8wRdUjyDNOUnUMlzDX BD/agJb5N1ri8C/7UhbKa4792xmrGcw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-nA3M0pSZOp6RRNd-FabZnw-1; Fri, 15 Apr 2022 12:38:48 -0400 X-MC-Unique: nA3M0pSZOp6RRNd-FabZnw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3CA6C811E7A; Fri, 15 Apr 2022 16:38:48 +0000 (UTC) Received: from ceranb (unknown [10.40.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D74A2167D68; Fri, 15 Apr 2022 16:38:46 +0000 (UTC) Date: Fri, 15 Apr 2022 18:38:45 +0200 From: Ivan Vecera To: Maciej Fijalkowski Cc: netdev@vger.kernel.org, Fei Liu , "moderated list:INTEL ETHERNET DRIVERS" , mschmidt@redhat.com, Brett Creeley , open list , Jakub Kicinski , Paolo Abeni , "David S. Miller" Subject: Re: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by cfg_lock in ice_vc_process_vf_msg() Message-ID: <20220415183845.51a326fe@ceranb> In-Reply-To: References: <20220413072259.3189386-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Apr 2022 13:55:02 +0200 Maciej Fijalkowski wrote: > On Wed, Apr 13, 2022 at 09:22:59AM +0200, Ivan Vecera wrote: > > Previous patch labelled "ice: Fix incorrect locking in > > ice_vc_process_vf_msg()" fixed an issue with ignored messages > > tiny tiny nit: double space after " > Also, has mentioned patch landed onto some tree so that we could provide > SHA-1 of it? If not, then maybe squashing this one with the mentioned one > would make sense? Well, that commit were already tested and now it is present in Tony's queue but not in upstream yet. It is not problem to squash together but the first was about ignored VF messages and this one is about race and I didn't want to make single patch with huge description that cover both issues. But as I said, no problem to squash if needed. Thx, Ivan