Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp980430pxb; Fri, 15 Apr 2022 17:17:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKq5HHLdJxSLpdnwo9JcCsyQ/2g5Hq824SAAqUm+4kTZF1JK8znsJUYkJns5F/JK9MJ3nE X-Received: by 2002:a63:de10:0:b0:399:4e32:32b with SMTP id f16-20020a63de10000000b003994e32032bmr1088071pgg.41.1650068240274; Fri, 15 Apr 2022 17:17:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650068240; cv=none; d=google.com; s=arc-20160816; b=TVkrzFWfv6dWnJLLHSYXBSWO9YwtWn/O4QOmMo8HDojCimFAKm7fHvgPaDhgjCsi/u uAGWG1D4ZuWAJhdX3KmNFja8NWNiKkIXy+Gcmj5SWSSGp9YNkqlq05KYIWfx8sG0dC9g MlrGY4OF7dGZ0yuIWMhyh5mA2qSuBU3wIg6zDJQom64zLcaButRrpL6ZZZU+1FUWdO86 Mdg7uQAkBm41WoAww+6SY8E7aCtDoHRVTUARAorwzdohB1ffOCpYBh/J86ZQJy94+x9j wqVv1Q8UBhtWUPE2ovyCR/c6kevLNwivyticS+42EEXwO9qPn/McC9vqsglRYrf42nsh cAXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AlSJrh/9aVdD6cccT4WMJlmUmFpg/2qtlWCw6b8UaS8=; b=qjwjR6XkP07k/kvtBCOBDBzPQxHrlgadK8jH9LV8bV8IzC5tvfPjVOPoOXxRZ2UwpV 2edGHhiMSB0xawkTVIZ4mfxS3l6LPYiuxtFaiSdABX/B6y1KZbMxmla4mO3BpotAnNRQ yNUyXokWoDJ0sUCoT7hZBhZKVWNz/CagyqN6sZPJjZHtVWXnrTS4PdA+I7TIloHbCtzk I0P41TrDPrwxx7caWQQxqFyXRgwbvpZrohWN4qbHsk4jaP6eFX48jawmvE8vr6i8kH9F 4T+U95plH2jTqj6XGD9ddtdLNfTZa2GPVfPP6E7Rva90nOc9SIhGVdLNKSO5D+A6Wv1v 1eHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=C85NOtrZ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i7-20020a17090ad34700b001caa86392easi5184948pjx.70.2022.04.15.17.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 17:17:20 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=C85NOtrZ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9A37FCD662; Fri, 15 Apr 2022 17:17:03 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350478AbiDOGeb (ORCPT + 99 others); Fri, 15 Apr 2022 02:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243518AbiDOGea (ORCPT ); Fri, 15 Apr 2022 02:34:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 019FAA7740; Thu, 14 Apr 2022 23:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AlSJrh/9aVdD6cccT4WMJlmUmFpg/2qtlWCw6b8UaS8=; b=C85NOtrZeDmbcQIJtBMn+UH4yg wAE14ydK2cPQcvA6sTvku0725EUU2bbJWA2cYyN2u9LD4UJOa+yettotZc5rO0g7KnNlAyEFW16K7 hg62RpMXTl5L/Yz0ZYkSxPWqx4oLJIlSXpL8KvoAtrWQbcNeOrvmbCbY8xelRO/gbyF/UpQ01jPQF vJyVmnMhijlVS9O0NhmANtGNZ10CI+W+5CaLCIQOAn8ZlhswxHSjFe9g7rb8uVHo2NaJLGMqQBTe6 ptdU5ynL/jRR9whMLC6m2YXic1KtNhebfGx23pgAY/mQ2xg/CVO6JVuLS5twqV8+8KH8I53Xfnnkr B8r2XJbw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfFUx-0090pQ-Gn; Fri, 15 Apr 2022 06:32:03 +0000 Date: Thu, 14 Apr 2022 23:32:03 -0700 From: Christoph Hellwig To: Song Liu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, akpm@linux-foundation.org, rick.p.edgecombe@intel.com, hch@infradead.org, imbrenda@linux.ibm.com, mcgrof@kernel.org Subject: Re: [PATCH v3 bpf RESEND 2/4] page_alloc: use __vmalloc_huge for large system hash Message-ID: References: <20220414195914.1648345-1-song@kernel.org> <20220414195914.1648345-3-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414195914.1648345-3-song@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 12:59:12PM -0700, Song Liu wrote: > Use __vmalloc_huge() in alloc_large_system_hash() so that large system > hash (>= PMD_SIZE) could benefit from huge pages. Note that __vmalloc_huge > only allocates huge pages for systems with HAVE_ARCH_HUGE_VMALLOC. Looks good (modulo the possible naming chane suggested in patch 1): Reviewed-by: Christoph Hellwig