Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Yihao Han <hanyihao@vivo.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH v2] ath11k: simplify if-if to if-else
Date:   Fri, 15 Apr 2022 05:58:53 -0700
Message-Id: <20220415125853.86418-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NUr2jmoAKwngzD8NOw/Cj1hCx/Rh0i8X9g237f+slc+JUC+hNNcHCCswZlb1?=
 =?us-ascii?Q?pKQ0mxTVVurJ3nF5Nh3+nMtqihAUtU96/oFggQEjWiwAxxTwe1H76gHbxug+?=
 =?us-ascii?Q?SiES+ftlY+egkibjKJRY+wrqE9TlwXzWRa+3P7bloyeTP3hcEMdlHRQik1Mc?=
 =?us-ascii?Q?9g1U+sosYPKS3qEytrUMOKKYN0uwnNL5HKWCWDsOC2nrDL2ZCB+rMH8kxWcV?=
 =?us-ascii?Q?A7c6TOUZ9tnh1U+SseCBa3Ndtgfl/yAntpvysCIL8k/3huSPBtdRGa3SsCMr?=
 =?us-ascii?Q?G8m7EvPkaJ7eWB+LK2GqnuuVtCFvzqYFSzj6N5E9x1JUcMdS89EHgOQyMCrU?=
 =?us-ascii?Q?R9k0rpwvvP+uQ52NP4MLOx57031T0BR8uVmtr4Pj2xR36hr6fJR2Ro6QdRtE?=
 =?us-ascii?Q?YfbbaIR4wZoMj6Zn+UcD202MJKZ+8kuJ+lwy/gPt4uGRd3JbAnUnOYKsXxw+?=
 =?us-ascii?Q?14dKEjooEg1Pn2My262mxOmZd9wLKUcM9ZO3GvkKSafZA0tG5aBnGUTVod9A?=
 =?us-ascii?Q?RNu9oSUnXlcnGx93YfUrj1hsP5dTCcqxhvyYZQCOoXBYJuVahkvVNoCRv0rf?=
 =?us-ascii?Q?0AvrB8bmx6yyELvPI3OxCCs4K+8wspgaHvxUXbIc7zFv57F4909pMrZX8eK9?=
 =?us-ascii?Q?iBlnI8VMqKEb5OBPqIEe9HkzTQv900ujUoBZtZqDzgSMNaKiq03/W+YNwDAh?=
 =?us-ascii?Q?unmCg4Dcinj21L1YK/ohHlEk4YbqbjLZJ747jknLzjf/NN+jK7gVIG4PACQP?=
 =?us-ascii?Q?e+AsUwbh6YTjfFXTA0JhmWREJDX7kugRiJO24TUR0SmpktSspjKOrCe/5IdV?=
 =?us-ascii?Q?D2DKgNH1odYerulilc9XML8bqhG/MLInP+MaS6WZXREjuz8RIVPz/BCPfgaK?=
 =?us-ascii?Q?95OnPZeifcLyluYfWe2gnPo4dLeZQIK9WqmIWuDSuXehJBC2jbLAT8dlx1rw?=
 =?us-ascii?Q?AfLFrIICPSfFdIn0VP0saz/Eg4cVcv452RMeWJ2LWPqeFMXhRRcGRtLd91L0?=
 =?us-ascii?Q?WOtROJ60PyIHTCxKT38ZBRVNjq2xo3g2cmHBHDbM5G/KKKV8EAnRgxCzJ4kM?=
 =?us-ascii?Q?o+DybHjk1ANyx+9vLR/oWZow4D2tKmoyuUhE2QicqZ3mGTQjtfYSlR2aBkmZ?=
 =?us-ascii?Q?SWoG5flBSP56bh+nGwLpMLV8Isro1Rbj4Ub040W8HTTtFxRDiT6DmI3w/7En?=
 =?us-ascii?Q?wpBL7uZ/xuztf/X7ZuVPlK+CGoUA5TFaP1acj6iKXy5YsrUCnUttos4w86IE?=
 =?us-ascii?Q?1WoZtbq+lrEM733KqeVF6Izsqda5KSfZiLRnAPD+p/6IDr636LeZicWuqT8S?=
 =?us-ascii?Q?2BRfBFRG75DK7EJTnqxXNShqJgVq6GbTgdmvv6dm3I1RmYgi9VYlVkzh4fL4?=
 =?us-ascii?Q?y2euRyVgssUm11hKh5wOFsXMuJsjfOHTF/M9dscpLA6Tqx0DQhDYOhzRqZeH?=
 =?us-ascii?Q?okRkUTmATdUZiH02EkBZi4kYvK85QuP1jqPpox66YAbYVlug++bbohOl/9dQ?=
 =?us-ascii?Q?EmbjgQCeLqLHrK29TSR/tA432aMrLvFMnFCaMXnzsLbJuF8jHpZtUo9q2whA?=
 =?us-ascii?Q?GgU5uXsfiW6EE5jBraTkCF96Nhx/KEDR1UUlRCgHd9GbaddafRniuhw3G4X1?=
 =?us-ascii?Q?aLoVVF5MsvxDoYgNs/aB0Vl/kyA0NmxO6bms/V9GY2vPAM9hFLU2nnc0Di9V?=
 =?us-ascii?Q?WYBuGO+439dTFT2lULPq0CoDXn2vZ+U3oELA4/tNyWzt+aGbWEpbxJ/3P5i2?=
 =?us-ascii?Q?1C2UIyQWgQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2331a2b-9160-4ac5-3625-08da1edfba9a
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 12:59:08.5586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2F8ISDJfWJhnbECTeOiR4DnTpyWucw4ZIIhiDbRHee077T3kddZJGt+xODZsTCVdVmK/xPiJdyfovjp9r8vjqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5013
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Replace `if (!ab->is_reset)` with `else` for simplification
according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Suggested-by: Benjamin Poirier <benjamin.poirier@gmail.com>
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
v2:edit commit message
---
 drivers/net/wireless/ath/ath11k/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index cbac1919867f..80009482165a 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -1532,8 +1532,7 @@ static void ath11k_core_restart(struct work_struct *work)
 
 	if (ab->is_reset)
 		complete_all(&ab->reconfigure_complete);
-
-	if (!ab->is_reset)
+	else
 		ath11k_core_post_reconfigure_recovery(ab);
 }
 
-- 
2.17.1