Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp982389pxb; Fri, 15 Apr 2022 17:21:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8kn0dTUrjcc1DrdA/n6RMV4918eBmzaqdmPaq91QoKeMjmmbqVIEEjk9LLtUILIF1Ho2/ X-Received: by 2002:a05:6a00:a12:b0:504:e93f:2dd9 with SMTP id p18-20020a056a000a1200b00504e93f2dd9mr1492558pfh.49.1650068475568; Fri, 15 Apr 2022 17:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650068475; cv=none; d=google.com; s=arc-20160816; b=DQCw4meBNXbuc6t9+1CDiWnSNugaegAf93Jkphi19gZoWcxdoqCJp7mX+JYSh+tdpV EVFwHOfVDjlU4hbCeReZhvLz80y5xNdZjnXEIOBcLRhyJDtfTdbAYW7ZwAm8i5H+3tHK 4pQeJanieN5JmUfGyDrlx9jnMqa+04AhdPefVRsqYovb6zMCe5VceDVB5cmoWVvCieRM Gxk24b61Wkzo4asXE6+Wq6IPSq9LMzWp+2ZAREpfZSvGyFBSCRSV0cehgTu7pze547SE /N6GbmpOIn8I66wUv5utn1WqND62Kv7E5Tpoz4D4/aP/r3qqFuc0+cL0Ekzc9+0M7Ffj owOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GWdoIzKa55+GJDLFWdqzW9nhtvvqYhC7BmkK6QUgeQ8=; b=Ex3sHvfNB7cxJz8wPj4s5qgyXNuQwBgD63ZIpeE0V91oXJjr9c5BaczWHGV1TiK3b1 2Q3jSbHucrNAFeA4YPLR+3JYLOXfsi6cTHHSmBwotaFKlJdh6yk8/Kxl3NSC4XTmHsAp IJqhXgYChYuseBK8nSb0b4K+89ytlFqAN8m0YUnLSRcxTqWhDOVXF09UgFiIAvsmSoql a116h1fRBULxTPgd3m5IOdE5fF2S4wjdhWGRcfLBk/0trEHN47LD8fAq6hqlnzfQrp78 icWxcxsGPsrAc7JYztlbHjEng+NKc+zlC8J7orxaencENklRvxYaa1ySuJE9WUZuVu1N CBRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FQWESL3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l14-20020a170902f68e00b0015827ec0073si2965649plg.452.2022.04.15.17.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 17:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FQWESL3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 99BB9D760B; Fri, 15 Apr 2022 17:19:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243009AbiDNMLI (ORCPT + 99 others); Thu, 14 Apr 2022 08:11:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238441AbiDNMLH (ORCPT ); Thu, 14 Apr 2022 08:11:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 88BBC1F61E for ; Thu, 14 Apr 2022 05:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649938121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GWdoIzKa55+GJDLFWdqzW9nhtvvqYhC7BmkK6QUgeQ8=; b=FQWESL3iHnb/PX+vo0UbKgiXCEyIWb3qdAmFjksB3KgvbsLmaTo+12RhCDbEby3Xs314+l 8CJq2378LGpXmTA9JavgUoLGnXIdUJSg1dz5ls/B2zqo0EDC57U44+oUK6e2uWSKyh9msA 3csn2dSROKKMfQG+XAEtFcLy/7Ovatg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-Ju0YXrAyOISCLufSTPlYvQ-1; Thu, 14 Apr 2022 08:08:37 -0400 X-MC-Unique: Ju0YXrAyOISCLufSTPlYvQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5CCF811E78; Thu, 14 Apr 2022 12:08:36 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.193.235]) by smtp.corp.redhat.com (Postfix) with SMTP id 90CFC1454556; Thu, 14 Apr 2022 12:08:33 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 14 Apr 2022 14:08:36 +0200 (CEST) Date: Thu, 14 Apr 2022 14:08:32 +0200 From: Oleg Nesterov To: Peter Zijlstra Cc: rjw@rjwysocki.net, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, ebiederm@xmission.com, bigeasy@linutronix.de, Will Deacon , linux-kernel@vger.kernel.org, tj@kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/5] sched,ptrace: Fix ptrace_check_attach() vs PREEMPT_RT Message-ID: <20220414120831.GB32752@redhat.com> References: <20220412114421.691372568@infradead.org> <20220412114853.842942162@infradead.org> <20220413132451.GA27281@redhat.com> <20220413185704.GA30360@redhat.com> <20220413185909.GB30360@redhat.com> <20220413192053.GY2731@worktop.programming.kicks-ass.net> <20220413195612.GC2762@worktop.programming.kicks-ass.net> <20220414115410.GA32752@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414115410.GA32752@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org this doesn't really matter, just for completeness: On 04/14, Oleg Nesterov wrote: > > if (wait_on_bit(&task->jobctl, JOBCTL_TRACED_XXX_BIT, TASK_KILLABLE)) > return -EINTR; > > this is fine, No, this is wrong too. wake_up_bit() does exclusive wakeup. Oleg.