Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 14 Apr 2022 18:51:46 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Markuss Broks <markuss.broks@gmail.com>
Cc:     linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Liam Girdwood <lgirdwood@gmail.com>, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] regulator: sm5703-regulator: Add regulators support
 for SM5703 MFD
Message-ID: <YlhfMkBqst87qvtD@sirena.org.uk>
References: <20220414170616.23319-1-markuss.broks@gmail.com>
 <20220414170616.23319-5-markuss.broks@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Z0LrZJXyjIRCPfH2"
Content-Disposition: inline
In-Reply-To: <20220414170616.23319-5-markuss.broks@gmail.com>
Precedence: bulk


--Z0LrZJXyjIRCPfH2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 14, 2022 at 08:06:15PM +0300, Markuss Broks wrote:

> +++ b/drivers/regulator/Makefile
> @@ -173,5 +173,6 @@ obj-$(CONFIG_REGULATOR_WM831X) +=3D wm831x-ldo.o
>  obj-$(CONFIG_REGULATOR_WM8350) +=3D wm8350-regulator.o
>  obj-$(CONFIG_REGULATOR_WM8400) +=3D wm8400-regulator.o
>  obj-$(CONFIG_REGULATOR_WM8994) +=3D wm8994-regulator.o
> +obj-$(CONFIG_REGULATOR_SM5703) +=3D sm5703-regulator.o
> =20

Please keep the Kconfig and Makefile sorted.

> +static const int sm5703_buck_voltagemap[] =3D {
> +	1000000, 1000000, 1000000, 1000000,
> +	1000000, 1000000, 1000000, 1000000,
> +	1000000, 1000000, 1000000, 1100000,
> +	1200000, 1300000, 1400000, 1500000,
> +	1600000, 1700000, 1800000, 1900000,
> +	2000000, 2100000, 2200000, 2300000,
> +	2400000, 2500000, 2600000, 2700000,
> +	2800000, 2900000, 3000000, 3000000,
> +};

Are the repeated values at the ends of the array actually valid or do
they indicate the part being driven out of spec?  If it's out of spec
then it's better to exclude them since otherwise we might choose one of
those values when configuring a voltage which may not actually work as
desired.

--Z0LrZJXyjIRCPfH2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJYXzIACgkQJNaLcl1U
h9DVtwf+N9TxlnsrmD3gmtxCP88m0egnYv2wkBye2EQazhLNwpw3ir6hRAh54lG6
ZPVc2dhUrXiqYmifTGW0F1AnVyAYXOD31TfaW8MWx+cKO8EHAZuZ/Ft6Z9zlfB/R
polfgdIRTOJO4v8IaMpqkOONxS1LIZydCm1bYE5l62EEq274JjQATq8bdEhA948q
ynBRZqLavYTLhXkY1mCVRcRAQq8XbINOfJZKFq8yMabTNVZcsKQcyv0WiIz4IUUl
UH22eoY865JPFP1X96inbbjc/S4eyoxKCNIb6zh3on2nask54GTsCtinjK5RyjZF
DfhZ7G4GwuUo3vgSAnWJ3uXIHqXXkg==
=Q53Z
-----END PGP SIGNATURE-----

--Z0LrZJXyjIRCPfH2--