Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Fei Liu <feliu@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>, mschmidt <mschmidt@redhat.com>,
        "Brett Creeley" <brett.creeley@intel.com>,
        open list <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by
 cfg_lock in ice_vc_process_vf_msg()
Thread-Topic: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by
 cfg_lock in ice_vc_process_vf_msg()
Thread-Index: AQHYTwdgAUOf4mt7B0uReHLUHxZf1qzw4TgAgABPRYCAAB+EsA==
Date:   Fri, 15 Apr 2022 18:31:51 +0000
Message-ID: <CO1PR11MB5089695CB3733F4B1284E3CED6EE9@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20220413072259.3189386-1-ivecera@redhat.com>
        <YlldFriBVkKEgbBs@boxer> <20220415183845.51a326fe@ceranb>
In-Reply-To: <20220415183845.51a326fe@ceranb>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IOeci1LKuWqE+TYK0pt/30e7mo6pPez8ztmDs/pkJDWtys/OuDVhItJNZWHz?=
 =?us-ascii?Q?6QvkNfp3FHzr09HFwopg1o5fZ1elh2Lwk4WxKG/4ROb/mSkdyFdeaU5KMm8i?=
 =?us-ascii?Q?zQu8qUIFBmSj1iPk7klIHc05H3IttJjzJvuUyn+ptB5+h+eYkKFkJbEZETo2?=
 =?us-ascii?Q?E5hdvut9jI4roN0pqxj/893lHkGicy5Mm8+dDQmAVykBJObxdO2BstSeuIA9?=
 =?us-ascii?Q?Ed9Du8TAMBoHosuE+7fIttGQjaVyK6Q3EoZqEU8OwGqFVvsVl/5TqA9y5pmv?=
 =?us-ascii?Q?rFqcQiRVimPrFJLayqDni9TZkB6dUythwuR0zF9+dw1Hfa8qh4agHUhFn46N?=
 =?us-ascii?Q?2TH1qiINWvhUrS0HDTY2zf50GG9xTcBE2mwFLA8FHbexeadeZ8fCI4OFu4ZD?=
 =?us-ascii?Q?WukU5NVSiRi6GcCPNcg6FTrA1I6zpIhEDGa3FAJHnkZIdiAeGUpxeSp5HoiW?=
 =?us-ascii?Q?8gHxlfvK02fXkhMtfGmMy/MCIDZFCvgg8awNXoxT4wOYPw15krkTeqLtZ3KA?=
 =?us-ascii?Q?AT0SbVOWzfXmYJbKuxG+8ufBzyAJG329tgqzyyR6lPeQeGs4BUu4WPuiMesK?=
 =?us-ascii?Q?I2re1S/CNfZiV/hXkexVCQIH855/V8BC4tHs3GZxIPtnLpLC007SwZq04wor?=
 =?us-ascii?Q?sMtfj9L73gx5RFl11qroDT2A6h1bItPfiBKbSArfysY2SpncY4wWEMCLnlD4?=
 =?us-ascii?Q?Jk4w9vgdApdzBfTOR0WZzj2iGGGify2XEFwWzbllmfHCwhebAMAE7Pa5cvnr?=
 =?us-ascii?Q?7irhOKFzvISQNQDqQZ69VJG+ARL4kAyI63mpsZ0b4TGW2Bdqm7WaNK02zVAP?=
 =?us-ascii?Q?NUYlSnIn/AJzCfAUCRf2cZGu8aZdst51R+lyP3GFF02joj2nY0ew9HJHnjTr?=
 =?us-ascii?Q?hmYRFvGIIW77jzzknOIL4kvh4Bv3Z81IlYPe6UjSUt2Bvt0W9fDZsDOcJfiN?=
 =?us-ascii?Q?ntRfvyERAs381cdJDu196DzjgMgm01XqedCJpC5XTbtkSXMor4K/NHbuOnIG?=
 =?us-ascii?Q?trylvOQ9VvG3cAMf4YNf1Om4pgHrRAFalBzCHp889NXy0jDP5/ICqB5LzuQa?=
 =?us-ascii?Q?JERlp1EP+DjLfQZa5vXGeuITyw/FzTAArmDPBHWfjvUAY1dbr3Ne5GIO2faz?=
 =?us-ascii?Q?HH3Yn6yGManOSKvPTjPkOb7RjnMlLwrmEA53PocunUd7r433JL4G+f/5HjdI?=
 =?us-ascii?Q?m5dezVzl4yc+sVEbfzHvg+baNtKCE+dX9gfr8iu3OS5M92KB8ED/uQdGB8PV?=
 =?us-ascii?Q?o0BMnkYuR7dg6O7v9FcSghOVx5alLG9jzEyPXSI8EAQcDjf80YVGBmjOffMb?=
 =?us-ascii?Q?bOCHWFjtgbdYUOQ/0o9cg1VVwhmjjemq3TjUjc6qlzFj4qq01xs2tOMH50dK?=
 =?us-ascii?Q?74XmLRqkkz4/WMDCPNlkpEtVz1PTxtrpw8lWlzDikeivPguTzu38uuK4lLYN?=
 =?us-ascii?Q?5ZgNoyUAcBpZYE+zb+dCMlEB2k9XRhvgw0pnGiUl2joEdLGdGHIRntKvdYkV?=
 =?us-ascii?Q?FFFLJN7GKOvWY5IEcxFoJIFnhl52iBaexFh0ZDZ2GSRtWIE1IGjKbf3U5eJm?=
 =?us-ascii?Q?XT/yIVRShjj1VD3rjLSTDjqu3MuBH9grFXgCvlWBLReSPvifNks2PlHBaWWQ?=
 =?us-ascii?Q?9pdpL33FWoxJ0Zcu87z/xlhtCSY4Z4clw0fLAYBT5XZDTj9CarqAp0VH3evl?=
 =?us-ascii?Q?NouK4AgTTqaf8tNHzMGpgPS2SF/G2xvfqyi8ukPVDRw/4TgPaQjZ4Qg6K+mj?=
 =?us-ascii?Q?lliQUFZNGQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a18d459-1fee-46ff-1a9e-08da1f0e35e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 18:31:51.9880
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eNlGPy34sdr7VuXPXG99LYEnkxKumhVgYE/fbnQWTl6UpMnBb1FFJpjcBwL7fU5VrVFJGOKeGcdLfnliSfsfJCy0yLyI9osrPfWBmgNarAo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4353
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Ivan Vecera <ivecera@redhat.com>
> Sent: Friday, April 15, 2022 9:39 AM
> To: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Cc: netdev@vger.kernel.org; Fei Liu <feliu@redhat.com>; moderated list:IN=
TEL
> ETHERNET DRIVERS <intel-wired-lan@lists.osuosl.org>; mschmidt
> <mschmidt@redhat.com>; Brett Creeley <brett.creeley@intel.com>; open list
> <linux-kernel@vger.kernel.org>; Jakub Kicinski <kuba@kernel.org>; Paolo A=
beni
> <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by=
 cfg_lock in
> ice_vc_process_vf_msg()
>=20
> On Fri, 15 Apr 2022 13:55:02 +0200
> Maciej Fijalkowski <maciej.fijalkowski@intel.com> wrote:
>=20
> > On Wed, Apr 13, 2022 at 09:22:59AM +0200, Ivan Vecera wrote:
> > > Previous patch labelled "ice: Fix incorrect locking in
> > > ice_vc_process_vf_msg()"  fixed an issue with ignored messages
> >
> > tiny tiny nit: double space after "
> > Also, has mentioned patch landed onto some tree so that we could provid=
e
> > SHA-1 of it? If not, then maybe squashing this one with the mentioned o=
ne
> > would make sense?
>=20
> Well, that commit were already tested and now it is present in Tony's que=
ue
> but not in upstream yet. It is not problem to squash together but the fir=
st
> was about ignored VF messages and this one is about race and I didn't wan=
t
> to make single patch with huge description that cover both issues.
> But as I said, no problem to squash if needed.
>=20
> Thx,
> Ivan

I'm fine with either squashing or keeping them as separate changes.