Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <5f4c6fe9-0b4b-5474-50a6-bf9a6bbc3b9f@intel.com>
Date:   Fri, 15 Apr 2022 13:56:31 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] ixgbe: Treat 1G Cu SFPs as 1G SX for X550EM
Content-Language: en-US
To:     Jeff Daly <jeffd@silicom-usa.com>, <intel-wired-lan@osuosl.org>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220414172020.22396-1-jeffd@silicom-usa.com>
 <20220414201329.27714-1-jeffd@silicom-usa.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20220414201329.27714-1-jeffd@silicom-usa.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWY5RVNNTTJ1RlBVYU10aHByYTI5OVdOVlRuamplWHM1T3BISjNmSm5yYjBU?=
 =?utf-8?B?Yk15Tmo4SDBSS3h2amFyaTdQeTZ6Zkcyald0N2syaHF6dDdObkNFTnU1R2o0?=
 =?utf-8?B?VjQ4bDRZV2dnbjRDalRQK09LVGRRRXordHJ6dThFTGljNUNlZDhlVjVweTA1?=
 =?utf-8?B?bkY1ZnduK3pFYk9PaElnT1NncFdMMk04emJ3Q3FIMnlxT2JIdzBYRjBZa0tM?=
 =?utf-8?B?NDhpQm5BTVpJVUIrM3Y3VTM1QnpCeldBVFNXY2NXbmYvT2hpQzU0SGhOWXB3?=
 =?utf-8?B?ejJiSGxGSW13cW1xNDFwK3J5WTY2U2k3M2U5bEt5VVdwVVJZemprR0dPb21V?=
 =?utf-8?B?ZXpRRFBHTURpMEhSYSs2Tjdnc25CQjFibmNpakZJRzcwUjNPZzZqZ2c4NGJ1?=
 =?utf-8?B?Q2c4NlZhYUYyWHRyQTJMcWExS1NUUXVLNGVkbERLTWNaZWhxWUJxcGI4aVJ1?=
 =?utf-8?B?M2VIM3ozOGw2WXZDREJJeDBLYUQ0emFBbnEvR1lSSVNRbkFjem9YWVM3MFV3?=
 =?utf-8?B?VzZTTXg4aTdCa0NOSk1ZUDNRUDBGZ3dyRk04bm9aZ2orT1RtdFZXdm5MdnVJ?=
 =?utf-8?B?NC9SMDB5V1lFZEZ5Nzl2ZzNuSmN1dXBtaXlOU1Nod1ZMSVd5S2RJRlB4Tk55?=
 =?utf-8?B?TW83alpOWUl0b0VUMDRYcFplN0E1WE9RY3FMVHJwQWR2TlNtS0FmRENtdzB4?=
 =?utf-8?B?N1U3d3ZhQytPSG9IcGRvN3IvcHFBaHlJbVdsOGhtczVPZmZUSWZDaUpPVEJQ?=
 =?utf-8?B?YlBKTitZM3RYZjVTMU1CNEVkMXI2aTN6NTNXTHkvK2Z4cXd0b2tXejNnNjVC?=
 =?utf-8?B?cmFIOWdIQVl6ekJlUVRIaTAwd29RUXQyMjl1QXlqaU9CcDJ3Vnk1WU9vTVBz?=
 =?utf-8?B?SWVQYUlrcmxreHBIOFcvbTFOVUM1cFNkYmZnQ3Era2pHUEZkYzEzLy9JYUo4?=
 =?utf-8?B?L3hIbWl5SGNrRFpPS0YyNHlQTWVJOWN6YUdrMnJQdlNBYWc4RVNhTjRwbEUv?=
 =?utf-8?B?c1BZdVZoM1ZEMDVvdWhuL2pYWjdZL3ZhaDcySmJDZnVxZDZXOGl4Y1NHSHM4?=
 =?utf-8?B?L0JqbFI1K0NWTTc2dnVvUDlneElWSmxkLzcvaWp4QnBYcXVLRWxiVm1tVUw3?=
 =?utf-8?B?d1ZsbWEwSDFWbWhjdElweXkzcFZUNUVNQWZIZHlxSWhERVRiL1VVVW9BQnFk?=
 =?utf-8?B?c0Y0ZTlqQU9KWm96dnpwYjl5S0N6cEdQc29uWFV3YzA0NjF5VXUwQ3BBZzAx?=
 =?utf-8?B?STMxYVBaVjArZ1FLczFnd2FZVTdoUktoY0JMajRCSnkxS0Q2T0syTG96UGRH?=
 =?utf-8?B?TGhMdlRKSGZib1FGMUs1Qm0xZG5sc0FlQ3oxaE1BTldhSzBqVktadlBuL3BO?=
 =?utf-8?B?dWtSZTRQbTlpbGJFbGFUbXFnckFTVkFkS0FrZHVMQU9uMFVzVWRKamxtSFBN?=
 =?utf-8?B?ck1zZFlmK0xoMGVDNG9TUUlXcGlxVi81a0Z3OTBsQ0JQd1BHMFZzQnRsT2dL?=
 =?utf-8?B?QmhmUnhzQ3dTYS9uRU9zTnlhR2Q4MVoxWFhneTl1cm5pZnVSWmZvOUpKd1R3?=
 =?utf-8?B?Yjdvd0FaVWJGQ0ZpdWZvTE1SNk9UU0Q1YXBhLzE1SVVRdC81ZVYzSE84bzRu?=
 =?utf-8?B?SFJvL3dTSzM5dmtYUUkyTkFtdEF5eSs1RGU4bnBzNHZqbFFuSkN2WitsRXdO?=
 =?utf-8?B?blV0Nyt1b256VDFnN2VEVFI4R3ZiaFBHa3Y3a2U2bkU3UjF4QnNIdFR6ZnVa?=
 =?utf-8?B?R0JrZUQyNjFZYUdzK0N1MFg0Rk9yaDdGVG5zT3ltRDlubkJublNCNzFMRklF?=
 =?utf-8?B?VlJ1SDQ1TUtJMENOMTZ5Smh5bWMvbkdKaXltMmd4MERwc0l6M05lWEl0em1h?=
 =?utf-8?B?eDQ5WjlreHU2WkhOT3AvS21tYlg0dEhvQ0dtMWpWUFBhR3hNYi9VaDZnTzJB?=
 =?utf-8?B?T2VLSEtjR1czWlFaUWlsY3hYSlJWeE4rUnhHWHgxZHFDRTlDaTRXalo2TjVG?=
 =?utf-8?B?NkpFTElXdEE5cW54UUR4Y3ZET1Y2dWZzNVlSdk5qRnZrL3pkZTJTT2ZPclY4?=
 =?utf-8?B?OFB2M3ZxRWQydnRlaTYzMVRKSW1OSllYU0xXK0R0YWlaclhpa1hZMmNGZWxB?=
 =?utf-8?B?bXRNaWVRM3dRcGdDQTRFeVZWMW8ydS9OMXRBajhpemxMVkRLQW5oRkhlZ2Fo?=
 =?utf-8?B?YitIdWkzcm51alI5aEwrSkJKYzgxMGZlK2pqWG1xSWhCWUpOYTc0dnI2RC84?=
 =?utf-8?B?VjhGRG1QemxjMGNpK1JPZm1KZmZISmpKa2IvbC9jSThKYUJsaFRpMHhtSEtI?=
 =?utf-8?B?VC9ybEVwWjB0MENIVkExNjhiTm9KNVRTeXlkL0FLQ2RKelhoWVA4N0d0aGov?=
 =?utf-8?Q?8AKfjitBxetBVFYs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4631d38d-1c68-4552-94e2-08da1f226c65
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 20:56:33.5854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zVq+/2l6nSyEnnwALUYJIvRUvW4fVyxKQ2/0XdNJpXRExR3OKlXHjYj1EnCrT4TK4yH4yO7wJ5KHkex/WN0HOdLoFVfsufLqA96BPFhi0YI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5337
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/14/2022 1:13 PM, Jeff Daly wrote:
> X550EM NICs do not support 1G Cu SFPs by default from Intel, this patch
> enables treating these SFPs as 1G SX SFPs via a module parameter similar to
> the parameter that allows the driver to be able to recognize unsupported
> (by Intel) SFPs.

The addition of new module parameters is no longer allowed.

Thanks,

Tony

> Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
>