Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp985518pxb; Fri, 15 Apr 2022 17:27:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBhMjvv/0CYnqyVdwxUsYpMF8y4ZnfZ+EFnsLitoVSXrsjQTSYZRCRug82orp+OsQxzn+y X-Received: by 2002:a65:6cc8:0:b0:382:1b18:56a9 with SMTP id g8-20020a656cc8000000b003821b1856a9mr1109849pgw.347.1650068826147; Fri, 15 Apr 2022 17:27:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650068826; cv=none; d=google.com; s=arc-20160816; b=M6uVkr6W/lGXHTHkjdhnOFDKiQDs4cIf7UIbJwbKQB0/thNpHNNENJxUiayEL+jhbK FcUbCjld5knypRiq1EPQ7fwCGQVAXPv81REVGNpP0CXse3u1sTNHD0Td868Qbuq0BSX2 99wCM1QVRd47ubnJMl54mgRF7s6XMlQhNmpJagEeZ2CCK65q2ZCWQvTZAinSRWUUreUO 5A10atkboK34H7eDckbEfzURACMuX5bynJ8EmIiKQ5rCM/op7I2SY3hyynrRTwTvLFvs BRsTWAeqESWAegEIMjxEYIsfCkMZO6mkAZLRqXlfhklfVh4KJ7JXLmI2344EJ4pFZG8Q Yvaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LvxHOjjPSqDfEIERe8vY9wM8Pb/QDf7DRQ3tKHSDPtE=; b=PZhbCgzkfcVe5TQb0NvjSbYVo/ClBVDpiTwr5e8laESa3anDHZGyh6SCx79kuiZu9M Wb7vK69hIvGEG49qdw/JZqt9wuwbUgxWAxkiexfsCPdt4GQtqNnEwh8vw9Z6wieVkxEi Qs7HOZl/UZnXyYfFSgowMwy5uVBh4SG035Te+vGG63F9RW9tpt2ZO1Z1hMBn6iD/bNSp RAAq3UKUV4DO9MPjskZlCdL1FH73RoaloeDgHApwqHwpUk4g7CvjEOC678+O4rvB7ang lLuA8rWNSuQ4V1SPOih/BqBzQfKB8v3E58GaXkbNSMA9Y/k87uYKftb6uzyvJsmDaOP/ PTDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="Y/4dWiF0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id a21-20020a056a000c9500b004fa3a8dff73si3002531pfv.42.2022.04.15.17.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 17:27:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="Y/4dWiF0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EB9DB183A2; Fri, 15 Apr 2022 17:24:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239456AbiDNV1v (ORCPT + 99 others); Thu, 14 Apr 2022 17:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241466AbiDNV10 (ORCPT ); Thu, 14 Apr 2022 17:27:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4094AE6149 for ; Thu, 14 Apr 2022 14:25:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0757DB82B61 for ; Thu, 14 Apr 2022 21:25:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 613D2C385A5; Thu, 14 Apr 2022 21:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649971498; bh=1fW5C9p+VqRotwZZLlRMnVPtuH73+1atlPH6e+BjlOQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y/4dWiF0jnQ/NUhMqpTAzaT+nwlqer4zRBYjg0+e2TJL4jEXr+mnPy60zrkoeuO02 ZKgcqO8utmTajOsymxq5PD/dq2z7RQTFcvK+bk9fIZQLnq4h41aF7TnNYKIucmu07V mAvUjaSq3HmVCRciaD0e9JK4+p9IZhe97ofJw2sk= Date: Thu, 14 Apr 2022 14:24:57 -0700 From: Andrew Morton To: Aleksandr Nogikh Cc: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, dvyukov@google.com, andreyknvl@gmail.com, elver@google.com, glider@google.com, tarasmadan@google.com, bigeasy@linutronix.de Subject: Re: [PATCH v3] kcov: don't generate a warning on vm_insert_page()'s failure Message-Id: <20220414142457.d22ce3a11920dc943001d737@linux-foundation.org> In-Reply-To: <20220401182512.249282-1-nogikh@google.com> References: <20220401182512.249282-1-nogikh@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Apr 2022 18:25:12 +0000 Aleksandr Nogikh wrote: > vm_insert_page()'s failure is not an unexpected condition, so don't do > WARN_ONCE() in such a case. > > Instead, print a kernel message and just return an error code. (hm, I thought I asked this before but I can't find it) Under what circumstances will this failure occur? Why do we emit a message at all? What action can the user take upon seeing the message? Do we have a Fixes: for this? From the info provided thus far I'm unable to determine whether a -stable backport is needed. What are your thoughts on this?