Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp985714pxb; Fri, 15 Apr 2022 17:27:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwj9YxXOm5cktcU6ohAPqtkQJ/VJRuTG/AGCwcgvsO/kyUJA8WxQRqEIsDrme8RAq5KKTaR X-Received: by 2002:a17:902:a981:b0:156:229d:6834 with SMTP id bh1-20020a170902a98100b00156229d6834mr1440357plb.128.1650068847622; Fri, 15 Apr 2022 17:27:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650068847; cv=none; d=google.com; s=arc-20160816; b=Q/XLyCnK2vUqeSSpX4srFIqYXp2IhBolR0BthHp9gtw02dmT4Z7v36e2OyYvGm+/fM 6EBLP/xumZcuN3f6dXovggHkYc1Z76LhC40xWHv6eZiLkjbyE4gDoiYfXsvjorPOTEkA 28I4CvY3DNm9kJoVGdr5A13NBMd99KwAKhR+Kl5wydkHons0RWUVZ/t+dCR7ESPP5+z+ S9vyBYITVP/8nv0/Gkh21I0GpplRYsb6+Kj8+4AyqBEf895u32kn/v1n0+pHY1Ugjwvc N5liwRtltP1XUwOlgfcoztfafv8Fv9HAPrYzPSPh78Q+sl6cFQpR4Mr1P6mjvwX3nanE jlNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=N1K1AqmYzjj34nPkHAfP4VmmPE4go7/T5kLl3CWQKks=; b=for8fmZS6sWa+ndg197jHWWxezhuXwHc4H0AVdJUW8iS5sInIz23Mjwd68oh/payr4 2YuDu4eA8YURyeP08y9JombBGZGjP4dNAfnhn99sMaNw1cAEfEJCkLOLYUI4tQtV7ra8 apdDVR/wMmFKx4yYzN1+x4fzKauoT8L5no+1Gf1FuDkM0GSV4JzsVK3oUG/ImoldMa5K fzqyxvzt/C+WqvfQdIW1/zGlydnYQcN7GguFnNO9VlyqxrndXZ1bqM86tTnay+wLY+wL dOjUbWb4JpRZxOM5P9uDZ6SdgzP4zFzDNWleX5vQEJtagCpagDiuMU7KZvp+huvyzsKj 7mlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y3-20020a655a03000000b0039d7d10e4bfsi2819774pgs.852.2022.04.15.17.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 17:27:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D5CC5E09AC; Fri, 15 Apr 2022 17:25:14 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350412AbiDOUF2 (ORCPT + 99 others); Fri, 15 Apr 2022 16:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350369AbiDOUFZ (ORCPT ); Fri, 15 Apr 2022 16:05:25 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6301AD103 for ; Fri, 15 Apr 2022 13:02:55 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nfS91-0004ix-Km; Fri, 15 Apr 2022 22:02:15 +0200 Message-ID: <2231070a-85ed-94d3-7467-dcdd8822ad56@pengutronix.de> Date: Fri, 15 Apr 2022 22:02:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [EXT] [PATCH v6 4/4] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys Content-Language: en-US To: Pankaj Gupta , Jonathan Corbet , David Howells , Jarkko Sakkinen , James Bottomley , Mimi Zohar Cc: "kernel@pengutronix.de" , David Gstir , "tharvey@gateworks.com" , Matthias Schiffer , James Morris , "Serge E. Hallyn" , Horia Geanta , Aymen Sghaier , Herbert Xu , "David S. Miller" , Eric Biggers , Jan Luebbe , Richard Weinberger , Franck Lenormand , Sumit Garg , "keyrings@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-integrity@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" References: <20220316164335.1720255-1-a.fatoum@pengutronix.de> <20220316164335.1720255-5-a.fatoum@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Pankaj, On 28.03.22 12:46, Pankaj Gupta wrote: > If the structure "struct keyblob_info", is used in patch 3/4, then below use for CAAM specific macros > will not be needed to be set in this file/function. Yes, I moved the output size computation into the previous patch. > If the structure "struct keyblob_info", is used in patch 3/4, then below line of code will not be needed. It must be set regardless. How else would the trusted key core know how big the blob is. > If the structure "struct keyblob_info", is used in patch 3/4, then below line of code will not be needed. > >> + p->key_len = length - CAAM_BLOB_OVERHEAD; Likewise. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |