Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031422AbXEDRWL (ORCPT ); Fri, 4 May 2007 13:22:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031435AbXEDRWL (ORCPT ); Fri, 4 May 2007 13:22:11 -0400 Received: from wr-out-0506.google.com ([64.233.184.227]:50799 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031422AbXEDRWK (ORCPT ); Fri, 4 May 2007 13:22:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=KtQLaK2owwrxlZSmv00r8DuiPC1g4F8TObzkQQAzUwiZm1NqhGX+iztbnZSL3LgwlHVpxjX9jRY1KFIFm/0q+O7z92i8RONgJ5SekvpSw9XrhBobxgLICc3LXHa7Nf1jnbtBMsDpA5HbEnb0RdRwgJjSyZB2N4ipeDQuIVKkvio= Message-ID: Date: Fri, 4 May 2007 22:52:08 +0530 From: "Satyam Sharma" To: "Rafael J. Wysocki" Subject: Re: [PATCH -mm] PM: Separate hibernation code from suspend code Cc: "Andrew Morton" , "Johannes Berg" , LKML , "Pavel Machek" , "Nigel Cunningham" , "Pekka Enberg" In-Reply-To: <200705041132.32227.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200705041132.32227.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 26 Trivial suggestions: On 5/4/07, Rafael J. Wysocki wrote: > --- linux-2.6.21.orig/include/linux/suspend.h 2007-05-02 22:08:58.000000000 +0200 > +++ linux-2.6.21/include/linux/suspend.h 2007-05-03 15:22:24.000000000 +0200 > [...] > +/** > + * hibernation_set_ops - set the global hibernate operations > + * @ops: the hibernation operations to use in subsequent hibernation transitions > + */ > +extern void hibernation_set_ops(struct hibernation_ops *ops); Comment must go near code, not with prototype in header. > +/** > + * hibernate - hibernate the system > + */ > +extern int hibernate(void); Pointless comment. You've already written a doc-book comment in the code for this function anyway, so could just as well remove this. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/