Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <44108a7ad56dd6984523af35cfa003f4ed7be41e.camel@gmail.com>
Subject: Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap
From:   Bean Huo <huobean@gmail.com>
To:     Po-Wen Kao <powen.kao@mediatek.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     wsd_upstream@mediatek.com, peter.wang@mediatek.com,
        stanley.chu@mediatek.com, alice.chao@mediatek.com,
        chun-hung.wu@mediatek.com, cc.chou@mediatek.com,
        chaotian.jing@mediatek.com, jiajie.hao@mediatek.com,
        yohan.joung@sk.com, jason.li@sk.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Date:   Fri, 15 Apr 2022 00:07:56 +0200
In-Reply-To: <004b55d8-fcd3-136c-526c-6ada025d6a1c@mediatek.com>
References: <20220412073131.10644-1-powen.kao@mediatek.com>
         <781bfe33efb1e44d22f71e6711da7d15be9d3ab4.camel@gmail.com>
         <7550da4043ae45ffd58399f1ee696238a5689f25.camel@gmail.com>
         <004b55d8-fcd3-136c-526c-6ada025d6a1c@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.0-1 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-04-14 at 12:49 +0800, Po-Wen Kao wrote:
> Hi Bean,
>=20
> The general idea looks good.
>=20
> As ufshpb_issue_umap_all_req in ufshpb_state_toggle won't actually
> runs=20
> at cold boot probe due to the fact that sdev are not present yet,
> this=20
> should avoid sending HPB command before UAC being cleared while keeps
> HPB mapping clean when rest flow occurs.
>=20
> Just a concern, shouldn't ufshpb_issue_umap_all_req be send for each=20
> sdev's corresponding hpb?
>=20

Hi Po Wen,

I replied in another email that setting the flag resets all active
regions in the device, which is a more efficient way, I have submitted
a fix for HPB device mode, your review and testing are welcome.

Kind regards,
Bean

> Looking forward to your further fixes.
>=20
>=20