Received: by 2002:a19:f614:0:0:0:0:0 with SMTP id x20csp24752lfe; Fri, 15 Apr 2022 17:43:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwRGJQsqFyuFihNDEtT5a+uvmue7Bqjvfjg2XIFTa+NDqjYDNKiiC6q6GU4yVtJv2aXY81 X-Received: by 2002:a17:903:1cd:b0:158:eaa9:7291 with SMTP id e13-20020a17090301cd00b00158eaa97291mr379990plh.113.1650069822454; Fri, 15 Apr 2022 17:43:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650069822; cv=none; d=google.com; s=arc-20160816; b=n/dqLnse0+Lw2saV1ElmSEiZDJt1cUyyt4QYc2qDeTPP+cG4jfVyrj61fasvokyDHj XLmMQAhLvqrUW3tHY1815ydMwiqSXKVetgiTMUVcKXOQ3s5fJzhCK0ojUiDx9IipSTZI +nH36BzEdoty0z38UzQ3XmOaDkw0QQot1upSu2gGYQY8wEBjmFMvOxIYT1QWy6So5ho2 JqKISJLqybkWC/ZDFRUJl0mJxUFKIPp1EagrG9U8GG2alcsEjZOokuwZU4mRKB8BNyn9 GhrWGIsITlZCj/sPEs0FWYCtF1InwZ9KJ/02VIi9hnSQAcyHH1v4PpqLOZ/G0nx/tfYm KHxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=WebPVtGMXwiaKLP3FU98CAuUa7w60cn7WdQ5x8iGnDU=; b=tWDz6SgA7gKWMylyu4R9zjo86G8uDqyM5Xl2fx2MAxBxaaHepffcquzPqZxKoc5Jb4 b0HZz8BgMNEiCmGMkDFSYozVrU7iU2R2sIwDEY5bUqm6XTehS9vb7KH8FpCvq3tRap/n +WStziB0EMAbewS5MCz0AoQ3kJxInldpRb3vWs52f7pNxHijK6HPZRQe9hvujXrQwPbo ulpjzc8y5XpWvR5fgeD4nVZkAnY4XSzY3fQum3MrtzFWt4ATLZVm5dBo+0nEqygNdDBv skH5t/VPYA6FqH2EoV4ig/TGlShu0w7Y/mFtxhaOcxJIn6GE37jb8pPk6TIsh53iGkDy Vo1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hop638oH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h19-20020a632113000000b003980ae22575si2847954pgh.438.2022.04.15.17.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 17:43:42 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hop638oH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 05DEE46B08; Fri, 15 Apr 2022 17:35:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242988AbiDNPtk (ORCPT + 99 others); Thu, 14 Apr 2022 11:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348831AbiDNPkK (ORCPT ); Thu, 14 Apr 2022 11:40:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 34E9EC31F6 for ; Thu, 14 Apr 2022 08:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649949525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WebPVtGMXwiaKLP3FU98CAuUa7w60cn7WdQ5x8iGnDU=; b=hop638oHshtLcMgRiSEvvYQgftNraKx5+o8vlYnqxD5I17FiEqiw/BqD/aQAXAelwzqyp8 +IzzdR7x6AEezRq4Cv7R6dn0nFakzBYgzpoUFXZYc/jIjLMJLCEzVuS4dUN+9RTSSxW0Wr ktXt5xVU0kbSfTCVRVOCIrmt4h6KHkM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-18-sEc2PB6GOKC5B2KpO2xgtg-1; Thu, 14 Apr 2022 11:18:41 -0400 X-MC-Unique: sEc2PB6GOKC5B2KpO2xgtg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 589AC811E81; Thu, 14 Apr 2022 15:18:40 +0000 (UTC) Received: from [10.22.19.30] (unknown [10.22.19.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE8292166BA3; Thu, 14 Apr 2022 15:18:23 +0000 (UTC) Message-ID: Date: Thu, 14 Apr 2022 11:18:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5] locking/rwsem: Make handoff bit handling more consistent Content-Language: en-US To: Greg KH Cc: john.p.donnelly@oracle.com, chenguanyou , dave@stgolabs.net, hdanton@sina.com, linux-kernel@vger.kernel.org, mazhenhua@xiaomi.com, mingo@redhat.com, peterz@infradead.org, quic_aiquny@quicinc.com, will@kernel.org, sashal@kernel.org, stable@vger.kernel.org References: <20211116012912.723980-1-longman@redhat.com> <20220214154741.12399-1-chenguanyou@xiaomi.com> <3f02975c-1a9d-be20-32cf-f1d8e3dfafcc@oracle.com> <31178c33-e25c-c3e8-35e2-776b5211200c@oracle.com> <161c2e25-3d26-4dd7-d378-d1741f7bcca8@redhat.com> <2b6ed542-b3e0-1a87-33ac-d52fc0e0339c@oracle.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/22 06:48, Greg KH wrote: > On Tue, Apr 12, 2022 at 01:04:05PM -0400, Waiman Long wrote: >> The patch has already been in the tip tree. It may not be easy to add a >> Fixes tag to it. Anyway, I will encourage stable tree maintainer to take it >> as it does fix a problem as shown in your test. > I have no idea what you want me to do here. Please be explicit... > I would like the stable trees to include commit 1ee326196c66 ("locking/rwsem: Always try to wake waiters in out_nolock path") after it is merged into the mainline in the v5.19 merge window. It should be applied to the stable trees that have incorporated the backport of commit d257cc8cb8d5 ("locking/rwsem: Make handoff bit handling more consistent") since this commit seems to make the missed wakeup problem easier to show up. Cheers, Longman