Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 15 Apr 2022 14:13:07 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Donghai Qiao <dqiao@redhat.com>
Cc:     akpm@linux-foundation.org, sfr@canb.auug.org.au, arnd@arndb.de,
        heying24@huawei.com, andriy.shevchenko@linux.intel.com,
        axboe@kernel.dk, rdunlap@infradead.org, tglx@linutronix.de,
        gor@linux.ibm.com, donghai.w.qiao@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] smp: cross CPU call interface
Message-ID: <YllhUx6g7ySAtk9k@hirez.programming.kicks-ass.net>
References: <20220415024701.876364-1-dqiao@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220415024701.876364-1-dqiao@redhat.com>
Precedence: bulk

On Thu, Apr 14, 2022 at 10:46:50PM -0400, Donghai Qiao wrote:
> The motivation of submitting this patch set is intended to make the
> existing cross CPU call mechanism become a bit more formal interface
> and more friendly to the kernel developers.
> 
> Basically the minimum set of functions below can satisfy any demand
> for cross CPU call from kernel consumers. For the sack of simplicity
> self-explanatory and less code redundancy no ambiguity, the functions
> in this interface are renamed, simplified, or eliminated. But they
> are still inheriting the same semantics and parameter lists from their
> previous version.
> 
> int smp_xcall(int cpu, smp_call_func_t func, void *info, unsigned int flags)
> 
> int smp_xcall_cond(int cpu, smp_call_func_t func, void *info,
>                    smp_cond_func_t condf, unsigned int flags)
> 
> void smp_xcall_mask(const struct cpumask *mask, smp_call_func_t func,
>                     void *info, unsigned int flags)
> 
> void smp_xcall_mask_cond(const struct cpumask *mask, smp_call_func_t func,
>                          void *info, smp_cond_func_t condf, unsigned int flags)
> 
> int smp_xcall_private(int cpu, call_single_data_t *csd, unsigned int flags)
> 
> int smp_xcall_any(const struct cpumask *mask, smp_call_func_t func,
>                   void *info, unsigned int flags)
> 

Can we please remove that x? That's going to be horrible pain for a long
time to come.