Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 15 Apr 2022 14:57:34 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     YueHaibing <yuehaibing@huawei.com>, mingo@redhat.com,
        xiaowei66@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ftrace: Fix build warning
Message-ID: <YlnqTjK92J2nxQR3@bombadil.infradead.org>
References: <20220407074612.16608-1-yuehaibing@huawei.com>
 <20220407105917.715eaa2e@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220407105917.715eaa2e@gandalf.local.home>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Thu, Apr 07, 2022 at 10:59:17AM -0400, Steven Rostedt wrote:
> On Thu, 7 Apr 2022 15:46:12 +0800
> YueHaibing <yuehaibing@huawei.com> wrote:
> 
> > If CONFIG_SYSCTL and CONFIG_DYNAMIC_FTRACE is n, build warns:
> > 
> > kernel/trace/ftrace.c:7912:13: error: ‘is_permanent_ops_registered’ defined but not used [-Werror=unused-function]
> >  static bool is_permanent_ops_registered(void)
> >              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > kernel/trace/ftrace.c:89:12: error: ‘last_ftrace_enabled’ defined but not used [-Werror=unused-variable]
> >  static int last_ftrace_enabled;
> >             ^~~~~~~~~~~~~~~~~~~
> > 
> > Move is_permanent_ops_registered() to ifdef block and mark last_ftrace_enabled as
> > __maybe_unused to fix this.
> > 
> > Fixes: 7cde53da38a3 ("ftrace: move sysctl_ftrace_enabled to ftrace.c")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  kernel/trace/ftrace.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Queued onto sysctl-testing. I have one more fix I just posted for this too.

  Luis