Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031433AbXEDRoo (ORCPT ); Fri, 4 May 2007 13:44:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031435AbXEDRon (ORCPT ); Fri, 4 May 2007 13:44:43 -0400 Received: from [198.99.130.12] ([198.99.130.12]:51065 "EHLO saraswathi.solana.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1031433AbXEDRom (ORCPT ); Fri, 4 May 2007 13:44:42 -0400 Date: Fri, 4 May 2007 13:39:58 -0400 From: Jeff Dike To: Andrew Morton Cc: caker@linode.com, LKML , uml-devel Subject: [PATCH 3/3] UML - An idle system should have zero load average Message-ID: <20070504173958.GA7948@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1371 Lines: 37 The ever-vigilant users of linode.com noticed that an idle 2.6 UML has a persistent load average of ~.4. It turns out that because the UML timer handler processed softirqs before actually delivering the tick, the tick was counted in the context of the idle thread about half the time. Signed-off-by: Jeff Dike -- arch/um/kernel/time.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.21-mm/arch/um/kernel/time.c =================================================================== --- linux-2.6.21-mm.orig/arch/um/kernel/time.c 2007-05-04 12:40:52.000000000 -0400 +++ linux-2.6.21-mm/arch/um/kernel/time.c 2007-05-04 13:13:39.000000000 -0400 @@ -177,6 +177,8 @@ int do_settimeofday(struct timespec *tv) void timer_handler(int sig, union uml_pt_regs *regs) { + if(current_thread->cpu == 0) + timer_irq(regs); local_irq_disable(); irq_enter(); update_process_times(CHOOSE_MODE( @@ -184,6 +186,4 @@ void timer_handler(int sig, union uml_pt (regs)->skas.is_user)); irq_exit(); local_irq_enable(); - if(current_thread->cpu == 0) - timer_irq(regs); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/