Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        krzk+dt@kernel.org, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, robert.foss@linaro.org,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm,
        Andrzej Hajda <a.hajda@samsung.com>,
        Jernej Skrabec <jernej.skrabec@siol.net>
Subject: [PATCH v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()
Date:   Thu, 14 Apr 2022 15:10:35 +0800
Message-Id: <20220414071039.423271-2-victor.liu@nxp.com>
In-Reply-To: <20220414071039.423271-1-victor.liu@nxp.com>
References: <20220414071039.423271-1-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnVaN3B1SlJuM1ppMnp3ZGovUWdxTTd6UVRxWjBhaHoxeDBCZkh2ZFh3V1VQ?=
 =?utf-8?B?bThWM0thWnNPekVSZ0V4WHpjWEF0a1VieXBqbWtMZWUxOG1EcWlkRGo4V1Rm?=
 =?utf-8?B?TE50Y0NSNGxEWWFOcEpOWHh3NENSVEJta0JRUlNCZUFzakxtQWZQM1pKTWxI?=
 =?utf-8?B?V3dXeERjVXNBWDVJT2hIbXM1cXZUbXFsTWQ5OFduNHRON2Y1d2xiWGVDM3d6?=
 =?utf-8?B?RlUvS0lsRklkYXpwNTRGR25UaFc5V3BUVkFvV2tzbmczVU8vaXVDSG44ZHkx?=
 =?utf-8?B?TjFrSkU2R0Y5bXhYYzFkbU95UmFYZ0pPZUZHZTZWbFJ1bkJKTVB6TFpXKy9C?=
 =?utf-8?B?RCtQVElGWnRWdVNHYVpuNU53VTYyK2hreUZxbDAzdjFUVWg4amlNbG9nbGpP?=
 =?utf-8?B?WDUvSGpIc1VsNzVLTHdnb0YyN0lSblM3clI3cDdKUUdZYVNrUXNnOTZMdFV3?=
 =?utf-8?B?VnFqQWd3amZ2MVZOcUtYNlJQeGMyUFFlSWl1VGhxY3c1bHVmWGN6ZUY0dEpS?=
 =?utf-8?B?aEJNMjRFMFQvVm80N2dsc0RrckMxYkwrdmR2RXp2YVJYeG8xdWIvblozL2hy?=
 =?utf-8?B?MVlPVHJXQVpmbCtjTGgyMWFkNzhHSGJkL1lxaWl6WFFTbHVoVUtvUDhlUWVV?=
 =?utf-8?B?bVBGSjRLMVdMWGFUeGV6dzJSV1JISFV6YU5WMkx2WHB4NFZnUHhrc2lUMkph?=
 =?utf-8?B?bnR5UysrRm0xdXJGakd2RFM5WkJoQVFwT3JvSmRRMXpiTFJDS3N2N3FhTCtQ?=
 =?utf-8?B?SmdGckZqQjNLenF3MGpMUURDMEcvRXk2b0xLb1RUSCtoem0yMFN5SFhWcHJi?=
 =?utf-8?B?WVpJR1IvUHB5T1U3dHJZOVVIVEwrTlBhY0FxTGtkZjVrL3JjdHRjWTZKWjF6?=
 =?utf-8?B?N1BNNE5TNVI2Y3RENkRScGVvN2kyZHhjVHg0SjJJNjk0TkVOTzZKcVpiN3dp?=
 =?utf-8?B?cUgwMldhRlBtUVVWSjBPcFQyNUNvMnJOZWJtY0FzeDlHdVMwTWNSMGplbnV6?=
 =?utf-8?B?Y0tEUUFKODJWSHdEU1hGcU50TTB6Yyt3NU5JbHlZU2dZaTloU0VEbHZlMnVJ?=
 =?utf-8?B?SHN3V3FoaldwQ1lXc0hLNjd3VnY3Z2ZaVnBmUVcrWUpzaGZITzJ5S2pKenA0?=
 =?utf-8?B?RHU3UG9BdVhsbWZpZUw5L1QwMmJCK1dqbnJZZlcyd2dqbm5XZFJ3Z2h4WXVQ?=
 =?utf-8?B?ejFha0hsdkw0YzZHUmgzYnVKVk8yOHpMdFNDaDFWaTQ4NzF0Qng5N291WlF4?=
 =?utf-8?B?WjdzZkdXNkdXUjlSLys0a2c3TWxtaHhPc2dHZmRUVzcrZVJGc0w1N3lHakp6?=
 =?utf-8?B?T0tUSE1Oemx6N0JnNk5jWVBKVFVxTnM1MVA0cHZ1ZnBQbXR5TGJPYVUvV3VS?=
 =?utf-8?B?a0pjNWdWYWtDVG1LV3VxY3liNzlFZHFwV0ROdWNWdmdVNUpZdU9kb05Nb0FP?=
 =?utf-8?B?ME0zeGsvc2lhQnNGNmJFT0N3MnczWTZKQlMxZXRrOVlNeTZiWTVXOGc5WG9z?=
 =?utf-8?B?RHN2WUFlMnB2QVAxeGNJMDFvdTd0cVk0UjVja3p0WjdpL1Azb3gzbmVIRndm?=
 =?utf-8?B?aXBtcjFwU2o2dzRQUHZDU2hkaWRJLzYxNkFHbjU3SGZCd3U1T3BhZk9BR1h1?=
 =?utf-8?B?MWlEcFhyY3VuWDlYcE90dGZ1ajY1RlNaZGptUDRIbXcxVE1FS3E0czJiUFNX?=
 =?utf-8?B?S1B3SG54NXJDakRUZUQ2TXRGL1RCZnNVVEk1WDJZSkE0bjh4QUY2UksrTkEw?=
 =?utf-8?B?TUhRTXJ6KzVOK253TzRVeTY4Rm9uNzRLL3pXVS9kY3NCVjBUYlk4WENjendH?=
 =?utf-8?B?WlNDdzBLK0dnNGViQmxIYlkxRjg1Qi9UWldHQTJRaW9BSWRCaW9tRmZoekFq?=
 =?utf-8?B?QVNHdmZ0K3J4ak0xMEhsTHYzWHZjZDhVOGNicUw5ODlRZkczZVdFMUpBUXo0?=
 =?utf-8?B?VmFOeUo3d3NlMXZMRmFPb3dMT2k3MHBCMVFlQm5SaG4xa3VPRkpES0J3YlBm?=
 =?utf-8?B?Y1pSTmEraTkrTWNTNFM4Nk4rK0JCNGJWcDNBTDMwK0hoUndCckk2czVKZzM5?=
 =?utf-8?B?Qk5NNGlEVGZ4bDNkTmJvdHdYeExSM3pxMExmRVlYdkF1UEtoZ0ZvR2d4ZFIw?=
 =?utf-8?B?a1ZjRzN0NTY1MllkazBJR0YwMnZ2bWJGMUt0M1VteGVva3hIbGM1Q3VWUC8r?=
 =?utf-8?B?M0pkUER2SzVKblFQVk1Fb3gzSEtXaURVRkhnTGJJNEJvdHR6U0VnNkpjQ3BP?=
 =?utf-8?B?ZG51R0hSajhtYVp2ZS9JSVBVaURRb2hEYVZ5QmVyNTNCcUMrNGlPb2I5blJp?=
 =?utf-8?B?OHhFQTFUOFBsejgwYzVxc3VUN2xETytvdmdVa2UySG9nSDUrYk83Zz09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17c75abb-9c88-4cf1-c548-08da1de5a7b5
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 07:09:02.6801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Az9lDrgiMsbzDu/QiAna3ZQr0NkQzZrea0HGXWtyhjtSterOAUT0FbrB0ERLnEzLQZP44EHIAVWVJgJJyayQNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
works with a Mixel MIPI DPHY + LVDS PHY combo to support either
a MIPI DSI display or a LVDS display.  So, this patch calls
phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY
explicitly.

Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v7->v8:
* No change.

v6->v7:
* No change.

v5->v6:
* Rebase the series upon v5.17-rc1.
* Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi
  bridge driver due to the rebase.
* Drop Guido's R-b tag due to the rebase.

v4->v5:
* No change.

v3->v4:
* No change.

v2->v3:
* No change.

v1->v2:
* Add Guido's R-b tag.

 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)
 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index d5945501a5ee..85bab7372af1 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi)
 		return ret;
 	}
 
+	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
+	if (ret < 0) {
+		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
+		goto uninit_phy;
+	}
+
 	ret = phy_configure(dsi->phy, phy_cfg);
 	if (ret < 0) {
 		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
-- 
2.25.1