Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 15 Apr 2022 08:31:16 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     gregkh@linuxfoundation.org, davem@davemloft.net, len.baker@gmx.com,
        dave@stgolabs.net, edumazet@google.com,
        Haowen Bai <baihaowen@meizu.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging: rtl8192e: Fix signedness bug in
 rtllib_rx_assoc_resp()
Message-ID: <20220415053116.GN3293@kadam>
References: <1649988571-19923-1-git-send-email-baihaowen@meizu.com>
 <8973092.rMLUfLXkoz@leap>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8973092.rMLUfLXkoz@leap>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?g9+4CmOdbmVeC7bmxfqbFKh/XnEg4niFL3l4vT486ZyzyYzKAgfpeCXN6f?=
 =?iso-8859-1?Q?nwRf3q18W20a7FZE91/ny7cZdfGnVVRATm3Ew5gofGhrSWcnvuuG+w2rhL?=
 =?iso-8859-1?Q?/WHLNNmRKfx/UH9WV1HoKdg9W92gIctSrNOh8V2VXw7j9isVEWri4ssJzm?=
 =?iso-8859-1?Q?7CAzeGO0puH8uBiqjnAon1ZN8c4ARo76AyfV+zRnS/LLEtbTV0MoSdanv/?=
 =?iso-8859-1?Q?btDx9/ZDrK1Of7Hx9J9FpTDCKDjiilUbbUXYFMzBRughRDpth5wVjEaU33?=
 =?iso-8859-1?Q?jG8Iu+le2jIJBEDM+yLNOJo8dsvfCuEr96rvLUsX3e3kI0mypzqKxhINzb?=
 =?iso-8859-1?Q?edZPp1mu1c9M30GLqCQrzhjumYyu87vud3a8oIDF8EzsmVpFZorCDH5VVg?=
 =?iso-8859-1?Q?lIhG7AoA2NWWZ4IVsb4Nqvmi5aID+90hoV/TypLtuzV768wNmxjHfa4ORZ?=
 =?iso-8859-1?Q?TcYtDo28aqKwS0mwBNVDufujucn+nwBoxF2LQCW6zUBBStR6EQuId82/iR?=
 =?iso-8859-1?Q?r2xdmh+MBylviKZqDLzDevMCluBMUYFqhZOWq5y5ggW33EE0qDrhM7bGF9?=
 =?iso-8859-1?Q?sp1dB1iJkB2KLOZarXJg6qLi4ay8vf51zfAGflwQYHgtYovSevrdjucG8q?=
 =?iso-8859-1?Q?mepJnrhDZ7bhFforYp/L9DjGCobCWvILdac8vBBdBQi9QAR8MakmZpiPT5?=
 =?iso-8859-1?Q?/hmDdW7Hnx6EFhIFPGKAKgQ/x+6ZZZqd/K+Nr+7TT7v1PLTELonHX1Ewbv?=
 =?iso-8859-1?Q?wgDABDl0nUqFuDCK6vY4Ey7yUwpwhbZMgaBo2ilmbsB8iPp52Vj3aGHoNN?=
 =?iso-8859-1?Q?PegFtdH+8bzYbuiRpKCgSqW2UjN2hHSAL2kNCr38s8umelsFGnLOuWUptG?=
 =?iso-8859-1?Q?xub6KiMsphx9QDH/C0l771YRT01oATgooES1kf5akeCeWRFDadonELa87H?=
 =?iso-8859-1?Q?Wcl2TS4xwxPY7qPLnJ3FPQRGaXCHM1EyVZz7wmKTGhX5qhTC+WVBIDDNKC?=
 =?iso-8859-1?Q?DucnIoUqT9vTKUhOUWoCmGyW/sGK/e1ZaNnvF6QCZkmEKzZIdV6vXSxklP?=
 =?iso-8859-1?Q?cH1rz/m8YIRowdbIut/TtOtKn+CqrgQuS1FxPStpXDQ9S45t324sxF/Nz7?=
 =?iso-8859-1?Q?2CPEGvuMYmoOux+Eh5+izkg8tH59r8dcErCtlUqQJMi67CVCpszCbFPMlg?=
 =?iso-8859-1?Q?vjenCDOHF4O/w7hhCRB753LF02bJwNQ1e/P8tFvyGNOPkVkH92rykOSGU6?=
 =?iso-8859-1?Q?M2GcCRFxl2Sg6nSY2kQ9/ar1JPT/ZKsMnxCP9fJoUvIKXYGsXQw85EWWGj?=
 =?iso-8859-1?Q?Fv9Ayx8PB8SP2DoL2F/Rvc8jRCtjYiKNOw7Dwc3Pee3wkwHOe0SORQ+/XW?=
 =?iso-8859-1?Q?IGfUxgB6huKBzYq7TNgJ2DINOcxFy3bBXtKJ77hP/875y/sT22XDNUm7no?=
 =?iso-8859-1?Q?Z++PzNs32htq5KP44pURf+a4+LoauXZu5ZzqWtmWwJ7QOiibqKQdgWOIXJ?=
 =?iso-8859-1?Q?oKwOw5rEDKVZjRvYQn8ZjJ5Vusy7fgkN3J4axZiANtRs30D1QGqOICfOwd?=
 =?iso-8859-1?Q?+xKhk/600/NMM2PjRNDH+mpUjonNsj7/XuzuxtTuPayZXjzDw6Z0/TKm28?=
 =?iso-8859-1?Q?LboM7+4/Z3KeeCoGxjAMA1k2aSjVjAMdLN94SHFl9LHrL3+623dKYnEJQe?=
 =?iso-8859-1?Q?sQlMOt6bA5ZCfF3jOJjRcoW/sG+uHrRSU5XuSoRx4QIZKyE4/sD/Spy9k0?=
 =?iso-8859-1?Q?RprrKJVE2z6VU4jXZQllOu/9rwBLu2REgAo3M6wSraVGG5hRdnCe1TbZX1?=
 =?iso-8859-1?Q?XtqXbi43eP5ZDs4g/kv5faOHMPZpvrs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e111ab6-b458-455f-cb88-08da1ea131ce
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 05:31:30.3675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t7lp0GhiWUFQWX56nDr1jaMQqbxD2DQAWJuHS/BVgPc5hx593lsA+pyVv2VoaH0LpyMkK5uSKLJ1zvrPR3adR1JCvfKcFaMbRw03fMVu6oc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1446
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-15_01:2022-04-14,2022-04-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 spamscore=0 adultscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204150033
X-Proofpoint-GUID: kRSNacYKdB-hw3SdFx3cnZnOAW5Ga8EH
X-Proofpoint-ORIG-GUID: kRSNacYKdB-hw3SdFx3cnZnOAW5Ga8EH
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 15, 2022 at 07:22:36AM +0200, Fabio M. De Francesco wrote:
> On venerd? 15 aprile 2022 04:09:31 CEST Haowen Bai wrote:
> > function rtllib_rx_assoc_resp () unsigned errcode receive auth_parse()'s
> > errcode -ENOMEM.
> > 
> > Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> > ---
> > V1->V2: reduce return random value; print its own error message.
> > 
> >  drivers/staging/rtl8192e/rtllib_softmac.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> 
> > [snip]
> 
> It looks like you are doing too many things and that those aren't even 
> discussed in your commit message.
> 

Nope.  The patch is one thing, but maybe it could be described better.
Here is my proposed commit message:

"The rtllib_rx_assoc_resp() function has a signedness bug because it's
a declared as a u16 but it return -ENOMEM.  When you look at it more
closely it returns a mix of error codes including 0xcafe, -ENOMEM, and
a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG.  This is a mess.

Clean it up to just return standard kernel error codes.  We can print
out the a->status before returning a regular error code.  The printks
in the caller need to be adjusted as well."

regards,
dan carpenter