Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 15 Apr 2022 09:58:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] staging: rtl8192e: Fix signedness bug in
 rtllib_rx_assoc_resp()
Message-ID: <20220415065810.GQ3293@kadam>
References: <20220415062000.GP3293@kadam>
 <1650004767-27432-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650004767-27432-1-git-send-email-baihaowen@meizu.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Mqz8gcUlRGGi92kHKAbjJ1Rru6PV32KR13mnQYJpLoKvM1Ay3MdFKqrE5hdi?=
 =?us-ascii?Q?Ak5I98MmJ7L0RzNvKogDpJp0FevJwkmM3yQGPqbbMBnzpui953oZfYhhgOSX?=
 =?us-ascii?Q?Q0usCBjv53GoRb8jSrVUobk/Xx0Use0lGiIXLx35MXp4iE5h4FJ8fRBUOsEY?=
 =?us-ascii?Q?blF7xk5+l3w1hZPlEXclsDj//efkVvjo8lcwnA94QJPE4SlvngwWCF5SdzKz?=
 =?us-ascii?Q?Z+Kv0bxePw8VYyUYIGhJbeOwVRbNifha41tniFTbA4nrVn77u0+kF+gYtuji?=
 =?us-ascii?Q?Tv+zuxUhrD49TheYruABoHb+OG22t5Veo8kb74buJRa07DboUhB0qWVjGZBb?=
 =?us-ascii?Q?4OOP74U1CozRpALsmMH/m3uAcNo4laFYccuPYQ81GiBHQxAyZ24IEek+sdhq?=
 =?us-ascii?Q?dDccovNx976Ku1DntpI84aItuSEbiWHJ5qjewTvWF+ax4hVW2N9FFLG1yYk0?=
 =?us-ascii?Q?dubEnscXzFOtbkp6TzjFlGVQXi5fOW/Oqf50fJeDq3NCNkcLqo3QWY4sOfIr?=
 =?us-ascii?Q?jtwYMdG8xMucerEW6Ys833EbnJ3LFoWrzhjWt+jy6dQbiuVa/WJFZvBAGiAV?=
 =?us-ascii?Q?BneINE9BWPoIywpqzQVMFSnCsKST3kjJStklXdzcREB4FWkmA7Jp1Hrpxg5e?=
 =?us-ascii?Q?5raW1bHu3ctJzV4SFEaaKA0ciYUja1SO43WLexVXNndz0L2EGsAdztoPsfdL?=
 =?us-ascii?Q?iOnT3yWZ2KkAgXhgAxBI2GpkeFryq16g/pNVrkmWplcf2ogMrJE1CtslD/gw?=
 =?us-ascii?Q?iwce+Dr2C4suo5J6NvQMWNwZI72hyEmxEqEOMyUZ9lEeHOmwJy+Ph7oYm/z7?=
 =?us-ascii?Q?W5J6Ek/qPxCByD1INOnBJXTQl4v2ai4ul1j5HaFCxw1zy8NekNALoeknNANe?=
 =?us-ascii?Q?HvmMhbP23XzHWjhUMG5PCiOoCsQXozX+TD8KciZinUu/6oqyyl3qnUOLTx0a?=
 =?us-ascii?Q?wST37uXlXYFFR+iUWmW0N9hYkLvbhPinln5L/DljMfpUtF+IXRfQWD/2/x4d?=
 =?us-ascii?Q?Y3nGdf4YJ/SxT2rnuHmhCXRsNQ4yygXLonjwMk+kLCiGX5kI0xXfZalM+wac?=
 =?us-ascii?Q?CZ+uApHPYOAK6HYY0TdhLKqQqvl1F+1u/Ro1loga/SElz623FMyGSEeD4GNM?=
 =?us-ascii?Q?DeZOkXU92xjpiSD9DqItcJs53yYdhyGs1hgWuFNlmxs9Yv+bbQWVE7+5ue10?=
 =?us-ascii?Q?B+ixZJCTQ5h4lPyAJ4N3qP6lV5sQM4IMw1E3cPsj5gHG4gRRGJ7wFcXL0cDq?=
 =?us-ascii?Q?/4R0ScoC0e2/vRfKvwhCZ3XF4dr2L4SwjVtpGOn27NPKXPIZoSnnxB2PQfh7?=
 =?us-ascii?Q?p/UT6RPQeVMAuEG/MyG9tzyTpZDBTXR0xyM/JADjpcCODMPCDBJjnBg8U21v?=
 =?us-ascii?Q?37wTZVew/T3MgCC3QzjAcXialaGb9gjJ7iwCSgz8SQpx48GIoPSP+MJdgQ6+?=
 =?us-ascii?Q?g3u86FE2mzFtxNWmHrUPOEMXQG6V+8nOjKbBKMEI8xbiOEmCupoxQALpCyrA?=
 =?us-ascii?Q?r34352jyzgycazu3RiBlTZkFA51+4R8cdOqvCgxh7wJZTLxtNxlkeWIbTYAl?=
 =?us-ascii?Q?er4Y4kbxTF1tAua5zMgxeLwiRAG70/e9mB8T7aTiWIoifYPubLV3y43XI2V/?=
 =?us-ascii?Q?O6YM/T+zXzVMkWm53RcodlndtLCJEyJk/1Lsn9GLRDPIDmBQmmIUTBbKGOxk?=
 =?us-ascii?Q?Mo75qpZ3ruuaoAkXbitpq5CQsbfPJtwlqnPS8/zum7WextSJnhZQmrBrsCGn?=
 =?us-ascii?Q?yOnto3dgnv0gbRTRNbnvb4/kVsOG80c=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27590d99-e00b-4a5d-cc68-08da1ead5922
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 06:58:30.6068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gZSyUYuu76vJmqDNp72qAWyzObYNISfBhN4C17zUQJbBW71Yv7yHJsSsqEUa/xA6FJKICPUeIpwKR0/5x5iIarSMcjxkjpWZot7ckQTyA7w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5042
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-15_01:2022-04-14,2022-04-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 phishscore=0 mlxscore=0 suspectscore=0 malwarescore=0 mlxlogscore=880
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204150040
X-Proofpoint-ORIG-GUID: RyvPYxhecaw60YIX-R9F8jjr7vYawrzs
X-Proofpoint-GUID: RyvPYxhecaw60YIX-R9F8jjr7vYawrzs
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 15, 2022 at 02:39:27PM +0800, Haowen Bai wrote:
> This commit message suggested by Dan Carpenter as below:

You don't need to add this.  If you feel you must then put it below the
--- cut off line and it will be stored on lore.kernel.org until the end
of time.

> @@ -2292,8 +2298,8 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
>  	if (errcode) {
>  		ieee->softmac_stats.rx_auth_rs_err++;
>  		netdev_info(ieee->dev,
> -			    "Authentication response status code 0x%x",
> -			    errcode);
> +			    "Authentication response status code %d",
> +			    le16_to_cpu(errcode));

The error code is not a le16.  It's just an int.  The way to prevent
these kinds of issues in the future is to run Sparse with the endian
checking enabled.

https://lwn.net/Articles/205624/

regards,
dan carpenter