Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Yihao Han <hanyihao@vivo.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Yihao Han <hanyihao@vivo.com>, sparclinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com
Subject: [PATCH] sparc: kernel: Add missing put_device() calls
Date:   Fri, 15 Apr 2022 06:59:09 -0700
Message-Id: <20220415135910.87598-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gmsGL9V0qydiyApYe3+qejBjOq5gfLOXZLLbBwgdYT8tId/hacVmowcpPqRZ?=
 =?us-ascii?Q?R8RkXn0O+L6zAUzeBUbfG7JTco/6zRCIrTBX9vnx5riO5i4VD7FpbQxocQXv?=
 =?us-ascii?Q?5y+Mh+L0evCpKA9SonzoIGSOOAP50ia9Eee63TexHcdmYk0kVOXaDm6yC31C?=
 =?us-ascii?Q?v1xic7hd6LpP3vWyquBTM7456FpMsmACZcZgSz3b1GrKiyJXf4Dx6vlCier2?=
 =?us-ascii?Q?2Z7wAcMG2Bqtzh8og5RHqu5mcMrNnrXmDpxOH4mPKNDcACATZK6X4FdyloE2?=
 =?us-ascii?Q?znCRJlQbWUfvDfkoqQSGApDJKKVzFasuAVEu38b8CmADhDuUynICQS8Sunoa?=
 =?us-ascii?Q?59NEaxQgetTLYA+QeNFUagO9z/MRwLvoiFHa3Zf4xjO0QXOuqbJK5ZutjxvN?=
 =?us-ascii?Q?CH9RpQZMfBJ6NUX3vBxKAL8OtFmqvcRH4+/rHoSrNeymNT/VGLYs1bVDdfyD?=
 =?us-ascii?Q?JUQFoI6X/a1lFSo2IjNmTBt7JDkTkPbLm+03cXN0hYaLScstrW7M/yr/aF+c?=
 =?us-ascii?Q?2wz41kMyhdeSkxMy/0SOHGI9booZ8s1LqqBCPLnM0OZQKkB4cHS0AjGrt8Ig?=
 =?us-ascii?Q?JRSRa3/CUupdG92HKCB6DGUdOriqRus+EQZAzIkoQlvhMzykpArDfhLTTy4G?=
 =?us-ascii?Q?eMOjb0LHPVRjN76tTRc/WnHDqgAJdSGA118e/Y7amXh5YTQXD4lrFH45ZTBc?=
 =?us-ascii?Q?lCa4cw8/CKw7ZHbovCteEOVKjdhyEGSputw4JNd4PhKE26HNSzOuT6BQNjQI?=
 =?us-ascii?Q?mugitLcIkYn4WZsyCTzyS1aNz71DFacCNs35nuuTEqiGoqaaU/j4aN5nSast?=
 =?us-ascii?Q?g+/GAjz//2Fw6H84zkV4LdFKRJr+c0U8/L3IQW44pyv6jwNA+1ffY0INZ3BR?=
 =?us-ascii?Q?66hy9GPxa1utzo21b6g10gcfo/QwmFlxtz2lpFnY0pjYQPQrkZkOFJ9OepM5?=
 =?us-ascii?Q?jlUsokjVasb9/ATrkDkxvHbHyLPsf+x2BvPOnHPJzJVnHK8k6ge+4e7nz5t9?=
 =?us-ascii?Q?O45SW8XjeB9XrOoBPtrVXoxiXdK793EmMlVlzITFq5Fmn6B1sqfr/dT2VmsO?=
 =?us-ascii?Q?AxKKpumENvcPuOyAKUL4xUYn0kn5Ti31eheFk9Na6/tYNc7QgO2LnWbNbdcA?=
 =?us-ascii?Q?C9OfSiK741WeAbwKkRn930x+Fp1/6nPYsC0a/RWQB2/uOdn9Z6qRfAl+MbCn?=
 =?us-ascii?Q?ZA3zlpBcSMKObOQDXsh9+ffajjPUZrQqUhMjxNV8uxZUg4YvATg7SStHNf4b?=
 =?us-ascii?Q?JX/9b6NxbA9jyHaP9sa9y5KJ/8tkpiZopC2H2OnP8i/8RQZ8yiuxNK5RhL4x?=
 =?us-ascii?Q?kaFdshMTBSwN7ZkmcNMVEyGWj7bLsVGyaw5cbJEHFo2oH5h0BrBAaSC1Qxls?=
 =?us-ascii?Q?xApU/PXrj7mvLxpWUofDDD9qN3fRUtqkgbjfKEUSvqjg8RBhBPskNdSSF8je?=
 =?us-ascii?Q?s0UEXflxbEkc9ry2u7JmZ2Cb48QSuQSOpWUExe/pItwSJZ55/vjtVtAxVdIc?=
 =?us-ascii?Q?twI1tuulDbFXNJPvulYbj0fMGtBhmNHCKq76ERw6YiaewtM82+TIcx0DB7in?=
 =?us-ascii?Q?H7/r5c2Gx1ZyjULc5MeZDPAV0a/HCFjUhEln/GlyW4V9OA+VUL+SsNdQkS04?=
 =?us-ascii?Q?wAvPh+tWqWfcTtNo4va548jRAHbA50p2H6mF6qYGd3dj6dn/19pBYW8x4Io6?=
 =?us-ascii?Q?mgn37xBDYyLJT6b2qcggb9qWBoN5oP45oCCIr5hmk8oKk3E4/b/PutnObx+U?=
 =?us-ascii?Q?EwprujVE8A=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cae075c5-a7b6-4b4c-912f-08da1ee82631
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2022 13:59:24.9781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YtMR+6V2F9KWc97cQiDjmQUVr3a0o7e0rha/oTJWD1U4RlbL8ihk9xV8WETPIf36qGjdAFCV4LwLPTOt5kNVfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2531
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

A coccicheck run provided information like the following.

arch/sparc/kernel/pci_sabre.c:335:2-8: ERROR: missing
put_device; call of_find_device_by_node on line 324, but
without a corresponding object release within this function.
arch/sparc/kernel/pci_sabre.c:369:0-1: ERROR: missing
put_device; call of_find_device_by_node on line 324, but
without a corresponding object release within this function.

Generated by: scripts/coccinelle/free/put_device.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 arch/sparc/kernel/pci_sabre.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/sparc/kernel/pci_sabre.c b/arch/sparc/kernel/pci_sabre.c
index 3c38ca40a22b..5d0d13840ac3 100644
--- a/arch/sparc/kernel/pci_sabre.c
+++ b/arch/sparc/kernel/pci_sabre.c
@@ -331,8 +331,10 @@ static void sabre_register_error_handlers(struct pci_pbm_info *pbm)
 	 * 2: CE ERR
 	 * 3: POWER FAIL
 	 */
-	if (op->archdata.num_irqs < 4)
+	if (op->archdata.num_irqs < 4) {
+		put_device(op);
 		return;
+	}
 
 	/* We clear the error bits in the appropriate AFSR before
 	 * registering the handler so that we don't get spurious
@@ -366,6 +368,7 @@ static void sabre_register_error_handlers(struct pci_pbm_info *pbm)
 	tmp = upa_readq(base + SABRE_PCICTRL);
 	tmp |= SABRE_PCICTRL_ERREN;
 	upa_writeq(tmp, base + SABRE_PCICTRL);
+	put_device(op);
 }
 
 static void apb_init(struct pci_bus *sabre_bus)
-- 
2.17.1