Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [PATCH 1/4] kselftests: memcg: update the oom group leaf events test
From:   Roman Gushchin <roman.gushchin@linux.dev>
In-Reply-To: <20220415140817.ljznpvacne6nchg5@dev0025.ash9.facebook.com>
Date:   Fri, 15 Apr 2022 08:59:48 -0700
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, cgroups@vger.kernel.org,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Shakeel Butt <shakeelb@google.com>,
        Chris Down <chris@chrisdown.name>
Message-Id: <238226BB-6536-489A-BCC7-4611F86D036D@linux.dev>
References: <20220415140817.ljznpvacne6nchg5@dev0025.ash9.facebook.com>
To:     David Vernet <void@manifault.com>
Precedence: bulk


> On Apr 15, 2022, at 7:08 AM, David Vernet <void@manifault.com> wrote:
>=20
> =EF=BB=BFOn Thu, Apr 14, 2022 at 05:01:30PM -0700, Roman Gushchin wrote:
>> Commit 9852ae3fe529 ("mm, memcg: consider subtrees in memory.events") mad=
e
>> memory.events recursive: all events are propagated upwards by the
>> tree. It was a change in semantics.
>=20
> In one of our offline discussions you mentioned that we may want to
> consider having the test take mount options into account. If we decide to
> go that route we should probably have this testcase take memory_localevent=
s
> into account as well. If so, I'm happy to take care of that in a follow-on=

> patch after this is merged as I already have a patch locally that reads an=
d
> parses /proc/mounts to detect these mount options.

It would be great, thank you!

>> -    if (cg_read_key_long(parent, "memory.events", "oom_kill ") !=3D 0)
>> +    if (cg_read_key_long(parent, "memory.events", "oom_kill ") <=3D 0)
>>        goto cleanup;
>>=20
>>    ret =3D KSFT_PASS;
>> --=20
>> 2.35.1
>>=20
>=20
> Looks good, thanks.
>=20
> Reviewed-by: David Vernet <void@manifault.com>

Thanks!=