Received: by 2002:a19:f614:0:0:0:0:0 with SMTP id x20csp33838lfe; Fri, 15 Apr 2022 18:07:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaluUp35VN2h/Lx7v9m8yAalM+rvI3vv110OCh8IYLyavw1RIgkh/BlxV50hagYP1ljeqo X-Received: by 2002:a17:902:e891:b0:158:8b58:b94 with SMTP id w17-20020a170902e89100b001588b580b94mr1547966plg.161.1650071237420; Fri, 15 Apr 2022 18:07:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650071237; cv=none; d=google.com; s=arc-20160816; b=xoD/htekFcOScIjiz5qXRTYLZ45Jqv+x9+TTA1IzUrfsNXyxKglRIQPVEnKst5LgKw NvdWy24dyXPbNscg+uGkTmqxodYFRUQHf4RVVxACRNuQiOsVGhiqemjH3r1X7o0heoIb OfL93tLDanjO31gkGawqgK9Fqzc3FEKgGod4pbka4dAzSAGsLE93FkS2NPV/4k5Ioy80 7Nh2zRnPoXdaHDHnu15X+LqJrHqfQ+iCfJhN8hsu1Z9THQF6hUQ7JsmlGd/orTUADNuL zZD5tkGbkYcsmGmuM3xD3lfoUau3z4dZqyLPUaYX0R/kseOfgHO8rFmtlhUJpslTZ49Q 3i6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HzVzjcRD9j1mXya8X2LYskSz3F6JRUx18cbRdRK0qxc=; b=NSAfJk009FHdzHy6GlErEbxoELRsmtG+PCVG6ZZ35e59I/aeQ/LkDzuunLJpXZfdsJ 5CJQNTElGV/yR8DbL0qa+OAM0YdyFNmMwfewAHwY/F8k/pDNNLsLY1w/uF9tKl5XuoH8 O94TeknCU/nv4fqkVjHGtEbMhyWmYQxQRugrLN/tHsZ4xKKIpmh+3QjJzs7nRBlnoo6a cnm0JCaJXUflKeYnpxFl7IGJ+ddYJNmaD/xGsggFYJk2keUKRAZ3a6Co2GrQ1+8+K3B5 CnPvDQhRqYSazWZI16di/PSzq/VIyKxDv5x9XD+S1FdLorHm1MD6XwVj1wdqH5ms/XTZ 94uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VEUq2xRR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b1-20020a17090a7ac100b001cd949762ecsi5505046pjl.157.2022.04.15.18.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:07:17 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VEUq2xRR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A8C72FE437; Fri, 15 Apr 2022 17:47:49 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242668AbiDNQHj (ORCPT + 99 others); Thu, 14 Apr 2022 12:07:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351574AbiDNP5a (ORCPT ); Thu, 14 Apr 2022 11:57:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3753444A33; Thu, 14 Apr 2022 08:42:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D0718B82A70; Thu, 14 Apr 2022 15:42:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB2E7C385A5; Thu, 14 Apr 2022 15:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649950935; bh=pkfByiWfFuRJ/KrgPwqFe3DcHz82RVQhum60vPKjzsE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VEUq2xRRQvXfQjrUUpTvzE4VNKsrXB42lRgtFqzWoREZO4Q9eCj+F0Fn1CVfV9Jg4 f7NAY9ondPJlN5WuXpVCw+z00pFi6mzQtkeGieRgUpiRR4wYQXfbfeEGKhmPqUXYkl tE6gJg1yk4FJcsV9/thanwYuBcUNyLFtzwyS4zp0= Date: Thu, 14 Apr 2022 17:42:12 +0200 From: Greg KH To: Waiman Long Cc: john.p.donnelly@oracle.com, chenguanyou , dave@stgolabs.net, hdanton@sina.com, linux-kernel@vger.kernel.org, mazhenhua@xiaomi.com, mingo@redhat.com, peterz@infradead.org, quic_aiquny@quicinc.com, will@kernel.org, sashal@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v5] locking/rwsem: Make handoff bit handling more consistent Message-ID: References: <20211116012912.723980-1-longman@redhat.com> <20220214154741.12399-1-chenguanyou@xiaomi.com> <3f02975c-1a9d-be20-32cf-f1d8e3dfafcc@oracle.com> <31178c33-e25c-c3e8-35e2-776b5211200c@oracle.com> <161c2e25-3d26-4dd7-d378-d1741f7bcca8@redhat.com> <2b6ed542-b3e0-1a87-33ac-d52fc0e0339c@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 11:18:23AM -0400, Waiman Long wrote: > On 4/14/22 06:48, Greg KH wrote: > > On Tue, Apr 12, 2022 at 01:04:05PM -0400, Waiman Long wrote: > > > The patch has already been in the tip tree. It may not be easy to add a > > > Fixes tag to it. Anyway, I will encourage stable tree maintainer to take it > > > as it does fix a problem as shown in your test. > > I have no idea what you want me to do here. Please be explicit... > > > I would like the stable trees to include commit 1ee326196c66 > ("locking/rwsem: Always try to wake waiters in out_nolock path") after it is > merged into the mainline in the v5.19 merge window. It should be applied to > the stable trees that have incorporated the backport of commit d257cc8cb8d5 > ("locking/rwsem: Make handoff bit handling more consistent") since this > commit seems to make the missed wakeup problem easier to show up. Please let us know when this is merged into Linus's tree. Nothing we can do until then and I'm not going to remember this in a few months anyway. thanks, greg k-h