Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 15 Apr 2022 12:40:00 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Georgi Vlaev <g-vlaev@ti.com>
CC:     <ssantosh@kernel.org>, <mturquette@baylibre.com>,
        <sboyd@kernel.org>, <robh+dt@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/2] dt-bindings: clock: ehrpwm: Add AM62 specific
 compatible
Message-ID: <20220415174000.cnnmolsaktl7ghye@jurist>
References: <20220415134142.12141-1-g-vlaev@ti.com>
 <20220415134142.12141-3-g-vlaev@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220415134142.12141-3-g-vlaev@ti.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 16:41-20220415, Georgi Vlaev wrote:
> Introduce AM62 specific compatible for EPWM time-base
> sub-module clock. The time-base clock setup is identical
> to AM64. The only difference is AM62 provides 3 time-base
> clocks instead of the 9 found in AM64.
> 
> Signed-off-by: Georgi Vlaev <g-vlaev@ti.com>
> Tested-by: Vignesh Raghavendra <vigneshr@ti.com>

Reviewed-by: Nishanth Menon <nm@ti.com>


That said, please re-org the patches. Bindings come before the driver
changes :)

> ---
>  .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> index 9b537bc876b5..66765116aff5 100644
> --- a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> @@ -15,6 +15,7 @@ properties:
>        - enum:
>            - ti,am654-ehrpwm-tbclk
>            - ti,am64-epwm-tbclk
> +          - ti,am62-epwm-tbclk
>        - const: syscon
>  
>    "#clock-cells":
> -- 
> 2.30.2
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D