Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1015875pxb; Fri, 15 Apr 2022 18:26:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXmev4uxTKj07fmV6FZbUvfEVN+8pLc9wcxwHyQS/fSRk7XYPmLNeK2vTZizVfD0il5pfk X-Received: by 2002:a17:90b:380c:b0:1cb:a43d:4c29 with SMTP id mq12-20020a17090b380c00b001cba43d4c29mr6871308pjb.240.1650072390042; Fri, 15 Apr 2022 18:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650072390; cv=none; d=google.com; s=arc-20160816; b=f7xsdJECyhLQdC3GbqG2F1Td6H/RvcTjZIZQepQJ0lI+ZRfNm88lHZddWjljQnuDjH Hr2hHxZq0NEv2iFGQlee9O3fvpeYciC5blJUe1dzsYr1W+JDjdOVnv9cC8ZxK85LkgZj p/aRn55zTM5cHR2WAM8Qu2RcEJueg3N0/X5o8mfpHaLB5w32HtWZvuo5Mb1mgwIz6ePU ZEJ7SLK1k38gfm2mSAaaSYUb32Ij739U0MXbyPzqyuVeQZu51noFLi5p9thDA4R35QUV +wLiyHRE9yT4oAP/qX2IU4/5anWWHzP7mtcP+0a4ECGLajeWbY2slrmIgTpq8NEfab+0 ROpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=i8SW726GJn4l9wyfwUlIuTGzZbbab4SGdiSCBm6wmTs=; b=GROLpU0KSRvfAgG53hswDhumlVzgEFC42gQDwJiQcSBKhDFWWzn/UtFGXiJASe9iEL diF/jiOIFo+R+OSbKm4EzqD4konkYJ6SbrNftXm3qHb6As8NFSVAN3HD4oQsBtS1sOi+ zOCthDml5fthlL07teJDaTMIP7lnvn76bahuI6gcdpNFa/TqjfK8eBA+wUpZbi14nRPS w/3omP6/Mp5np3tKhArMbU5IcghGj/Q5eBBxb3vix+40YKN9ahL9xtQJuliRPWlMBYeo SkQupQ15unBF/cjEjFLPk3DbLp4YFLfsU0niDvEHObuEGPSkFCzWFotOFw0xkrBkgL4b yAdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=HKqTSvyk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id i7-20020a170902cf0700b0015605a7d777si2695482plg.294.2022.04.15.18.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=HKqTSvyk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EAC3F37A9A; Fri, 15 Apr 2022 17:57:41 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345723AbiDNP0z (ORCPT + 99 others); Thu, 14 Apr 2022 11:26:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348147AbiDNOCT (ORCPT ); Thu, 14 Apr 2022 10:02:19 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0752663E4 for ; Thu, 14 Apr 2022 06:59:21 -0700 (PDT) Received: from zn.tnic (p2e55d808.dip0.t-ipconnect.de [46.85.216.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8F8BF1EC0528; Thu, 14 Apr 2022 15:59:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1649944755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=i8SW726GJn4l9wyfwUlIuTGzZbbab4SGdiSCBm6wmTs=; b=HKqTSvykELA/WQ9v7czQk/OhKV3ZglpPMR5mc0FM5XQOHfg/Gg3B8L7Kjzmbl7cNBG9sBH Xk7CSx3KVxba22H9jpJG/Fq92ws5ZwNBw8QYnjyIJFUzIqhZFUGhnz6qmA/cspDacbh381 GI5VrKvnM8MoAEBbmD2Zpn5wKdhXD8s= Date: Thu, 14 Apr 2022 15:59:19 +0200 From: Borislav Petkov To: Eric DeVolder Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v7 2/8] x86/crash: Introduce new options to support cpu and memory hotplug Message-ID: References: <20220413164237.20845-1-eric.devolder@oracle.com> <20220413164237.20845-3-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220413164237.20845-3-eric.devolder@oracle.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 12:42:31PM -0400, Eric DeVolder wrote: > CRASH_HOTPLUG is to enable cpu and memory hotplug support of crash. What for? Why don't you put all that new code you're adding under an MEMORY_HOTPLUG ifdef? It seems you would need to do that when memory hotplug is enabled, anyway. Also, looking further into your patchset, you have ugly ifdeffery. Instead of that, pls add stubs for the !MEMORY_HOTPLUG case so that everything is abstracted away in the headers. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette