Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1015897pxb; Fri, 15 Apr 2022 18:26:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyLB79JiuQ4mRyAAPAYtI573VWUqN1gQZwUt+Fje7+civud2cgSRFcUqRPof5srlL3G+s9 X-Received: by 2002:a17:90b:17c6:b0:1cd:2bc4:8909 with SMTP id me6-20020a17090b17c600b001cd2bc48909mr1613935pjb.154.1650072393773; Fri, 15 Apr 2022 18:26:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650072393; cv=none; d=google.com; s=arc-20160816; b=BWN5jAcygCBtSknYWWo1T+6uy6ynnzMo4S8f/2DAy20BWEU9s+PQOTcz3l++gsU4cA lDFYdbIrv5fl+Eqhs0RYu5rBeDycWK0eC8m0Nkqbw68dY8mGn8NKUqinbzSYr3T9Z6jE DZ1lt45Pm0n1mtFNNIZWOQ5lcKz4lw2mZQk6B6EPsS+KQrph4bWQ1n5sjWrTmtIXx0G+ p36xYCwMkESM03JRvcHqn9dk0LV3KBEcWTkBJzyf0/APCRqLYy0J5pWLsVfqoxkGQl5m b42ZnULu3uVAwoGgukMlU21OFfwBoWfkfBCDxgWEl468E5UAboEO979lK9qVeAsm3TLE M2qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=a9g9Py9KrIygzXA+D7nZBmZ+mNzn1Yv8mrhsxKLGix0=; b=OUQvB3IausBb5Pc+fJWzIXrEqE1dz7bpmGoWmJj5axl52EEcp/jPao7rQYOpmbEcmf GVDWfDtxClel3L8xS5vriPwPppT3n7OnkUp5lmJr2xi4Dj3FnVCaGxjnDHICHSv7+yw/ HWqocE55W7OBsaavr9ud8ucvZQGF+/ytJ44Fo9ZO0N9hSKn/Id0Ej0wgLkov0E7OpAvC vTBsFMYJTkIykdaNToBnVMZGt8qBQDYR/Ks+NLaWfQGtEQl/hEukMPsgvPa1xHfpxH8i repnulpcvHa0pNcIf8hdjEVNYMjsGAFbcfPecZKK87GTxMaVEaiu3BO34w5/kdgVyOak bhqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=a9unpxl4; dkim=neutral (no key) header.i=@linutronix.de header.b=wpn1rSfG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a3-20020a656543000000b0039b6216b577si2606192pgw.708.2022.04.15.18.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:26:33 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=a9unpxl4; dkim=neutral (no key) header.i=@linutronix.de header.b=wpn1rSfG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B34EB140760; Fri, 15 Apr 2022 17:57:45 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353560AbiDOVw6 (ORCPT + 99 others); Fri, 15 Apr 2022 17:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbiDOVuu (ORCPT ); Fri, 15 Apr 2022 17:50:50 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69A0362C92 for ; Fri, 15 Apr 2022 14:48:21 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1650059299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9g9Py9KrIygzXA+D7nZBmZ+mNzn1Yv8mrhsxKLGix0=; b=a9unpxl4SkOIavCFJUr9CagNlQmEF0mpIjXS9vgvddEzlbs0TqMH2qnBnvJ74PzQBYyMCK x71TMzSrGfiGlRwnEinLLHoGSMIe8e3DDe477E0StNIcFYFO+eWRq7apLOn3NVceeGWsIv xgM4ftAL6S2d0w070vNtCmwDE3TLaI/e8me65SfkEZ8PjIVcZWnyZrYFfUhYrYxJso7tLM O19muZ1CCxn01S3s/OBDDcHE7R5SybX4aeUbXAbM6IilaRiYdHOFkPTrwmuFFFkZcSZXhQ Dym8gLrfe+jObr4dsOpRYk3FIl8UTKUYfTMqZsubk4qBrn/oZMefVO78vGSnEg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1650059299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9g9Py9KrIygzXA+D7nZBmZ+mNzn1Yv8mrhsxKLGix0=; b=wpn1rSfGfELbdE1qTywpJe90viKOv5tjsU/vt0b1WZN8hD1qL7Y5/jFtI71fLSLG6DkD4y POJfc2F1G48n5TBQ== To: Peter Zijlstra Cc: LKML , John Stultz , Stephen Boyd Subject: Re: [patch 2/3] timekeeping: Mark tk_clock_read() __always_inline In-Reply-To: References: <20220415091223.187169221@linutronix.de> <20220415091921.014937522@linutronix.de> Date: Fri, 15 Apr 2022 23:48:18 +0200 Message-ID: <87mtgm9fx9.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15 2022 at 14:09, Peter Zijlstra wrote: > On Fri, Apr 15, 2022 at 11:19:36AM +0200, Thomas Gleixner wrote: >> Compilers can uninline this which makes the notrace annotation of the NMI >> safe accessors moot. > > inline already implies notrace. Bah. Confused myself vs. noinstr. We have too many constraints... > No objection to making it __always_inline, but this reason doesn't > really work. Let me come up with a more coherent argument. Thanks, tglx