Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Fri, 15 Apr 2022 06:48:52 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        kernel test robot <lkp@intel.com>,
        Arnd Bergmann <arnd@arndb.de>, Takashi Iwai <tiwai@suse.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v3] sound/oss/dmasound: fix build when drivers are mixed
 =y/=m
Message-ID: <20220415134852.GA2271702@roeck-us.net>
References: <20220405234118.24830-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220405234118.24830-1-rdunlap@infradead.org>
Precedence: bulk

On Tue, Apr 05, 2022 at 04:41:18PM -0700, Randy Dunlap wrote:
> When CONFIG_DMASOUND_ATARI=m and CONFIG_DMASOUND_Q40=y (or vice versa),
> dmasound_core.o can be built without dmasound_deinit() being defined,
> causing a build error:
> 
> ERROR: modpost: "dmasound_deinit" [sound/oss/dmasound/dmasound_atari.ko] undefined!
> 
> Modify dmasound_core.c and dmasound.h so that dmasound_deinit() is
> always available.
> 
> The mixed modes (=y/=m) also mean that several variables and structs
> have to be declared in all cases.
> 
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202204032138.EFT9qGEd-lkp@intel.com
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org
> ---

m68k:allmodconfig fails to build with this patch in the tree.

Error log:
sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used

... because __setup() is empty if MODULE is defined.

Guenter