Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 14 Apr 2022 12:53:51 -0500
From:   Rob Herring <robh@kernel.org>
To:     Peter Geis <pgwipeout@gmail.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Simon Xue <xxm@rock-chips.com>,
        linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: pci: remove fallback from Rockchip
 DesignWare binding
Message-ID: <Ylhfr51RME+YAjOG@robh.at.kernel.org>
References: <20220413133731.242870-1-pgwipeout@gmail.com>
 <20220413133731.242870-2-pgwipeout@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220413133731.242870-2-pgwipeout@gmail.com>
Precedence: bulk

On Wed, Apr 13, 2022 at 09:37:28AM -0400, Peter Geis wrote:
> The snps,dw-pcie binds to a standalone driver.
> It is not fully compatible with the Rockchip implementation and causes a
> hang if it binds to the device.
> 
> Remove this binding as a valid fallback.
> 
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> ---
>  Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> index 142bbe577763..8dc11fed8a3c 100644
> --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> @@ -32,7 +32,6 @@ properties:
>    compatible:
>      items:
>        - const: rockchip,rk3568-pcie
> -      - const: snps,dw-pcie

With this, you no longer need 'select' so please drop it too.

>  
>    reg:
>      items:
> @@ -110,7 +109,7 @@ examples:
>          #size-cells = <2>;
>  
>          pcie3x2: pcie@fe280000 {
> -            compatible = "rockchip,rk3568-pcie", "snps,dw-pcie";
> +            compatible = "rockchip,rk3568-pcie";
>              reg = <0x3 0xc0800000 0x0 0x390000>,
>                    <0x0 0xfe280000 0x0 0x10000>,
>                    <0x3 0x80000000 0x0 0x100000>;
> -- 
> 2.25.1
> 
>