Received: by 2002:a19:f614:0:0:0:0:0 with SMTP id x20csp41710lfe; Fri, 15 Apr 2022 18:29:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrtnBRuoIP4emUAofbvoC9+lGdSxHcmCMT/ZVOP0kimOZeYClDT3InqzFtveuo3Dya5yG5 X-Received: by 2002:a17:902:7b94:b0:158:94be:c658 with SMTP id w20-20020a1709027b9400b0015894bec658mr1643616pll.36.1650072565791; Fri, 15 Apr 2022 18:29:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650072565; cv=none; d=google.com; s=arc-20160816; b=w7yPOgIa69a3K08LZatxF0u1wqBKBuyMXmRTvqbkdrFoIvwH4ASIiktGZElLau6BHG Ru5hqB9JcJygsqciMLj+JOxpPwAyl1nFBs5NtCLWnsHQWqpZ8lRHERZ+epR0mM8nYjl1 LpbNcnvKtHavVfgoTN/GemMSRqL8HoZ6PfnsZfFNINPkcas7uaTgbn1ZPWB68YkfLxpp iIpAcwpOP9oSP014Lrty55FMsQUuS4OvEfzUz3kqpeMSVXDkdO/Qrf6icBTGL4hDvRjX /bfZc6GOtD0RpjrC4Hd4z4rI+a5DHhSSxAzhNa2jPa+kec84CX0WegSs5aXlejDKdVH6 dZJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=XgqD9AXasDKD1T8TAQ+9zj+n+jRgf2CDLrBq0xn+hQU=; b=Jp1egH8UsBE8WRnhVIfTxInCr9JHh+lOVQRCGFR/5WDf7nD8J3rmgQ5b0PjG8+NeF+ wqIdoDZwUgsizM7w5zul9lEFpdTp2BOi9DbeLGr802zP1f8bmb03+SmMafaInkFZdhWP DMQmE4XnHMGLAC2BHTf9vl+TMnUg7NO96nRgRpVwNEpyH+C/XbP77616Ut59kwUs/HF7 lkhFXLcR20MLXZEK56Q3bKC2ot4/yBo3KX+ZD9xHpSnVXBdQ70/UjhZmXR3ScvlrP6pQ A8iY10O5W7+6CljVSDrOhNwx9CmoUwHpc5qfM8MsSPshRTJBOcz5XDU9sX2OmkJd9VdG U9WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gNiau/O2"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id m9-20020a170902768900b0015833d93f52si2513354pll.66.2022.04.15.18.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:29:25 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gNiau/O2"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B93B1149D20; Fri, 15 Apr 2022 17:59:22 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235162AbiDMLcj (ORCPT + 99 others); Wed, 13 Apr 2022 07:32:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232440AbiDMLcg (ORCPT ); Wed, 13 Apr 2022 07:32:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 745F52AC6F; Wed, 13 Apr 2022 04:30:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57F6861DC6; Wed, 13 Apr 2022 11:30:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id AB5E6C385B3; Wed, 13 Apr 2022 11:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649849412; bh=dx7OUX8/yekR+5yZ3BY30eSyyVdl4N1P7VEeD7kiFeE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=gNiau/O2B3bWi89MNgvZK6Pg8+zNFYhixJtWOmqHdX1uyxz06R2KoiHgumx0sjt1/ YcnJddWnfp4FWVavEyzc1tzoXrtRKrn9mWphGDFxH2sfOdDlu6PvndSZFF4V9ET7j4 ArARo02UOSzSN0Y3+hQzy9CqJRyzZutOJi0Tse+G0fy7NLYHmYmfRsUSy2RRBalyA2 1AdSJcd5+Jv5QwLNjZAkYucJ/VODyDnxZQXSBnKoZw7V0wDs9rXRB+4A5aZg/sQIu+ zAZEaDSpMQ+OA93bFLDE0hyuBv1R/ecuCW05jOZDLuL1k99kRBuwfwUusav1lgcyt2 CumZKKx6RMhqA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 8F4A1E8DD67; Wed, 13 Apr 2022 11:30:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] NFC: NULL out the dev->rfkill to prevent UAF From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164984941258.14313.4753120813378621079.git-patchwork-notify@kernel.org> Date: Wed, 13 Apr 2022 11:30:12 +0000 References: <20220412053208.28681-1-linma@zju.edu.cn> In-Reply-To: <20220412053208.28681-1-linma@zju.edu.cn> To: Lin Ma Cc: krzk@kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Tue, 12 Apr 2022 13:32:08 +0800 you wrote: > Commit 3e3b5dfcd16a ("NFC: reorder the logic in nfc_{un,}register_device") > assumes the device_is_registered() in function nfc_dev_up() will help > to check when the rfkill is unregistered. However, this check only > take effect when device_del(&dev->dev) is done in nfc_unregister_device(). > Hence, the rfkill object is still possible be dereferenced. > > The crash trace in latest kernel (5.18-rc2): > > [...] Here is the summary with links: - NFC: NULL out the dev->rfkill to prevent UAF https://git.kernel.org/netdev/net-next/c/1b0e81416a24 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html