Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <8e20d9af-bbe3-ad57-e131-4107f4b16051@redhat.com>
Date:   Fri, 15 Apr 2022 15:47:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RFC PATCH v5 024/104] KVM: TDX: create/destroy VM structure
Content-Language: en-US
To:     Isaku Yamahata <isaku.yamahata@gmail.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jim Mattson <jmattson@google.com>,
        erdemaktas@google.com, Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <36805b6b6b668669d5205183c338a4020df584dd.1646422845.git.isaku.yamahata@intel.com>
 <aa6afd32-8892-dc8d-3804-3d85dcb0b867@redhat.com>
 <20220408005116.GB2864606@ls.amr.corp.intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20220408005116.GB2864606@ls.amr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/8/22 02:51, Isaku Yamahata wrote:
>> Please rename the function to explain what it does, for example
>> tdx_mmu_release_hkid.
> In the patch 021/104,  you suggested flush_shadow_all_private().
> Which do you prefer? flush_shadow_all_private or tdx_mmu_release_hkid.

vt_mmu_prezap should become vt_flush_shadow_all_private.

tdx_mmu_prezap should be come tdx_mmu_release_hkid.

Paolo