Received: by 2002:a19:f614:0:0:0:0:0 with SMTP id x20csp44849lfe; Fri, 15 Apr 2022 18:38:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5lzrlVhM2iqV/MsktFj/IPLjpZDveIADd82B69Xx4hFQ51anXwzTwfLK++oUI02Q6ezmA X-Received: by 2002:a63:1f4c:0:b0:3a2:8b3d:a5d7 with SMTP id q12-20020a631f4c000000b003a28b3da5d7mr1285009pgm.466.1650073133606; Fri, 15 Apr 2022 18:38:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650073133; cv=none; d=google.com; s=arc-20160816; b=KH1tDYPqBKRCEyHuo623yplrT99u50aAtNYhG+EFaT4Ra+ZIwGPkhFZAhRcqlz8PZu 6y6Con1EVChp6V12Q9yEvnnaeJwvBwhz66AQCy2JzdrdlHysCxZBUfxL+d6pjQJkDh2q cqCJxSEZL7PGvPYj15siqB583in/T6Hfx9z3wqGqgPTBIlIQmzqCIUqIds4m/FFnsnp7 Eg2xqpyHj6sovrfZsS3tldmCW9ozoWacCuMp/BnGBSH9yS8dPgcJb5WnZBlxByZYuRIE gt7X4nW0SF+BVr8Ene0o2nF3Bbu6qoQscstQEuGRB+sZEz3LEEkXYlaZgiVipoceoLfx pMOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=noWWiVLpEJoThugg8Q2sCmImgY4XdCfFhEBVel656pk=; b=kbUSIeP+VzRqrJ0UyDLrx2Pc2lS9NmzBN5Z8DYN8glgHAYzWGSMfK3X22no3xhrwTz Gxy0kJGcJnpMB0AVAgHbcs+ubdE3Co/yy2dYifi7x0ffLkWeLbnemKMC4e1Jkm6jjDWE hKi5hxO6156ejUbc1Yi3KTy9SWoK18bQoZUBSXoE5uOF/LPql0FRDwXC8/Za1oFxxmt0 Ys97QfAHdcas4vgkD2jkKmNbQTudAZnQ3FFhDoDCLvS+22M5YFEN+y/n4y41YKWr32KY vXGtRlVbMmyfMu4ZyrrwN0b5mzZZAt8x11bMAPr6M36hZGHDhEi9NpIvfOZakcjWhbYA W4qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=R+xxBPeZ; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id n13-20020a170903110d00b00153f463a7e2si2854133plh.126.2022.04.15.18.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:38:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=R+xxBPeZ; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0A0671606BE; Fri, 15 Apr 2022 18:04:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351711AbiDOJWL (ORCPT + 99 others); Fri, 15 Apr 2022 05:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236043AbiDOJWI (ORCPT ); Fri, 15 Apr 2022 05:22:08 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54C881A3AD for ; Fri, 15 Apr 2022 02:19:37 -0700 (PDT) Message-ID: <20220415091920.956045162@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1650014375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=noWWiVLpEJoThugg8Q2sCmImgY4XdCfFhEBVel656pk=; b=R+xxBPeZnUu0Sr99Y+kIAv5+gNnFVafzMvgCt0b+0Zf9VZjHK906ZcpZ8wvegz25nRYY89 6TjPIaVpWwp9/e4zExnjsGyOawokOVF8KoheErZVkuYKWikNhEzhw7YMAqx0PBM+x4IGCP /kJvVtVMpt1AsPIUeoPDWdEepcA1zt/xUDwa7nVfDBNtDrG5mTPHkKGBdScb0xIyILflvS gQXgrmESjxu6qCX3h0ctEKcjDB4RBP/aliP6kDubNMz3cRc0G/lymIx3UWZgnS4B2P1/dn jN2VIe7bRlvDbIvBZmX3aSe20iqc8bgxtKICuHfY2LZboPH7imoxEccxysuXOA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1650014375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=noWWiVLpEJoThugg8Q2sCmImgY4XdCfFhEBVel656pk=; b=4uaoWYVBWKwpB2oDj7eU0kUNuQuDmfn4t9+DRjlqOOA2tmKQayum2Aryrd93/1Ql2iuSLy aWOVbbjdp9JI95Aw== From: Thomas Gleixner To: LKML Cc: Peter Zijlstra , John Stultz , Stephen Boyd Subject: [patch 1/3] timekeeping: Annotate ktime_get_boot_fast_ns() with data_race() References: <20220415091223.187169221@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Fri, 15 Apr 2022 11:19:35 +0200 (CEST) X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Accessing timekeeper::offset_boot in ktime_get_boot_fast_ns() is an intended data race as the reader side cannot synchronize with a writer and there is no space in struct tk_read_base of the NMI safe timekeeper. Mark it so. Signed-off-by: Thomas Gleixner --- kernel/time/timekeeping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -528,7 +528,7 @@ u64 notrace ktime_get_boot_fast_ns(void) { struct timekeeper *tk = &tk_core.timekeeper; - return (ktime_get_mono_fast_ns() + ktime_to_ns(tk->offs_boot)); + return (ktime_get_mono_fast_ns() + ktime_to_ns(data_race(tk->offs_boot))); } EXPORT_SYMBOL_GPL(ktime_get_boot_fast_ns);