Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <b7b8c467-ccb2-913b-66b6-e02e081577e2@linux.intel.com>
Date:   Fri, 15 Apr 2022 10:59:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 03/14] perf vendor events intel: Add sapphirerapids events
Content-Language: en-US
To:     "Liang, Kan" <kan.liang@linux.intel.com>,
        Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Andi Kleen <ak@linux.intel.com>,
        John Garry <john.garry@huawei.com>,
        James Clark <james.clark@arm.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
References: <20220413210503.3256922-1-irogers@google.com>
 <20220413210503.3256922-3-irogers@google.com>
 <368c5b92-f035-41cc-96a8-4908f1325462@linux.intel.com>
 <CAP-5=fWpECOtC8jc6up4LRFon1v0DBN1Y6LJsimEtuPfXcvJuA@mail.gmail.com>
 <28285c3a-a577-14ca-5e88-6101217ea73f@linux.intel.com>
From:   Xing Zhengjun <zhengjun.xing@linux.intel.com>
In-Reply-To: <28285c3a-a577-14ca-5e88-6101217ea73f@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/15/2022 2:25 AM, Liang, Kan wrote:
> 
> 
> On 4/14/2022 12:36 PM, Ian Rogers wrote:
>> On Thu, Apr 14, 2022 at 8:03 AM Liang, Kan <kan.liang@linux.intel.com> 
>> wrote:
>>>
>>>
>>>
>>> On 4/13/2022 5:04 PM, Ian Rogers wrote:
>>>> Events were generated from 01.org using:
>>>> https://github.com/intel/event-converter-for-linux-perf
>>>>
>>>> Signed-off-by: Ian Rogers<irogers@google.com>
>>>> ---
>>>>    tools/perf/pmu-events/arch/x86/mapfile.csv    |    1 +
>>>>    .../arch/x86/sapphirerapids/cache.json        | 1083 ++++++++++++++
>>>>    .../x86/sapphirerapids/floating-point.json    |  218 +++
>>>>    .../arch/x86/sapphirerapids/frontend.json     |  471 ++++++
>>>>    .../arch/x86/sapphirerapids/memory.json       |  415 ++++++
>>>>    .../arch/x86/sapphirerapids/other.json        |  329 +++++
>>>>    .../arch/x86/sapphirerapids/pipeline.json     | 1271 
>>>> +++++++++++++++++
>>>>    .../x86/sapphirerapids/virtual-memory.json    |  225 +++
>>>
>>> Thank you very much Ian for the patches. They all looks good to me.
>>>
>>>       Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
>>>
>>> BTW: I think the uncore events for SPR are also published in 01.org.
>>> Do you have plan to add them later?
>>
>> Thanks Kan, we need to add the csv file to the github project to make
>> this work. I can make a basic one if that works?
>>
> 
> I think Zhengjun may already have one. Zhengjun?

The CSV file for SPR has been added to the event convert tool, please 
have a try.
> 
> Thanks,
> Kan

-- 
Zhengjun Xing