Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1026882pxb; Fri, 15 Apr 2022 18:48:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXb8mi940vmaBgqxtNNw/7xyinnA9s9KrqNboKNcyTttsxg5qrJu4Wc9H4fNp5qVnyPDps X-Received: by 2002:a17:90a:8594:b0:1cd:5dc1:396b with SMTP id m20-20020a17090a859400b001cd5dc1396bmr7125447pjn.69.1650073732694; Fri, 15 Apr 2022 18:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650073732; cv=none; d=google.com; s=arc-20160816; b=TrEcE5dPfFfserkO+X9ySSeFROo8QCoz+U5TnD7EUzWmr6QJmh/hzDB+/5tGVr4Mwd a+fweYv0eNUZKXpBepXfjAzVnMOSEq5iW6v4bpadrGEWbmZFykrM6r6E0NIro+a9JPCB cyGay6OX3RtX3JWKrsDSSpy1jixp2PGJocPXFvRtTBcfgCfJOXUki8c8DECUVq/IQ7Jm Dsz6Qbjbngd3Dko3hoiBBwRZrbVr48eN3q9qEnvkdrZMfMLsKgn1FCnG/6usCM2zUeIa 1S3KwQpwYe7eilH+yka/JVg7A9DrrftziGm6BWIcKc8D5A5XiTJY5iFPetXnEW6vUbsw aUbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zNVMX8NcNSJANsMrPK1qYmRcgS3LCmV3Ez+QKRQXbos=; b=Cfowbc83GepspPbs/aqnGrqOxITBQfN0nrtP5NQmMDn2UFxRmA6EsY22PxIazTLXId L5jBsvmE6kZDf8tfwurzWgUZz9zD5LE6+nCXCf2yanYRhd4yg/WPa/Y/sKiz8aBcjNB8 edvBcKw+uAP1Y/mSBggFsf73btWO4iDHhaJfH16RzZlgOzlNG58fxQEPwz98qjIG2/T+ pqHl32mUpT6F49bjDYOg4HWqjA3z3uTzjhMcTpvmJ4sKk/qLez3paCEfPOIHWliKcf0y 4sAGghMLIE1XSpkQopuKUHH364BAch6Y6ood3HNBJ0vaP3bwQjfUs09rQUDcqaErTCVW zGJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TlQ0Oy4c; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id x4-20020aa793a4000000b004fa3a8e003asi2692974pff.241.2022.04.15.18.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:48:52 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TlQ0Oy4c; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3DE8E183832; Fri, 15 Apr 2022 18:11:38 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244321AbiDNNZx (ORCPT + 99 others); Thu, 14 Apr 2022 09:25:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244176AbiDNNXo (ORCPT ); Thu, 14 Apr 2022 09:23:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3657492859; Thu, 14 Apr 2022 06:18:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C82236132E; Thu, 14 Apr 2022 13:18:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCBB9C385A1; Thu, 14 Apr 2022 13:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649942303; bh=aiie2cvjnArLZvqbUIwql61WUvJ64nqylGwE/sTHu4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TlQ0Oy4cv0XDPqhgULDFWxTWOX3rSbpilMFzXr2Kn70rkzvzS5Mykia45Hg1xY+zg owYCsAIA2OzpHvoo+uBwXkHgG8rOiTVgx5fSzYssZYohQeUzKyReUpQN/SZTa5AVa1 SIXnwH1sRqUdkb44oubK+5r5p2Xr6ya5wC5qapTE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 087/338] media: coda: Fix missing put_device() call in coda_get_vdoa_data Date: Thu, 14 Apr 2022 15:09:50 +0200 Message-Id: <20220414110841.375502941@linuxfoundation.org> X-Mailer: git-send-email 2.35.2 In-Reply-To: <20220414110838.883074566@linuxfoundation.org> References: <20220414110838.883074566@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit ca85d271531a1e1c86f24b892f57b7d0a3ddb5a6 ] The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: e7f3c5481035 ("[media] coda: use VDOA for un-tiling custom macroblock format") Signed-off-by: Miaoqian Lin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index fccc771d23a5..5f8da544b98d 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -376,6 +376,7 @@ static struct vdoa_data *coda_get_vdoa_data(void) if (!vdoa_data) vdoa_data = ERR_PTR(-EPROBE_DEFER); + put_device(&vdoa_pdev->dev); out: if (vdoa_node) of_node_put(vdoa_node); -- 2.34.1