Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for
 resource table
Thread-Topic: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for
 resource table
Thread-Index: AQHYRNqqPUw/yuiN8kyJqdOjFsHRtKzvqn2AgACw7nA=
Date:   Fri, 15 Apr 2022 02:47:38 +0000
Message-ID: <DU0PR04MB941769592D17F5E590803B3C88EE9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220331084007.2323377-1-peng.fan@oss.nxp.com>
 <20220414161003.GA698343@p14s>
In-Reply-To: <20220414161003.GA698343@p14s>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h+oxFfGJjTq4AMI4TR34+/y2B5r245MmL8RA37Aoxy1dB9Q45L1R1glzQMRo?=
 =?us-ascii?Q?6T0zX50uceLBY2FOvcd/yRlwpL6sXM4gTQQY/58ofyKS1dGqC08vvmg6ORpu?=
 =?us-ascii?Q?f/fd/iaZEfEn9y3krxlaO4enc9IQaPzZPQo7bhhsK+Hr+c412954cx4Hz+Cd?=
 =?us-ascii?Q?vF3t4tm1EwhmKY5VFeJkam1Y4d9JiDX3FK1BmwluSmGrNvbcaaILNChupt6P?=
 =?us-ascii?Q?RCt2JT/M3rULSCWCFlBM9NsvNxervWs/VEvY7j+zQ+YSmjX1ahRTFjoKcrIK?=
 =?us-ascii?Q?vYcAMms7D4uNcdEslTSrU355ZbUYKT6O7g1Um4v9rjxbtW/AupU2dP01anIl?=
 =?us-ascii?Q?GWNMAFdhz6yEqatRIDVR+tkmZbmh1QxmaLsIlx2ZdlENAJXL8XkjCPR1KGeq?=
 =?us-ascii?Q?aO9pkIm+Gi5blz00EVLv8Efwioa4htgiYluXFXVyqPFz4cBzA4V2tjI9COyS?=
 =?us-ascii?Q?8Xla+a/kF7fPBhIrlNbdFq2rxaEoBqQbFTb4bP96X8cuqWIZCzVjwLc9nljt?=
 =?us-ascii?Q?mcnZqWedgPaECnuH5nr/ywQGBqdM2UR6xMO58sGWq1dlfiJvYMZ42O191f73?=
 =?us-ascii?Q?4cROA3505NBagZP4B84oE214WhQjBe5je3TYxMjK9KTHIjQvFrzPOsY0eaZJ?=
 =?us-ascii?Q?l4a+vR0WtItSIdKy0+cYNPldu49Bx8YPTPwDQRSIb4RGdSpXGReb9fjJjeSj?=
 =?us-ascii?Q?psdLRz/QKpf2NS8aLBgqEMN6rULAqgijf5hrrbAaQUEdSFCKYwh8zW88oFrc?=
 =?us-ascii?Q?EiHJ/RMdvjdGfHNfA8oi+A6zV7l/dDn0yxl/JeWhFNOzzlpxPhaN7g4IGZ+4?=
 =?us-ascii?Q?YyxZT3VhN/tqxwzxDBUnpmwR6LIwbFjgI0rvXTW8KJtHCrQDUDRwfpepfAem?=
 =?us-ascii?Q?SH5vCACF8kgMWlghOfWOWnxWDc1cqShB4zgTiEr7ocvyUD3gCKLTAKmtBk6z?=
 =?us-ascii?Q?fX5WHUlnDvCQ9sKc6x2pLSAJ7YyGYQcQ5agB5T1MT9bZ/MCIjGB/f8tAbUS5?=
 =?us-ascii?Q?fcTzuIZ0jRLY6WmqQlRBwxf5aid50Ph7iZXVL1jNDyqQFUINw8oOpNbA7FKV?=
 =?us-ascii?Q?K/aEUKvlDUfHu21R1wyetxKvQZXbNc50fOhnntbgI+moFjRXg9nXmiuhi+J4?=
 =?us-ascii?Q?qW8n7Wtlr8yQxOOB1nKDm3UhyethD7N0duYs60gDSsHxEljtA//Pv0Q3Pgbp?=
 =?us-ascii?Q?kFRarM0ISb+Z2za/NSjIYuZiaqQjc79zyKM4aYHGEyVgcX5zVmEkqSZV9s7n?=
 =?us-ascii?Q?WLBW/18UZoL9nH1tdD2NyfoONxpYl3Zoes/919ZRR4JKqOJMX2JIqrG4gtwX?=
 =?us-ascii?Q?Zxc1WmhG5U6TS8wKmZTG9IRChIWjoLstVlQ4oMbbnfc3Jfm2XOA4n8Hg1bRO?=
 =?us-ascii?Q?rS/ct4LPHv9J0Md25CthmOx5ZRMNUjcy3TJFRVIsvnCGR9pFd9oM2a5H0ass?=
 =?us-ascii?Q?zDCCJs8WZn1g7ZmzfNIYCLDDc7kxj941nVP7CR0H83njGbTKVPZ62UWyni2Y?=
 =?us-ascii?Q?KApZiP52SExMkbYZNgz+9Ixi8bkzpQ5rFZijU0SW20EnzP3wToOt8bMf2asm?=
 =?us-ascii?Q?FObQW4BJZl1CCHn81DqHOla5RfiLjJN1YINRBRqVd8v+PKrlw0IQc/LJkEPZ?=
 =?us-ascii?Q?vCWhdv4shmafqLxjpA+pXasNtZ+lJGQ7k18BsOJNkeLoOuoylzqg9/3gt2il?=
 =?us-ascii?Q?FrAl1t5TZRhANHyBOhNbgmZSYBZMkVOjedQzXrHOgTK94weE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b20066a-cc7c-4e7b-56b8-08da1e8a4dd0
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 02:47:38.4759
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xF2wukaUuRmzPvOa+TSrHIxSAXtkFAMVMch7ukxEB1abMRt0pOEqvC9ZK7IcMxTYls1n77GT3nHm8okApXtjiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7109
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry fo=
r
> resource table
>=20
> On Thu, Mar 31, 2022 at 04:40:07PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Resource table is used by Linux to get information pubished by
>=20
> s/pubished/published

Fix in v4.

>=20
> > remote processor. It should be not be used for memory allocation, so
> > not create rproc mem entry.
> >
> > Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse
> > fw hook")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V3:
> >  Update commit log
> >  Update Fixes tag
> >
> > V2:
> >  Add Fixes tag
> >  Separate the patch from
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat=
c
> > hwork.kernel.org%2Fproject%2Flinux-
> remoteproc%2Fpatch%2F20220111033333
> > .403448-7-
> peng.fan%40oss.nxp.com%2F&amp;data=3D04%7C01%7Cpeng.fan%40nxp.
> >
> com%7C091803e93988488b2cbc08da1e313fe7%7C686ea1d3bc2b4c6fa92cd99c
> 5c301
> >
> 635%7C0%7C0%7C637855494116073554%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wL
> >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;s
> data
> >
> =3DTDWgH8DNxGTQsen64f6Bqvr5t%2FmB7bA8qOF6Q9TlP34%3D&amp;reserved=3D
> 0
> >  Address typo
> >
> >  drivers/remoteproc/imx_rproc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> >  		if (!strcmp(it.node->name, "vdev0buffer"))
> >  			continue;
> >
> > +		if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > +			continue;
> > +
>=20
> Any reason the handling of vdev0buffer is using strcmp() and the resource=
 table
> strncmp()?

I thought rsc-table0/1 maybe there for cm40/cm41, but rsc-table should also=
 be
ok, will use strcmp in v4.

Thanks,
Peng.

>=20
> Thanks,
> Mathieu
>=20
> >  		rmem =3D of_reserved_mem_lookup(it.node);
> >  		if (!rmem) {
> >  			dev_err(priv->dev, "unable to acquire memory-
> region\n");
> > --
> > 2.25.1
> >