Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 14 Apr 2022 09:11:40 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        John Garry <john.garry@huawei.com>,
        James Clark <james.clark@arm.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 01/14] perf vendor events intel: Fix icelake cstate
 metrics
Message-ID: <YlgPfGlbnsmd6RJW@kernel.org>
References: <20220413210503.3256922-1-irogers@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220413210503.3256922-1-irogers@google.com>
Precedence: bulk

Em Wed, Apr 13, 2022 at 02:04:50PM -0700, Ian Rogers escreveu:
> Apply cstate fix from:
> https://github.com/intel/event-converter-for-linux-perf/
> so that metrics for cstates that exist on the particular architecture
> are generated. This corrects issues with metric testing.
> 
> Also correct topic of ASSISTS.ANY event.

I would really appreciate acks/reviewed-by tags for these,

Thanks!

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  .../arch/x86/icelake/icl-metrics.json         | 24 ++++++++++++++-----
>  .../pmu-events/arch/x86/icelake/other.json    | 14 +----------
>  .../pmu-events/arch/x86/icelake/pipeline.json | 14 ++++++++++-
>  3 files changed, 32 insertions(+), 20 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/arch/x86/icelake/icl-metrics.json b/tools/perf/pmu-events/arch/x86/icelake/icl-metrics.json
> index 4af23c04dc18..ea73bc1889ba 100644
> --- a/tools/perf/pmu-events/arch/x86/icelake/icl-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/icelake/icl-metrics.json
> @@ -408,12 +408,6 @@
>          "MetricGroup": "Branches;OS",
>          "MetricName": "IpFarBranch"
>      },
> -    {
> -        "BriefDescription": "C3 residency percent per core",
> -        "MetricExpr": "(cstate_core@c3\\-residency@ / msr@tsc@) * 100",
> -        "MetricGroup": "Power",
> -        "MetricName": "C3_Core_Residency"
> -    },
>      {
>          "BriefDescription": "C6 residency percent per core",
>          "MetricExpr": "(cstate_core@c6\\-residency@ / msr@tsc@) * 100",
> @@ -449,5 +443,23 @@
>          "MetricExpr": "(cstate_pkg@c7\\-residency@ / msr@tsc@) * 100",
>          "MetricGroup": "Power",
>          "MetricName": "C7_Pkg_Residency"
> +    },
> +    {
> +        "BriefDescription": "C8 residency percent per package",
> +        "MetricExpr": "(cstate_pkg@c8\\-residency@ / msr@tsc@) * 100",
> +        "MetricGroup": "Power",
> +        "MetricName": "C8_Pkg_Residency"
> +    },
> +    {
> +        "BriefDescription": "C9 residency percent per package",
> +        "MetricExpr": "(cstate_pkg@c9\\-residency@ / msr@tsc@) * 100",
> +        "MetricGroup": "Power",
> +        "MetricName": "C9_Pkg_Residency"
> +    },
> +    {
> +        "BriefDescription": "C10 residency percent per package",
> +        "MetricExpr": "(cstate_pkg@c10\\-residency@ / msr@tsc@) * 100",
> +        "MetricGroup": "Power",
> +        "MetricName": "C10_Pkg_Residency"
>      }
>  ]
> diff --git a/tools/perf/pmu-events/arch/x86/icelake/other.json b/tools/perf/pmu-events/arch/x86/icelake/other.json
> index 08f6321025e8..2e177f95a9cb 100644
> --- a/tools/perf/pmu-events/arch/x86/icelake/other.json
> +++ b/tools/perf/pmu-events/arch/x86/icelake/other.json
> @@ -1,16 +1,4 @@
>  [
> -    {
> -        "BriefDescription": "Number of occurrences where a microcode assist is invoked by hardware.",
> -        "CollectPEBSRecord": "2",
> -        "Counter": "0,1,2,3,4,5,6,7",
> -        "EventCode": "0xc1",
> -        "EventName": "ASSISTS.ANY",
> -        "PEBScounters": "0,1,2,3,4,5,6,7",
> -        "PublicDescription": "Counts the number of occurrences where a microcode assist is invoked by hardware Examples include AD (page Access Dirty), FP and AVX related assists.",
> -        "SampleAfterValue": "100003",
> -        "Speculative": "1",
> -        "UMask": "0x7"
> -    },
>      {
>          "BriefDescription": "Core cycles where the core was running in a manner where Turbo may be clipped to the Non-AVX turbo schedule.",
>          "CollectPEBSRecord": "2",
> @@ -407,4 +395,4 @@
>          "Speculative": "1",
>          "UMask": "0x1"
>      }
> -]
> \ No newline at end of file
> +]
> diff --git a/tools/perf/pmu-events/arch/x86/icelake/pipeline.json b/tools/perf/pmu-events/arch/x86/icelake/pipeline.json
> index 573ac7ac8879..2b58cfaaaf39 100644
> --- a/tools/perf/pmu-events/arch/x86/icelake/pipeline.json
> +++ b/tools/perf/pmu-events/arch/x86/icelake/pipeline.json
> @@ -12,6 +12,18 @@
>          "Speculative": "1",
>          "UMask": "0x9"
>      },
> +    {
> +        "BriefDescription": "Number of occurrences where a microcode assist is invoked by hardware.",
> +        "CollectPEBSRecord": "2",
> +        "Counter": "0,1,2,3,4,5,6,7",
> +        "EventCode": "0xc1",
> +        "EventName": "ASSISTS.ANY",
> +        "PEBScounters": "0,1,2,3,4,5,6,7",
> +        "PublicDescription": "Counts the number of occurrences where a microcode assist is invoked by hardware Examples include AD (page Access Dirty), FP and AVX related assists.",
> +        "SampleAfterValue": "100003",
> +        "Speculative": "1",
> +        "UMask": "0x7"
> +    },
>      {
>          "BriefDescription": "All branch instructions retired.",
>          "CollectPEBSRecord": "2",
> @@ -1102,4 +1114,4 @@
>          "SampleAfterValue": "1000003",
>          "UMask": "0x2"
>      }
> -]
> \ No newline at end of file
> +]
> -- 
> 2.36.0.rc0.470.gd361397f0d-goog

-- 

- Arnaldo