Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1028994pxb; Fri, 15 Apr 2022 18:53:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyH3q8xy4UXN/SuwNFYYYLIkRKXbsVeyKdrmI5wb1vksmq+FYZnehrfXPAD+ge8lee6isyY X-Received: by 2002:a65:6e9a:0:b0:382:1804:35c8 with SMTP id bm26-20020a656e9a000000b00382180435c8mr1335424pgb.584.1650074036944; Fri, 15 Apr 2022 18:53:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650074036; cv=none; d=google.com; s=arc-20160816; b=z+fNOzJmOE3yn/M5u933DN2MmpZpwSbAAdAohj3bVqCltJfSrNL4Z5ElwOlCPQPpxe evyrUOxbfA9pU6G0rKYmil7V51vXD32vZOhTJyBo8FK2XqttcAY1YEoSAfDXfSyIJ90a MuA1UPpphAiX/t6jZ2pSnfXDZoRXlpDJCwzPLfXkOx94aaSL1SCUGYg9gemj/sxvpney 6nK04vFone/JWynNohQUyBy7+0OjSdWtyvz54vpEQ9B9nnm+tcPBf8s3wjwbj+qfCkNx qu771RrklKFRPMmAukI7Bmmm3p3YSetKvqAH4x/tc4rr8LgkVNK4aa1A9uniouplHhY/ EE5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from; bh=js+44CzIALAxkegBSDPyLb8U+sU4MRhC+i8+CSuSmSY=; b=U8ZjxyXqk+6dLn0CCurYwo6h1hinMLxkhDYMdK1ZwyF6QHaAgXNB0qKoKMQ1e+xsVs W1320D4lakJz+uYjNqArk1h1yQ5XlxDCGgFHsLDIp7Ezr3/IB1pzVfDNRGDwHigEq7FV x3mbdtts081SZ4RH0yc9U7hj53hBZrfB8aPk8yIWpIlthPiUrwjBMKSv9e3n3FiY3Kbj lgiTQRg9wR+jkRxE8X6p1RuNr8mu1brlyDWD9v4Yy8iDpqJ3GYsqC4ujMKfZk5qoq8fM lqc808N4nzRbzeXPh2jUrSIoecNNaIhmxg+nQqof+QyWhg7470DFEeTmvQe4fQHFClMY HFBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id r1-20020a170903410100b001544c952660si2396749pld.353.2022.04.15.18.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 18:53:56 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0DBBC1342CC; Fri, 15 Apr 2022 18:15:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343510AbiDONTz (ORCPT + 99 others); Fri, 15 Apr 2022 09:19:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbiDONTz (ORCPT ); Fri, 15 Apr 2022 09:19:55 -0400 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5C48FA94D8 for ; Fri, 15 Apr 2022 06:17:26 -0700 (PDT) Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 5FFBC15F939; Fri, 15 Apr 2022 22:17:25 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.16.1/8.16.1/Debian-3) with ESMTPS id 23FDHMNc063300 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 15 Apr 2022 22:17:23 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.16.1/8.16.1/Debian-3) with ESMTPS id 23FDHMIm130305 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 15 Apr 2022 22:17:22 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.16.1/8.16.1/Submit) id 23FDHL8s130304; Fri, 15 Apr 2022 22:17:21 +0900 From: OGAWA Hirofumi To: Chung-Chiang Cheng Cc: linux-kernel@vger.kernel.org, kernel@cccheng.net, shepjeng@gmail.com Subject: Re: [PATCH v3 3/3] fat: report creation time in statx References: <20220415094518.380543-1-cccheng@synology.com> <20220415094518.380543-3-cccheng@synology.com> Date: Fri, 15 Apr 2022 22:17:21 +0900 In-Reply-To: <20220415094518.380543-3-cccheng@synology.com> (Chung-Chiang Cheng's message of "Fri, 15 Apr 2022 17:45:18 +0800") Message-ID: <87h76utrj2.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chung-Chiang Cheng writes: > @@ -568,10 +568,14 @@ int fat_fill_inode(struct inode *inode, struct msdos_dir_entry *de) > > fat_time_fat2unix(sbi, &inode->i_mtime, de->time, de->date, 0); > inode->i_ctime = inode->i_mtime; > - if (sbi->options.isvfat) > + if (sbi->options.isvfat) { > fat_time_fat2unix(sbi, &inode->i_atime, 0, de->adate, 0); > - else > + fat_time_fat2unix(sbi, &MSDOS_I(inode)->i_crtime, de->ctime, > + de->cdate, de->ctime_cs); > + } else { > fat_truncate_atime(sbi, &inode->i_mtime, &inode->i_atime); > + fat_truncate_crtime(sbi, &inode->i_mtime, &MSDOS_I(inode)->i_crtime); > + } Probably, nothing worth to update i_crtime here, right? Thanks. -- OGAWA Hirofumi