Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Jianglei Nie <niejianglei2021@163.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v2] ice: Fix memory leak in
 ice_get_orom_civd_data()
Thread-Topic: [Intel-wired-lan] [PATCH v2] ice: Fix memory leak in
 ice_get_orom_civd_data()
Thread-Index: AQHYSCtDZE71z52lN0ujZGrAMu8D/qzvBkgQ
Date:   Thu, 14 Apr 2022 06:46:50 +0000
Message-ID: <BYAPR11MB336754B300ED5C8103BA84FEFCEF9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220402021715.4740-1-niejianglei2021@163.com>
In-Reply-To: <20220402021715.4740-1-niejianglei2021@163.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HuV7/Bb1LYccfNVpx9ICDKJO8VFNzI1/yfwWTaWZcOj1AkYDnalBDoXBu6al?=
 =?us-ascii?Q?2auxTdHjZUzi+GRqfaaxmCbqkIvP/BN7iUhE7wXRkLlP9QGQAauvktcK0Jaa?=
 =?us-ascii?Q?O7jOAbZRO3cPDHL4pFYjsG47vFGrvRj4YLJ0fGx9aPkU7AiCm/8q0N9gt+tm?=
 =?us-ascii?Q?Ye9+s4y9fQ6v6cW2RCbprxRd69wA57GHf//mt3pCMKFpY69jyoCcph/1wgEw?=
 =?us-ascii?Q?lDRNPHEuAxiYpsf/f1m/sE8vmCw5qoQInIo/iw7Cbdnoq1900cODWADL++lG?=
 =?us-ascii?Q?3p9t06qY+JNgAD8IO7FjWreMHF0JHmsvjKNbqLPPh/NmC4LWaM6vTIrcvfTF?=
 =?us-ascii?Q?cYK802PLHc4Ye5RxE0ShJembwlpfq9KZwt92aCHALLG06tYNTvu0hIHsBnvw?=
 =?us-ascii?Q?EH+ybk2/tQ1bWMQWvV9w9rtrZxps6fOSv4TWUR/jCLdR7EubRE8dLX1XZIPC?=
 =?us-ascii?Q?IWMqmpFgmCI0QtE90u5J+oYgT7MStX23KT8oviAEsIwXVzUcOiYzLOoeHZ8n?=
 =?us-ascii?Q?hO4r46af1Knv9TLz92DhhDv8STfuG+3si9THXOyxAnEveXL4AU5otw9hbU/N?=
 =?us-ascii?Q?Pt6FKr1dymaX+duyPd4lFBlbe5Rh35qLgKC4LxfktMWYWuDsyWjQ6XaYaqec?=
 =?us-ascii?Q?e5P26iie4YJrJZGWDSte/9ilojSO2Kr+XzB4u6ZvKnvHob45s2/CLdo/8oe2?=
 =?us-ascii?Q?a2D+L4QTPZDTB02GkdG9x0V6Q0bHZNQ8RQ9fNwjiT6Gd+mcgJQDvUkNJCtmW?=
 =?us-ascii?Q?rBXZfmgCKCeizA4mnEimeZlu5UKv9zfsobMl8wAK9iA3KgoKrEHQPhnO5QjB?=
 =?us-ascii?Q?oVgANzNYy9tHMLhCx6AqG+ph4RNN8fpUrA9eGTqI8HpO8/jROyVVbS2RGTIM?=
 =?us-ascii?Q?h2tX9VN1rQpx+NsAfQd8uiwbk8SnAVU1DeQAtQ0pEOG5HHnuqPwiyrBMhS6J?=
 =?us-ascii?Q?ytowMVaIwTteVfSsBVVIFSQC/ciM1Zwt9fcLgQ2B3cNvRp0Qhd4Sx4shj/Dv?=
 =?us-ascii?Q?lkDdoSeUd4OKPktD5RMjCV2c8n7UosklOSnK6FeS+Gp3v7WUmR+Hk7fu8s7p?=
 =?us-ascii?Q?ijT9XJTSryVbgzit4chnFa4NSvC/u5XQRODDwOruaaIGrqUJPuQGWvq3clB4?=
 =?us-ascii?Q?lev+JPRbXiznbWmmDf/gHghZTlSG5lNc8OHZCFsKrZkOyMZ+C8VGzQj6AEzh?=
 =?us-ascii?Q?TadzYSe3TGJHF3ZWTlaEeDDWNH6cUt1nSg7v1GDC7IQZcCtsD/0WnO5HgSv6?=
 =?us-ascii?Q?7FRHoDSXcuw7RkvBaVNph2ZAA9ER2CA8s9Z2BM0/91Ej0tKkGbGc8IFBRNyt?=
 =?us-ascii?Q?at6PjVjkRBW+AIxMnAj7zno4a+KQ6VuvuxXoULUB9Suvy9rX0r20ZNZNfk0Y?=
 =?us-ascii?Q?FFGENmj/TwnwJgS8lGSdk3O6nPvPb6DgWEtvQL6D+1SYPjZGlaVn9yLkOeEs?=
 =?us-ascii?Q?k34ea2lprhnF69eInHc84KBNjn8K7p1ESsqgaHlJM0H6CS0d03JufbjM7OP7?=
 =?us-ascii?Q?SYHy68Axmy9UhY94GbvgkPaKSOVSVv2fC0cuA0VCdL88qCCAknUZCaM+7q9w?=
 =?us-ascii?Q?q6wrno/BMy/Z6l2oDdxsIdh5g0YKObC2HzZPMhPB++lQBwQcZ9CDCUnkoCgo?=
 =?us-ascii?Q?Za9Oqzh8ME1bcrQRmNYjljWP3eQEJLA7j6HjuyOpKzahnbY30KSWrGCENwKA?=
 =?us-ascii?Q?rZAiLCkrU+z6qiAEw4akYdlqFi+2PKxpqOSdHDJmTm4OrKYyZvMD5x0VECji?=
 =?us-ascii?Q?fFbuxdBMAw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3388ffa-914d-49f4-078f-08da1de28e23
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 06:46:50.9727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C9DfRK70DZNEriWSeCaDZspW+LKu/VCnibRa0rR31Aa1A6gn7dMoC1/L5XEjO3jtLi9y2LT8HsRYwtW4NsAWvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4816
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jianglei Nie
> Sent: Saturday, April 2, 2022 7:47 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; davem@davemloft.net; kuba@kernel.org
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-
> kernel@vger.kernel.org; Jianglei Nie <niejianglei2021@163.com>
> Subject: [Intel-wired-lan] [PATCH v2] ice: Fix memory leak in
> ice_get_orom_civd_data()
>=20
> A memory chunk was allocated for orom_data in ice_get_orom_civd_data()
> by vzmalloc(). But when ice_read_flash_module() fails, the allocated
> memory is not freed, which will lead to a memory leak.
>=20
> We can fix it by freeing the orom_data when ce_read_flash_module() fails.
>=20
> Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_nvm.c | 1 +
>  1 file changed, 1 insertion(+)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)