Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <523330e4-cbd7-62a6-9368-417534ddb0b6@suse.com>
Date:   Thu, 14 Apr 2022 09:31:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] net: ax88179: add proper error handling of usb read
 errors
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        David Kahurani <k.kahurani@gmail.com>
CC:     netdev@vger.kernel.org,
        syzbot <syzbot+d3dbdf31fbe9d8f5f311@syzkaller.appspotmail.com>,
        davem@davemloft.net, jgg@ziepe.ca, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Phillip Potter <phil@philpotter.co.uk>,
        syzkaller-bugs@googlegroups.com, arnd@arndb.de,
        Pavel Skripkin <paskripkin@gmail.com>
References: <20220404151036.265901-1-k.kahurani@gmail.com>
 <20220404153151.GF3293@kadam>
 <CAAZOf25i_mLO9igOY5wiUaxLOsxMt3jrvytSm1wm95R-bdKysA@mail.gmail.com>
 <20220413153249.GZ12805@kadam>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220413153249.GZ12805@kadam>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z61Lw9Qj+isS4NYfidFeg+UNbQZvrRgOLLhUhqd86W37VMm8KvSgqgJ1Eo/J?=
 =?us-ascii?Q?rkOH5Z5vIffzII96yfHsRI+djQAMFx4WOe1rb5i444lJxeJd1i3qWX3zYejw?=
 =?us-ascii?Q?Iz3dvbC2RvEXLLAQB4QGLY0+tn5NHzO33hF3DGNeYevfnT3B+niDkcsidULV?=
 =?us-ascii?Q?7YcEyZxE/B7eOUpu/O9NXskq4+AA8n+AwGK84w4xEAlq35c1mjJnlk6SeajE?=
 =?us-ascii?Q?Ex9rp9OXGms9YLPTlNTkTcca2ICn6g6vNhHFwW4Kd/SQs/WNLQhpUzxJbHZA?=
 =?us-ascii?Q?jdCZB6LlU+703WeoHlN/ppKl14+F+mM+a/AZDw+dBdPNI30W2VK7IsfFiAwb?=
 =?us-ascii?Q?eFTh+rM17PO6oABJ5Bnqou2G2DSBoVY2w5V/RYruxl3YAzxUUwaiMvzJh4Fa?=
 =?us-ascii?Q?yXR7HhOxH3mzJsBXMN+aJ/y8NwfoZ9sGb3rC/eVsSesn4nxP3ZuSwP2mOyVu?=
 =?us-ascii?Q?Xsjxhru51Rr8e9mUdCgbgYC4FltDOH8EdDe33kLBVXoz8xwpaUNGaf1SHCgu?=
 =?us-ascii?Q?lMWo79ddVAtAzUaez0Hznhfe3bxnna06oYRUS4JPOpOJ6dAHcdozMEckiIgL?=
 =?us-ascii?Q?gwW5xPZUy0qvTUIOwLMb8lTg3CPFd8lJbi8a3Ep2RWDkgpvbZfStZafnpo+n?=
 =?us-ascii?Q?atKgKONWss9TG7h7iiVSGveFwEEoq1pqNdVw/5dfwqmSKfSOM8dbvz/0rp8O?=
 =?us-ascii?Q?T1XlBL6YOL4H6TbRKOt8Qa2WhaqkB6kKXR58Z9+CI8gISewes51ntKkruak/?=
 =?us-ascii?Q?FXHIzZymmGilr3dR1FGwMfvqzTnVLlsnGJhPE445/fSeHs9u6LZduWBKrHUa?=
 =?us-ascii?Q?c2UVpkjvlZARP7N53aNvpKMXAfuQ88qfa4kE3+0PC1plcCpBsmSv3Q20HCNM?=
 =?us-ascii?Q?BV/HE5tCjwO4MVv2YdB6KSIr8plynrXhwtXXQKWJj9oKr+cqPlbDQHnrA2oQ?=
 =?us-ascii?Q?3baceL8eL3pg/RLlThcGjM7ixKTxifmr+lAH05ExJRHaFWDc98IFa0EPPyEs?=
 =?us-ascii?Q?5xbj8ZMYbhFeQyDzzvhrnQLpNprupiyArJuVGCU/WMGLPZ34MuuuaAi5dUNZ?=
 =?us-ascii?Q?Qlw4U4EcSoHTDyGnVFrrDF6D6ZA2rMxFk3GXDMCHq6zpZUcVEvwJyWRvRYy+?=
 =?us-ascii?Q?Qs4aeLFGWGj7JadB9IwyyFvlIk76QRo8NGfDNWGNO47Ch24xeRaLTRobACSx?=
 =?us-ascii?Q?BtzbQAeN3frBTVPAByYLui8PC0yok6aVJPOQoAfFFnfhRLbJdttuC+mwirTk?=
 =?us-ascii?Q?bJFx//tUacr8oKzEwdsEyRFvWnsCsOAoxcKrZVY4foXuNV8DqPJRlLNRQAp7?=
 =?us-ascii?Q?crh22nzrYfM2MbDYXf2gPHzwlmjnCBHzStYvIudi5Dr3A8LLV9ewL/OcZYI4?=
 =?us-ascii?Q?itGEmp71kvAYqdjDkl8MtLkq+8yuWDEjUhW+Imv9aFxAzgNC9MAFvfVEdY8P?=
 =?us-ascii?Q?9zcRgub2gbycVxCTLkN4hf3UjvvQcD+UHAxArIeL5rCLRT4s3Gio/NUuIMrT?=
 =?us-ascii?Q?uQPhiAuEFB1p9Sg9Tz8HzjfjWY7PVmN4HLo4vLGs8WrseTZ7PiMHxIvOEiX8?=
 =?us-ascii?Q?beRO4CKrYhbi3QDFaQB0RPz4qXuwNyfUnr7uJrERm+CaTrSopLG2kffHZZpk?=
 =?us-ascii?Q?xLlopSsLPIhcK91dSkzRBetI3ldsrnBkYBfK7boEY/nFC1hXhffewsp6FaNv?=
 =?us-ascii?Q?otslaXXfIzBVpCkvQKD3EVaPde9NtlSBAfGtJx9E87AO0ZaSbirq8UBIKy2X?=
 =?us-ascii?Q?Hxw5r6uKjJJmg28dyIiBP4iBtonF5GGnQrJB926DVVo5r5CFQ4Y0YURd3yS1?=
X-MS-Exchange-AntiSpam-MessageData-1: sJGb/Tb6KV9/Lg==
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 128f1fbf-f423-4419-8cae-08da1de8dbfd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 07:31:58.9447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eaXBCjRT88LRz09wYfJjN9TA7Z+JX2kf2jGpOjyFMJaiO3tkqxVHKkbUtrnVBMt6mdt4L2lqTbEtXqHZWM9hLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6871
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13.04.22 17:32, Dan Carpenter wrote:
>
> Bug: buffer partially filled.  Information leak.
>
> If you return the bytes then the only correct way to write error
> handling is:
>
> 	if (ret < 0)
> 		return ret;
> 	if (ret !=3D size)
> 		return -EIO;
>
You have to make up your mind on whether you ever need to read
answer of a length not known before you try it. The alternative of
passing a pointer to an integer for length is worse.

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver